Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGL not being blocked in workers #11839

Closed
pilgrim-brave opened this issue Sep 24, 2020 · 6 comments · Fixed by brave/brave-core#6695
Closed

WebGL not being blocked in workers #11839

pilgrim-brave opened this issue Sep 24, 2020 · 6 comments · Fixed by brave/brave-core#6695
Assignees
Labels
OS/Android Fixes related to Android browser functionality OS/Desktop QA/No release-notes/exclude

Comments

@pilgrim-brave
Copy link

Noted in #11368 (comment)

@btlechowski
Copy link

@pilgrim-brave Could you include test plan for this issue?

@pes10k
Copy link
Contributor

pes10k commented Sep 30, 2020

Hi @btlechowski, the test plan is to just make sure that all the values on the "WebGL Drawing" row on https://dev-pages.bravesoftware.com/farbling.html and https://dev-pages.brave.software/farbling.html match.

I believe @pilgrim-brave is working out some edge cases still but once he gives the 👍 , thats the test plan. Hope that helps!

@LaurenWags
Copy link
Member

@pes10k looks like this isn't working as per #11839 (comment) (note, sites were viewed with default shields/FP=Standard)

Do you want to check the sites to confirm they're set up correctly before I log a follow up issue?

Brave 1.16.52 Chromium: 86.0.4240.68 (Official Build) dev (x86_64)
Revision ad72ee9aa8e15ed300df1238e76c7a8f4d686f97-refs/branch-heads/4240@{#1097}
OS macOS Version 10.14.6 (Build 18G3020)

Screen Shot 2020-10-05 at 11 31 41 AM

labeling as QA/Blocked until the above is sorted

@pes10k
Copy link
Contributor

pes10k commented Oct 6, 2020

Thanks @LaurenWags, the current tests are correct, so I think @pilgrim-brave will be needed to figure out the way forward here

@LaurenWags
Copy link
Member

holding on logging a follow up until @pes10k is able to review #11368 (comment)

@LaurenWags
Copy link
Member

Still seeing some issues with this - logged follow up issue #12098

Going to mark this one as QA/No and release-notes/exclude since testing will be done with the above issue. Please let me know if there are any objections @rebron @pes10k .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OS/Android Fixes related to Android browser functionality OS/Desktop QA/No release-notes/exclude
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants