Rebase brave omaha to v1.3.36.111 #11904

simonhong · 2020-09-29T07:05:31Z

https://github.com/google/omaha/releases/tag/v1.3.36.111

Testers: Please see brave/brave-core#11096 for a test plan.

LaurenWags · 2021-12-17T16:28:19Z

labelling as QA/Blocked due to:

Information on logging needed (@mihaiplesa to provide)
This will be tested with an RC for 1.34.x, so need to wait until after channel migrations to test this

cc @stephendonner @kjozwiak

mherrmann · 2021-12-17T16:43:01Z

Hi, I don't know if this helps but some logging instructions are linked to in brave/brave-core#11096.

LaurenWags · 2021-12-29T21:29:39Z

@brave/legacy_qa this is no longer blocked, 1.34.76 is available: https://github.com/brave/brave-browser/releases/tag/v1.34.76

GeetaSarvadnya · 2022-01-03T11:21:22Z

Verification passed on

Brave | 1.34.76 Chromium: 97.0.4692.56 (Official Build) (64-bit)
-- | --
Revision | 04da6c66398ca50e603cc236a07dc7dfd3bbc750-refs/branch-heads/4692@{#990}
OS | Windows 10 Version 21H2 (Build 19044.1415)

Verified the test plan from Rebase Omaha (=updater on Windows) to v1.3.36.111 brave-core#11096

Windows 10 x64 - Physical machine

Case 1. Install different installers from GH_PASSED

Download BraveBrowserStandaloneSetup.exe from Github and install the setup file and confirm brave 1.34.76 is installed successfully and version details are shown correctly in brave://help
Download BraveBrowserSetup.exe stub installer from GH and install the setup file and confirm brave 1.33.106 is installed and confirmed latest RC version is pulled from Omaha update server and version details are shown correctly in brave://help
Download BraveBrowserStandaloneSilentSetup.exe from GH and install the setup file and confirm brave 1.34.76 is installed successfully also confirm that StandaloneSilentSetup.exe do not show any UI or launching Brave.
Download stub installed from GH or download brave from Chrome/Firefox/IE and install brave and confirm latest RC 1.33.106 is installed successfully, update brave to test channel by installing BraveBrowserSetup-64-r-test and confirmed brave 1.34.77 is updated to test channel without any issues.

1.33.106 - Relaunch	1.34.77 test channel

Case 2. Re-installing the same version_PASSED

Install BraveBrowserStandaloneSetup.exe setup file and confirm brave 1.34.76 is installed successfully and version details are shown correctly in brave://help. Re-Install standalone installer and confirm 1.34.76 is installed and two browser windows with same version 1.34.76 is observed
Install BraveBrowserStandaloneSilentSetup.exe setup file and confirm brave 1.34.76 is installed successfully and version details are shown correctly in brave://help. Re-Install standalone silent installer and confirm 1.34.76 is installed.
Install BraveBrowserSetup.exe setup file and confirm brave 1.33.106 is installed successfully and version details are shown correctly in brave://help. Re-Install stub installer and confirm 1.33.106 is installed and two browser windows with the same version 1.33.106 is observed

Case 3. Installing a new version by older version from different installers_PASSED

BraveBrowserSetup > BraveBrowserStandaloneSetup : Install BraveBrowserSetup and ensured 1.33.106 is installed and then install 1.34.76 StandaloneSetup on top of it and ensured 1.34.76 is installed successfully.
BraveBrowserSetup > BraveBrowserStandaloneSilentSetup: Install BraveBrowserSetup (with admin privileges) and ensure 1.33.106 is installed and then install 1.34.76 Standalone Silent Setup on top of it and observed brave didn't get updated to 1.34.76 which is expected as the silent setup is for non-admin install (see for clarification Rebase brave omaha to v1.3.36.111 #11904 (comment))
BraveBrowserStandaloneSetup (1.33.x) > BraveBrowserStandaloneSetup (1.34.x): Install 1.33.x standalone installer and confirm 1.33.x is installed and then install 1.34.76 standalone installer on top of it and ensured 1.34.76 is installed successfully
BraveBrowserStandaloneSilentSetup (1.33.x) > BraveBrowserStandaloneSetup (1.34.x): Install 1.33.x standalone silent installer and confirm 1.33.x is installed and then install 1.34.76 standalone installer on top of it and ensured 1.34.76 is installed successfully
BraveBrowserStandaloneSilentSetup (1.33.x)>BraveBrowserStandaloneSilentSetup(1.34.x): Install 1.33.x standalone silent installer and confirm 1.33.x is installed and then install 1.34.76 standalone silent installer on top of it and ensured 1.34.76 is installed successfully

Case 4. Install brave when the Internet is disconnected_PASSED

Disconnect the internet and install BraveBrowserStandaloneSetup.exe setup file and confirm brave 1.34.76 is installed successfully and version details are shown correctly in brave://help
Disconnect the internet and install BraveBrowserStandaloneSilentSetup.exe setup file and confirm brave 1.34.76 is installed successfully and version details are shown correctly in brave://help

Case 5. Admin privileges_PASSED

Admin privileges with Yes selection in UAC

Confirmed Standalone setup installer can be installed successfully with Admin privileges and confirmed brave version is shown correctly in brave://help
Confirmed Standalone silent setup installer can be installed without admin privileges and confirmed brave version is shown correctly in brave://help (silent installer doesn't show any UI or launching brave)
Confirmed Stub installers can be installed successfully with Admin privileges and confirmed brave version is shown correctly in brave://help
Installed stub installer BraveBrowserSetup with admin privileges and confirmed 1.33.106 is installed successfully and then install BraveBrowserSetup-64-r-test with admin privileges and confirmed brave is updated to test channel 1.34.77
Installed 1.33.106 BraveBrowserStandaloneSetup with admin privileges and confirmed 1.33.106 installed successfully and then install 1.34.76 BraveBrowserStandaloneSetup with admin privileges and confirmed 1.34.76 installed

Admin privileges but the user declines admin rights in the UAC prompt

Double click on the BraveBrowserStandaloneSetup installer and select No in the UAC modal popup and select Yes in the ...install without administrator privileges. Continue? prompt and confirmed brave start installing without admin privileges successfully.
Confirmed Stub installer can be installed without Admin privileges and confirmed brave 1.33.106 version details are shown correctly in brave://help.
Installed 1.33.106 Standalone installer without Admin privileges and confirmed brave 1.33.106 is installed and then install 1 34.76 installer without Admin privileges and confirmed brave 1.34.76 is updated successfully.

Case 6. Install quite older installers and check update works correctly_PASSED

Case 6.1: Install 1.25.x and check for updates

1.25.x	1.33.106

Case 6.2: Install 1.27.x and check for updates

1.27.x	1.33.106

Case 6.3: Install 1.29.x and check for updates

1.29.x	1.33.106

Case 6.4: Install 1.31.x and check for updates

1.31.x	1.33.106

Case 6.5: Install 1.20.x and check for updates

1.20.x	1.33.106

Case 6.6: Install 1.22.x and check for updates

1.22.x	1.33.106

Case 6.7: Install 1.24.x and check for updates

1.24.x	1.33.106

Case 6.8: Install 1.19.x and check for updates

1.19.x	1.33.106

Windows 8.1 x64 - VM

Case 1. Install different installers from GH_PASSED

Download BraveBrowserStandaloneSetup.exe from Github and install the setup file and confirm brave 1.34.76 is installed successfully and version details are shown correctly in brave://help
Download BraveBrowserSetup.exe stub installer from GH and install the setup file and confirm brave 1.33.106 is installed and confirmed latest RC version is pulled from Omaha update server and version details are shown correctly in brave://help
Download BraveBrowserStandaloneSilentSetup.exe from GH and install the setup file and confirm brave 1.34.76 is installed successfully also confirm that StandaloneSilentSetup.exe do not show any UI or launching Brave.
Download stub installed from GH or download brave from Chrome/Firefox/IE and install brave and confirm latest RC 1.33.106 is installed successfully, update brave to test channel by installing BraveBrowserSetup-64-r-test and confirmed brave 1.34.77 is updated to test channel without any issues.

1.33.106 - Relaunch	1.34.77 test channel

Case 2. Re-installing the same version_PASSED

Install BraveBrowserStandaloneSetup.exe setup file and confirm brave 1.34.76 is installed successfully and version details are shown correctly in brave://help. Re-Install standalone installer and confirm 1.34.76 is installed and two browser windows with same version 1.34.76 is observed
Install BraveBrowserStandaloneSilentSetup.exe setup file and confirm brave 1.34.76 is installed successfully and version details are shown correctly in brave://help. Re-Install standalone silent installer and confirm 1.34.76 is installed.
Install BraveBrowserSetup.exe setup file and confirm brave 1.33.106 is installed successfully and version details are shown correctly in brave://help. Re-Install stub installer and confirm 1.33.106 is installed and two browser windows with the same version 1.33.106 is observed

Case 3. Installing a new version by older version from different installers_PASSED

BraveBrowserSetup > BraveBrowserStandaloneSetup : Install BraveBrowserSetup and ensured 1.33.106 is installed and then install 1.34.76 StandaloneSetup on top of it and ensured 1.34.76 is installed successfully.
BraveBrowserSetup > BraveBrowserStandaloneSilentSetup: Install BraveBrowserSetup (with admin privileges) and ensured 1.33.106 is installed and then install 1.34.76 Standalone Silent Setup on top of it and observed brave didn't get updated to 1.34.76 which is expected as the silent setup is for non-admin install
BraveBrowserStandaloneSetup (1.33.x) > BraveBrowserStandaloneSetup (1.34.x): Install 1.33.x standalone installer and confirm 1.33.x is installed and then install 1.34.76 standalone installer on top of it and ensured 1.34.76 is installed successfully
BraveBrowserStandaloneSilentSetup (1.33.x) > BraveBrowserStandaloneSetup (1.34.x): Install 1.33.x standalone silent installer and confirm 1.33.x is installed and then install 1.34.76 standalone installer on top of it and ensured 1.34.76 is installed successfully
BraveBrowserStandaloneSilentSetup (1.33.x)>BraveBrowserStandaloneSilentSetup(1.34.x): Install 1.33.x standalone silent installer and confirm 1.33.x is installed and then install 1.34.76 standalone silent installer on top of it and ensured 1.34.76 is installed successfully

Case 4. Install brave when the Internet is disconnected_PASSED

Disconnect the internet and install BraveBrowserStandaloneSetup.exe setup file and confirm brave 1.34.76 is installed successfully and version details are shown correctly in brave://help
Disconnect the internet and install BraveBrowserStandaloneSilentSetup.exe setup file and confirm brave 1.34.76 is installed successfully and version details are shown correctly in brave://help

Case 5. Admin privileges_PASSED

Admin privileges with Yes selection in UAC

Confirmed Standalone setup installer can be installed successfully with Admin privileges and confirmed brave version is shown correctly in brave://help
Confirmed Standalone silent setup installer can be installed without admin privileges and confirmed brave version is shown correctly in brave://help (silent installer doesn't show any UI or launching brave)
Confirmed Stub installers can be installed successfully with Admin privileges and confirmed brave version is shown correctly in brave://help
Installed stub installer BraveBrowserSetup with admin privileges and confirmed 1.33.106 is installed successfully and then install BraveBrowserSetup-64-r-test with admin privileges and confirmed brave is updated to test channel 1.34.77
Installed 1.33.106 BraveBrowserStandaloneSetup with admin privileges and confirmed 1.33.106 installed successfully and then install 1.34.76 BraveBrowserStandaloneSetup with admin privileges and confirmed 1.34.76 installed

Admin privileges but the user declines admin rights in the UAC prompt

Double click on the BraveBrowserStandaloneSetup installer and select No in the UAC modal popup and select Yes in the ...install without administrator privileges. Continue? prompt and confirmed brave start installing without admin privileges successfully.
Confirmed Stub installer can be installed without Admin privileges and confirmed brave 1.33.106 version details are shown correctly in brave://help.
Installed 1.33.106 Standalone installer without Admin privileges and confirmed brave 1.33.106 is installed and then install 1 34.76 installer without Admin privileges and confirmed brave 1.34.76 is updated successfully.

Case 6. Install quite older installers and check update works correctly_PASSED

Case 6.1: Install 1.27.x and check for updates

1.27.x	1.33.106

Case 6.2: Install 1.18.x and check for updates

1.18.x	1.33.106

Case 6.3: Install 1.12.x (without admin privileges) and check for updates

1.12.x	1.33.106

Verification passed on

Brave	1.34.78 Chromium: 97.0.4692.71 (Official Build) (64-bit)
Revision	adefa7837d02a07a604c1e6eff0b3a09422ab88d-refs/branch-heads/4692@{#1247}
OS	Windows 7 Service Pack 1 (Build 7601.24544)

Verified the test plan from Rebase Omaha (=updater on Windows) to v1.3.36.111 brave-core#11096

Windows 7 x64 - Physical machine

Case 1. Install different installers from GH_PASSED

Download BraveBrowserStandaloneSetup.exe from Github and install the setup file and confirm brave 1.34.78 is installed successfully and version details are shown correctly in brave://help
Download BraveBrowserSetup.exe stub installer from GH and install the setup file and confirm brave 1.33.106 is installed and confirmed latest RC version is pulled from Omaha update server and version details are shown correctly in brave://help
Download BraveBrowserStandaloneSilentSetup.exe from GH and install the setup file and confirm brave 1.34.78 is installed successfully also confirm that StandaloneSilentSetup.exe do not show any UI or launching Brave.
Download stub installed from GH or download brave from Chrome/Firefox/IE and install brave and confirm latest RC 1.33.106 is installed successfully, update brave to test channel by installing BraveBrowserSetup-64-r-test and confirmed brave 1.34.78 is updated to test channel without any issues.

Case 2. Re-installing the same version_PASSED

Install BraveBrowserStandaloneSetup.exe setup file and confirm brave 1.34.78 is installed successfully and version details are shown correctly in brave://help. Re-Install standalone installer and confirm 1.34.78 is installed and two browser windows with same version 1.34.78 is observed
Install BraveBrowserStandaloneSilentSetup.exe setup file and confirm brave 1.34.78 is installed successfully and version details are shown correctly in brave://help. Re-Install standalone silent installer and confirm 1.34.78 is installed.
Install BraveBrowserSetup.exe setup file and confirm brave 1.33.106 is installed successfully and version details are shown correctly in brave://help. Re-Install stub installer and confirm 1.33.106 is installed and two browser windows with the same version 1.33.106 is observed

Case 3. Installing a new version by older version from different installers_PASSED

BraveBrowserSetup > BraveBrowserStandaloneSetup : Install BraveBrowserSetup and ensured 1.33.106 is installed and then install 1.34.78 StandaloneSetup on top of it and ensured 1.34.78 is installed successfully.
BraveBrowserSetup > BraveBrowserStandaloneSilentSetup: Install BraveBrowserSetup (with admin privileges) and ensure 1.33.106 is installed and then install 1.34.78 Standalone Silent Setup on top of it and observed brave didn't get updated to 1.34.78 which is expected as the silent setup is for non-admin install (see for clarification Rebase brave omaha to v1.3.36.111 #11904 (comment))
BraveBrowserStandaloneSetup (1.33.x) > BraveBrowserStandaloneSetup (1.34.x): Install 1.33.x standalone installer and confirm 1.33.x is installed and then install 1.34.78 standalone installer on top of it and ensured 1.34.78 is installed successfully
BraveBrowserStandaloneSilentSetup (1.33.x) > BraveBrowserStandaloneSetup (1.34.x): Install 1.33.x standalone silent installer and confirm 1.33.x is installed and then install 1.34.78 standalone installer on top of it and ensured 1.34.78 is installed successfully
BraveBrowserStandaloneSilentSetup (1.33.x)>BraveBrowserStandaloneSilentSetup(1.34.x): Install 1.33.x standalone silent installer and confirm 1.33.x is installed and then install 1.34.78 standalone silent installer on top of it and ensured 1.34.78 is installed successfully

Case 4. Install brave when the Internet is disconnected_PASSED

Disconnect the internet and install BraveBrowserStandaloneSetup.exe setup file and confirm brave 1.34.78 is installed successfully and version details are shown correctly in brave://help
Disconnect the internet and install BraveBrowserStandaloneSilentSetup.exe setup file and confirm brave 1.34.78 is installed successfully and version details are shown correctly in brave://help

Case 5. Admin privileges_PASSED

Admin privileges with Yes selection in UAC

Confirmed Standalone setup installer can be installed successfully without admin privileges and confirmed brave version is shown correctly in brave://help
Confirmed Standalone silent setup installer can be installed without admin privileges and confirmed brave version is shown correctly in brave://help (silent installer doesn't show any UI or launching brave)
Confirmed Stub installers can be installed successfully with Admin privileges and confirmed brave version is shown correctly in brave://help
Installed stub installer BraveBrowserSetup with admin privileges and confirmed 1.33.106 is installed successfully and then install BraveBrowserSetup-64-r-test with admin privileges and confirmed brave is updated to test channel 1.34.78
Installed 1.33.106 BraveBrowserStandaloneSetup with admin privileges and confirmed 1.33.106 installed successfully and then install 1.34.78 BraveBrowserStandaloneSetup with admin privileges and confirmed 1.34.78 installed

Admin privileges but the user declines admin rights in the UAC prompt

Double click on the BraveBrowserStandaloneSetup installer and select No in the UAC modal popup and select Yes in the ...install without administrator privileges. Continue? prompt and confirmed brave start installing without admin privileges successfully.
Confirmed Stub installer can be installed without Admin privileges and confirmed brave 1.33.106 version details are shown correctly in brave://help.
Installed 1.33.106 Standalone installer without Admin privileges and confirmed brave 1.33.106 is installed and then install 1 34.78 installer without Admin privileges and confirmed brave 1.34.78 is updated successfully.

Case 6. Install quite older installers and check update works correctly_PASSED

Installed 1.20.x and check for updates PASS
Installed 1.25.x and check for updates PASS
Installed 1.31.x and check for updates PASS

Verification passed on

Brave	1.34.78 Chromium: 97.0.4692.71 (Official Build) (32-bit)
Revision	adefa7837d02a07a604c1e6eff0b3a09422ab88d-refs/branch-heads/4692@{#1247}
OS	Windows 7 Service Pack 1 (Build 7601.24544)

Verified the test plan from Rebase Omaha (=updater on Windows) to v1.3.36.111 brave-core#11096

Windows 7 x86 - VM

Case 1. Install different installers from GH_PASSED

Download BraveBrowserStandaloneSetup32.exe from Github and install the setup file and confirm brave 1.34.78 is installed successfully and version details are shown correctly in brave://help
Download BraveBrowserSetup32.exe stub installer from GH and install the setup file and confirm brave 1.33.106 is installed and confirmed latest RC version is pulled from Omaha update server and version details are shown correctly in brave://help
Download BraveBrowserStandaloneSilentSetup32.exe from GH and install the setup file and confirm brave 1.34.78 is installed successfully also confirm that StandaloneSilentSetup32.exe do not show any UI or launching Brave.
Download stub installed from GH or download brave from Chrome/Firefox/IE and install brave and confirm latest RC 1.33.106 is installed successfully, update brave to test channel by installing BraveBrowserSetup32-86-r-test and confirmed brave 1.34.78 is updated to test channel without any issues.

Case 2. Re-installing the same version_PASSED

Install BraveBrowserStandaloneSetup32.exe setup file and confirm brave 1.34.78 is installed successfully and version details are shown correctly in brave://help. Re-Install standalone installer and confirm 1.34.78 is installed and two browser windows with same version 1.34.78 is observed
Install BraveBrowserStandaloneSilentSetup32.exe setup file and confirm brave 1.34.78 is installed successfully and version details are shown correctly in brave://help. Re-Install standalone silent installer and confirm 1.34.78 is installed.
Install BraveBrowserSetup32.exe setup file and confirm brave 1.33.106 is installed successfully and version details are shown correctly in brave://help. Re-Install stub installer and confirm 1.33.106 is installed and two browser windows with the same version 1.33.106 is observed

Case 3. Installing a new version by older version from different installers_PASSED

BraveBrowserSetup32 > BraveBrowserStandaloneSetup32 : Install BraveBrowserSetup32 and ensured 1.33.106 is installed and then install 1.34.78 StandaloneSetup on top of it and ensured 1.34.78 is installed successfully.
BraveBrowserSetup32 > BraveBrowserStandaloneSilentSetup32: Install BraveBrowserSetup32 (with admin privileges) and ensure 1.33.106 is installed and then install 1.34.78 Standalone Silent Setup on top of it and observed brave didn't get updated to 1.34.78 which is expected as the silent setup is for non-admin install (see for clarification Rebase brave omaha to v1.3.36.111 #11904 (comment))
BraveBrowserStandaloneSetup32 (1.33.x) > BraveBrowserStandaloneSetup32 (1.34.x): Install 1.33.x standalone installer and confirm 1.33.x is installed and then install 1.34.78 standalone installer on top of it and ensured 1.34.78 is installed successfully
BraveBrowserStandaloneSilentSetup32 (1.33.x) > BraveBrowserStandaloneSetup32 (1.34.x): Install 1.33.x standalone silent installer and confirm 1.33.x is installed and then install 1.34.78 standalone installer on top of it and ensured 1.34.78 is installed successfully
BraveBrowserStandaloneSilentSetup32 (1.33.x)>BraveBrowserStandaloneSilentSetup32(1.34.x): Install 1.33.x standalone silent installer and confirm 1.33.x is installed and then install 1.34.78 standalone silent installer on top of it and ensured 1.34.78 is installed successfully

Case 4. Install brave when the Internet is disconnected_PASSED

Disconnect the internet and install BraveBrowserStandaloneSetup32.exe setup file and confirm brave 1.34.78 is installed successfully and version details are shown correctly in brave://help
Disconnect the internet and install BraveBrowserStandaloneSilentSetup32.exe setup file and confirm brave 1.34.78 is installed successfully and version details are shown correctly in brave://help

Case 5. Admin privileges_PASSED

Admin privileges with Yes selection in UAC

Confirmed Standalone setup installer can be installed successfully without admin privileges and confirmed brave version is shown correctly in brave://help
Confirmed Standalone silent setup installer can be installed without admin privileges and confirmed brave version is shown correctly in brave://help (silent installer doesn't show any UI or launching brave)
Confirmed Stub installers can be installed successfully with Admin privileges and confirmed brave version is shown correctly in brave://help
Installed stub installer BraveBrowserSetup32 with admin privileges and confirmed 1.33.106 is installed successfully and then install BraveBrowserSetup32-86-r-test with admin privileges and confirmed brave is updated to test channel 1.34.78
Installed 1.33.106 BraveBrowserStandaloneSetup32 with admin privileges and confirmed 1.33.106 installed successfully and then install 1.34.78 BraveBrowserStandaloneSetup32 with admin privileges and confirmed 1.34.78 installed

Admin privileges but the user declines admin rights in the UAC prompt

Double click on the BraveBrowserStandaloneSetup32 installer and select No in the UAC modal popup and select Yes in the ...install without administrator privileges. Continue? prompt and confirmed brave start installing without admin privileges successfully.
Confirmed Stub installer can be installed without Admin privileges and confirmed brave 1.33.106 version details are shown correctly in brave://help.
Installed 1.33.106 Standalone installer without Admin privileges and confirmed brave 1.33.106 is installed and then install 1 34.78 installer without Admin privileges and confirmed brave 1.34.78 is updated successfully.

Case 6. Install quite older installers and check update works correctly_PASSED

Installed 1.20.x and check for updates PASS
Installed 1.25.x and check for updates PASS
Installed 1.31.x and check for updates PASS

stephendonner · 2022-01-04T01:47:45Z

Verification PASSED on

Brave	1.34.77 Chromium: 97.0.4692.56 (Official Build) (64-bit)
Revision	04da6c66398ca50e603cc236a07dc7dfd3bbc750-refs/branch-heads/4692@{#990}
OS	Windows 10 Version 20H2 (Build 19042.1415)

Windows 10 x64 - Physical machine

Case 1. Install different installers from GitHub - PASSED

Download BraveBrowserStandaloneSetup.exe from Github and install the setup file and confirm brave 1.34.76 is installed successfully and version details are shown correctly in brave://help
Download BraveBrowserSetup.exe stub installer from GH and install the setup file and confirm brave 1.33.106 is installed and confirmed latest RC version is pulled from Omaha update server and version details are shown correctly in brave://help
Download BraveBrowserStandaloneSilentSetup.exe from GH and install the setup file and confirm brave 1.34.76 is installed successfully also confirm that StandaloneSilentSetup.exe do not show any UI or launching Brave.
Download stub installed from GH or download brave from Chrome/Firefox/IE and install brave and confirm latest RC 1.33.106 is installed successfully, update brave to test channel by installing BraveBrowserSetup-64-r-test and confirmed brave 1.34.77 is updated to test channel without any issues.

1.33.106 - Relaunch	1.34.77 test channel

Case 2. Re-installing the same version - PASSED

Install BraveBrowserStandaloneSetup.exe setup file and confirm brave 1.34.76 is installed successfully and version details are shown correctly in brave://help. Re-Install standalone installer and confirm 1.34.76 is installed and two browser windows with same version 1.34.76 is observed
Install BraveBrowserStandaloneSilentSetup.exe setup file and confirm brave 1.34.76 is installed successfully and version details are shown correctly in brave://help. Re-Install standalone silent installer and confirm 1.34.76 is installed and two browser windows with the same version 1.34.76 is observed
Install BraveBrowserSetup.exe setup file and confirm brave 1.33.106 is installed successfully and version details are shown correctly in brave://help. Re-Install stub installer and confirm 1.33.106 is installed and two browser windows with the same version 1.33.106 is observed

Case 3. Installing a new version by older version from different installers - PASSED

BraveBrowserSetup > BraveBrowserStandaloneSetup : Install BraveBrowserSetup and ensured 1.33.106 is installed and then install 1.34.76 StandaloneSetup on top of it and ensured 1.34.77 is installed successfully.
BraveBrowserSetup > BraveBrowserStandaloneSilentSetup: Install BraveBrowserSetup and ensured 1.33.106 is installed and then install 1.34.77 StandaloneSetup on top of it and ensured 1.34.77 is installed successfully.
BraveBrowserStandaloneSetup (1.33.x) > BraveBrowserStandaloneSetup (1.34.x): Install 1.33.x standalone installer and confirm 1.33.x is installed and then install 1.34.77 standalone installer on top of it and ensured 1.34.77 is installed successfully
BraveBrowserStandaloneSilentSetup (1.33.x) > BraveBrowserStandaloneSetup (1.34.x): Install 1.33.x standalone silent installer and confirm 1.33.x is installed and then install 1.34.77 standalone installer on top of it and ensured 1.34.77 is installed successfully

Case 4. Install Brave when the Internet is disconnected - PASSED

Disconnect the internet and install BraveBrowserStandaloneSetup.exe setup file and confirm brave 1.34.77 is installed successfully and version details are shown correctly in brave://help
Disconnect the internet and install BraveBrowserStandaloneSilentSetup.exe setup file and confirm brave 1.34.77 is installed successfully and version details are shown correctly in brave://help

Case 5. Admin privileges - PASSED

Admin privileges with Yes selection in UAC

Confirmed Standalone setup installer can be installed successfully with Admin privileges Yes and confirmed brave version is shown correctly in brave://help
Confirmed Standalone silent setup installer can be installed successfully with Admin privileges Yes and confirmed brave version is shown correctly in brave://help
Confirmed Stub installers can be installed successfully with Admin privileges Yes and confirmed brave version is shown correctly in brave://help
Installed stub installer BraveBrowserSetup with admin privileges and confirmed 1.33.106 is installed successfully and then install BraveBrowserSetup-64-r-test with admin privileges and confirmed brave is updated to test channel 1.34.77
Installed 1.33.106 BraveBrowserStandaloneSetup with admin privileges and confirmed 1.33.106 installed successfully and then install 1.34.76 BraveBrowserStandaloneSetup with admin privileges and confirmed 1.34.76 installed

Admin privileges but the user declines admin rights in the UAC prompt

Double click on the BraveBrowserStandaloneSetup installer and select No in the UAC modal popup and select Yes in the ...install without administrator privileges. Continue? prompt and confirmed brave start installing without admin privileges successfully.
Confirmed Stub installer can be installed without Admin privileges and confirmed brave 1.33.106 version details are shown correctly in brave://help.
Installed Standalone installer without Admin privileges and confirmed brave 1.33.106 is installed and then install 1 34.77 installer with Admin privileges and confirmed brave 1.34.77 is installed without admin privileges

GeetaSarvadnya · 2022-01-04T11:25:04Z

@mihaiplesa @mherrmann @linhkikuchi - When I install stub installer (BraveBrowserSetup.exe) which pulls the latest RC from Omaha update server and install the 1.33.106 as expected and if I install standalone silent installer (BraveBrowserStandaloneSilentSetup.exe_1.34.76) on top of it, brave doesn't get updated to 1.34.76, may I know the reason?

simonhong · 2022-01-04T11:47:35Z

@GeetaSarvadnya IIRC, silent setup is for non-admin install as it doesn't launch any UI.
If system already has brave with admin priv, silent setup will not do anything as it can't update currently installed one.
Based on this, I assume that you installed 1.33.106 with priv mode and then run silent installer?
If you install 1.33.106 w/o admin priv, silent install will update it.

GeetaSarvadnya · 2022-01-04T12:23:15Z

@simonhong Yes, that's correct I have installed a stub installer with Admin privileges and on top of it I was just installing a standalone silent installer (1.34.76). Thanks for the clarification. I have tried installing stub installer without admin privileges and on top of it I installed a standalone silent installer (1.34.76) and brave got updated to 1.34.76 successfully.

Thanks again @simonhong!

simonhong added OS/Windows dev-concern installer/omaha Issues for windows omaha installer OS/Desktop labels Sep 29, 2020

simonhong self-assigned this Sep 29, 2020

mihaiplesa changed the title ~~Rebase brave omaha to 1.3.36.31~~ Rebase brave omaha to v1.3.36.101 Oct 18, 2021

rebron added the priority/P2 A bad problem. We might uplift this to the next planned release. label Oct 19, 2021

rebron assigned mihaiplesa and rebron Oct 19, 2021

mihaiplesa changed the title ~~Rebase brave omaha to v1.3.36.101~~ Rebase brave omaha to v1.3.36.111 Oct 20, 2021

mihaiplesa assigned mherrmann and unassigned rebron and simonhong Nov 1, 2021

This was referenced Nov 3, 2021

Rebase on top of v1.3.36.111 brave/omaha#36

Closed

Rebase Omaha (=updater on Windows) to v1.3.36.111 brave/brave-core#10883

Closed

mihaiplesa assigned linhkikuchi Nov 9, 2021

mherrmann mentioned this issue Nov 15, 2021

Rebase Omaha (=updater on Windows) to v1.3.36.111 brave/brave-core#11096

Merged

16 tasks

mherrmann closed this as completed in brave/brave-core#11096 Nov 25, 2021

mihaiplesa added this to the 1.34.x - Nightly milestone Nov 26, 2021

mherrmann added QA/Yes release-notes/include labels Nov 30, 2021

LaurenWags added the QA/Blocked label Dec 17, 2021

LaurenWags removed the QA/Blocked label Dec 29, 2021

stephendonner added the QA Pass-Win64 label Jan 4, 2022

GeetaSarvadnya removed the QA Pass-Win64 label Jan 4, 2022

LaurenWags mentioned this issue Jan 4, 2022

[Desktop] Release notes for 1.34.x - Release #20322

Closed

kjozwiak added QA Pass-Win64 QA Pass-Win86 labels Jan 6, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rebase brave omaha to v1.3.36.111 #11904

Rebase brave omaha to v1.3.36.111 #11904

simonhong commented Sep 29, 2020 •

edited by mherrmann

Loading

LaurenWags commented Dec 17, 2021 •

edited

Loading

mherrmann commented Dec 17, 2021

LaurenWags commented Dec 29, 2021

GeetaSarvadnya commented Jan 3, 2022 •

edited by btlechowski

Loading

stephendonner commented Jan 4, 2022 •

edited

Loading

GeetaSarvadnya commented Jan 4, 2022 •

edited

Loading

simonhong commented Jan 4, 2022

GeetaSarvadnya commented Jan 4, 2022

Rebase brave omaha to v1.3.36.111 #11904

Rebase brave omaha to v1.3.36.111 #11904

Comments

simonhong commented Sep 29, 2020 • edited by mherrmann Loading

LaurenWags commented Dec 17, 2021 • edited Loading

mherrmann commented Dec 17, 2021

LaurenWags commented Dec 29, 2021

GeetaSarvadnya commented Jan 3, 2022 • edited by btlechowski Loading

Windows 10 x64 - Physical machine

Windows 8.1 x64 - VM

Windows 7 x64 - Physical machine

Windows 7 x86 - VM

stephendonner commented Jan 4, 2022 • edited Loading

GeetaSarvadnya commented Jan 4, 2022 • edited Loading

simonhong commented Jan 4, 2022

GeetaSarvadnya commented Jan 4, 2022

simonhong commented Sep 29, 2020 •

edited by mherrmann

Loading

LaurenWags commented Dec 17, 2021 •

edited

Loading

GeetaSarvadnya commented Jan 3, 2022 •

edited by btlechowski

Loading

stephendonner commented Jan 4, 2022 •

edited

Loading

GeetaSarvadnya commented Jan 4, 2022 •

edited

Loading