Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Your Brave wallet is powered by Uphold is not translated #12012

Closed
btlechowski opened this issue Oct 6, 2020 · 4 comments
Closed

Your Brave wallet is powered by Uphold is not translated #12012

btlechowski opened this issue Oct 6, 2020 · 4 comments

Comments

@btlechowski
Copy link

This is a regression in 1.5.71, Not reproducible in 1.5.70.

Steps to Reproduce

  1. Run Brave in Polish locale
  2. Enable rewards
  3. Open brave://rewards

Actual result:

Your Brave wallet is powered by Uphold is not translated
image

Expected result:

Your Brave wallet is powered by Uphold is translated
image

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Brave 1.15.71 Chromium: 86.0.4240.72 (Official Build) (64-bit)
Revision 581582174c512f44f44fd1aea340471f54b2365f-refs/branch-heads/4240@{#1134}
OS Ubuntu 18.04 LTS

cc @brave/legacy_qa @mkarolin @rebron

@LaurenWags
Copy link
Member

Reproduced on macOS using French and German with


Brave | 1.15.71 Chromium: 86.0.4240.72 (Offizieller Build) (x86_64)
-- | --
Überarbeitung | 581582174c512f44f44fd1aea340471f54b2365f-refs/branch-heads/4240@{#1134}
Betriebssystem | macOS Version 10.14.6 (Build 18G3020)

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Oct 6, 2020

Reproduced in Windows 10 x64 - 1.15.71

Locale Kannada
image

mkarolin added a commit to brave/brave-core that referenced this issue Oct 6, 2020
Brings back all strings that were removed as a result of uplifting the
latest l10n changes from transifex.

Fixes brave/brave-browser#12012
Fixes brave/brave-browser#12013
Fixes brave/brave-browser#12017
@kjozwiak
Copy link
Member

kjozwiak commented Oct 7, 2020

Closing and moved into https://github.com/brave/brave-browser/milestone/135 as brave/brave-core#6788 has been merged into 1.15.x 👍

@kjozwiak kjozwiak closed this as completed Oct 7, 2020
@kjozwiak kjozwiak added this to the 1.15.x - Release #1 milestone Oct 7, 2020
@LaurenWags
Copy link
Member

LaurenWags commented Oct 7, 2020

Verified passed with

Brave | 1.15.72 Chromium: 86.0.4240.75 (Offizieller Build) (x86_64)
-- | --
Überarbeitung | c69c33933bfc72a159aceb4aeca939eb0087416c-refs/branch-heads/4240@{#1149}
Betriebssystem | macOS Version 10.14.6 (Build 18G3020)

Verified STR from description for both French and German:

French
12012 French

German
12012 German


Verification passed on

Brave 1.15.72 Chromium: 86.0.4240.75 (Official Build) (64-bit)
Revision c69c33933bfc72a159aceb4aeca939eb0087416c-refs/branch-heads/4240@{#1149}
OS Ubuntu 18.04 LTS

Verified STR from description

image


Verification passed on

क्रोमियम 1.15.72 Chromium: 86.0.4240.75 (आधिकारिक बिल्ड) (64-बिट)
पुनरीक्षण c69c33933bfc72a159aceb4aeca939eb0087416c-refs/branch-heads/4240@{#1149}
OS Windows 8.1 (Build 9600.19817)

image

Brave	1.15.72 Chromium: 86.0.4240.75 (ಅಧಿಕೃತವಾಗಿ ನಿರ್ಮಿಸಿ) (64-ಬಿಟ್)
ಪರಿಷ್ಕರಣೆ	c69c33933bfc72a159aceb4aeca939eb0087416c-refs/branch-heads/4240@{#1149}
OS	Windows 10 OS Version 1809 (Build 17763.1397)

Kannada
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants