Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't tip GitHub publisher when multiple contributors made commit #12175

Closed
emerick opened this issue Oct 16, 2020 · 3 comments
Closed

Can't tip GitHub publisher when multiple contributors made commit #12175

emerick opened this issue Oct 16, 2020 · 3 comments
Assignees
@emerick
Labels
feature/rewards greaselion/github OS/Desktop priority/P4 Planned work. We expect to get to it "soon". QA Pass-macOS QA/Yes release-notes/exclude
Milestone
1.62.x - Release

Comments

@emerick
Copy link
Contributor

emerick commented Oct 16, 2020

Description

When visiting the Github commits page for a project, if you attempt to tip a commit made by multiple authors it will fail. The message in the console shows Uncaught (in promise) Error: Failed to parse DOM.

Steps to Reproduce

  1. Enable Rewards
  2. Visit https://github.com/zenparsing/zen-observable/commits/master or similar
  3. Find a commit with authored and committed messages, like "Kevin Smith authored and Kevin Smith committed"
  4. Tip the commit

Actual result:

The tip dialog isn't displayed.

Expected result:

Tip dialog should display as expected.

Reproduces how often:

100% of the time.

Desktop Brave version:

Android Device details:

  • Install type (ARM, x86):
  • Device type (Phone, Tablet, Phablet):
  • Android version:

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:
@Miyayes Miyayes added the priority/P4 Planned work. We expect to get to it "soon". label Mar 29, 2023
@emerick
Copy link
Contributor Author

emerick commented Nov 7, 2023

Closing as this has been superseded by #33783

@emerick emerick closed this as completed Nov 7, 2023
@emerick emerick added this to the 1.62.x - Nightly milestone Nov 7, 2023
@stephendonner stephendonner changed the title Can't tip Github publisher when multiple contributers made commit Can't tip GitHub publisher when multiple contributors made commit Nov 8, 2023
@LaurenWags LaurenWags added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Nov 28, 2023
@LaurenWags
Copy link
Member

LaurenWags commented Nov 28, 2023 •
edited
Loading

Verified with

Brave | 1.62.87 Chromium: 120.0.6099.35 (Official Build) nightly (x86_64)
-- | --
Revision | e0cd7777fe0c2b5f4fe9e1bc27cedd1f87eac37f
OS | macOS Version 13.6.1 (Build 22G313)

Confirmed in-line tip icon no longer displayed on the page using STR from description.

GH

@LaurenWags LaurenWags added QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Nov 28, 2023
@LaurenWags LaurenWags mentioned this issue Jan 24, 2024
Closed
@LaurenWags
Copy link
Member

Changing to release-notes/exclude per discussion with @Miyayes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emerick emerick

Labels
feature/rewards greaselion/github OS/Desktop priority/P4 Planned work. We expect to get to it "soon". QA Pass-macOS QA/Yes release-notes/exclude
Projects
Brave Rewards
Status: Done
Milestone
1.62.x - Release
Development

No branches or pull requests
3 participants
@emerick @Miyayes @LaurenWags