Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove inline Tip buttons #33783

Closed
2 tasks done
Miyayes opened this issue Oct 20, 2023 · 4 comments · Fixed by brave/brave-core#20873
Closed
2 tasks done

Remove inline Tip buttons #33783

Miyayes opened this issue Oct 20, 2023 · 4 comments · Fixed by brave/brave-core#20873
Assignees
@emerick
Labels
feature/rewards greaselion OS/Desktop perf priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/include
Milestone
1.62.x - Release

Comments

@Miyayes
Copy link
Collaborator

Miyayes commented Oct 20, 2023 •
edited
Loading

Description

Tasks
Beta Give feedback

cc: @bridiver @tmancey
@Miyayes Miyayes added perf priority/P2 A bad problem. We might uplift this to the next planned release. labels Oct 20, 2023
@Miyayes Miyayes changed the title Do not show inline Tip buttons prior to Rewards enablement Remove inline Tip buttons Nov 4, 2023
This was referenced Nov 7, 2023
Merged
Closed
Closed
Closed
Closed
@emerick emerick added this to the 1.62.x - Nightly milestone Nov 7, 2023
@emerick emerick mentioned this issue Nov 15, 2023
Closed
@LaurenWags
Copy link
Member

@brave/qa-team let's do full checks on Windows and macOS and limited checks on Linux for this one

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Dec 13, 2023 •
edited
Loading

Verification PASSED on

Brave | 1.62.105 Chromium: 120.0.6099.71 (Official Build) beta (64-bit)
-- | --
Revision | f72c783bcd52110d026061575b4bef28ccb547f7
OS | Windows 10 Version 22H2 (Build 19045.3693)

Clean profile

Enable rewards_PASSED
  1. Clean profile launch brave using brave.exe --enable-logging=stderr --vmodule="*/bat-native-ledger/*"=9,"*/brave_rewards/*"=9,"*/bat-native-ads/*"=9,"*/bat-native-confirmations/*"=9,"*/brave_ads/*"=9,"*/brave_user_model/*"=9 --rewards=staging=true,rewards=debug=true
  2. Enable rewards and restart the browser
  3. Visit all the publishers one by one
  4. Open https://twitter.com/brave
  5. Confirm that Inline tip is NOT shown
  6. Visit Remove inline Tip buttons #33783
  7. Confirm that Inline tip is NOT shown
  8. Open https://www.reddit.com/user/beachbum0407/
  9. Confirm that Inline tip is NOT shown
  10. Visit brave://settings/rewards
  11. Confirmed that Inline tip icon settings are removed from brave://settings/rewards
  12. Connect a custodian
  13. Open brave://rewards settings page
  14. Confirm that Inline tip icon settings are removed from Contributions via brave://rewards page
step 5 step 7 step 9 step 10 step 14
image image image image image
Rewards not enabled_PASSED
  1. Clean profile launch brave using brave.exe --enable-logging=stderr --vmodule="*/bat-native-ledger/*"=9,"*/brave_rewards/*"=9,"*/bat-native-ads/*"=9,"*/bat-native-confirmations/*"=9,"*/brave_ads/*"=9,"*/brave_user_model/*"=9 --rewards=staging=true,rewards=debug=true
  2. Don't enable rewards
  3. Visit all the publishers one by one
  4. Open https://twitter.com/brave
  5. Confirm that Inline tip is NOT shown
  6. Visit Remove inline Tip buttons #33783
  7. Confirm that Inline tip is NOT shown
  8. Open https://www.reddit.com/user/beachbum0407/
  9. Confirm that Inline tip is NOT shown
  10. Visit brave://settings/rewards
  11. Confirmed that Inline tip icon settings are removed from brave://settings/rewards
step 5 step 7 step 9 step 10
image image image image

Upgrade profile

Enable rewards_PASSED
  1. Clean profile 1.60.103, launch brave using brave.exe --enable-logging=stderr --vmodule="*/bat-native-ledger/*"=9,"*/brave_rewards/*"=9,"*/bat-native-ads/*"=9,"*/bat-native-confirmations/*"=9,"*/brave_ads/*"=9,"*/brave_user_model/*"=9 --rewards=staging=true,rewards=debug=true
  2. Enable rewards and restart the browser
  3. Visit all the publishers one by one
  4. Open https://twitter.com/brave
  5. Confirm that Inline tip is NOT shown
  6. Visit Remove inline Tip buttons #33783
  7. Confirm that Inline tip is NOT shown
  8. Open https://www.reddit.com/user/beachbum0407/
  9. Confirm that Inline tip is NOT shown
  10. Visit brave://settings/rewards
  11. Confirmed that Inline tip icon settings are shown under brave://settings/rewards

1.60.103

step 5 step 7 step 9 step 10
image image image image
  1. Upgrade the profile to 1.62.x
  2. Verify the publisher pages and brave://settings/rewards page
  3. Confirm that Inline tip is NOT shown for any of the pubs
  4. Confirmed that Inline tip icon settings are removed from brave://settings/rewards

1.62.105

step 5 step 7 step 9 step 10
image image image image
Rewards not enabled_PASSED
  1. Clean profile 1.60.103, launch brave using brave.exe --enable-logging=stderr --vmodule="*/bat-native-ledger/*"=9,"*/brave_rewards/*"=9,"*/bat-native-ads/*"=9,"*/bat-native-confirmations/*"=9,"*/brave_ads/*"=9,"*/brave_user_model/*"=9 --rewards=staging=true,rewards=debug=true
  2. Don't enable rewards
  3. Visit all the publishers one by one
  4. Open https://twitter.com/brave
  5. Confirm that Inline tip is NOT shown
  6. Visit Remove inline Tip buttons #33783
  7. Confirm that Inline tip is NOT shown
  8. Open https://www.reddit.com/user/beachbum0407/
  9. Confirm that Inline tip is NOT shown
  10. Visit brave://settings/rewards
  11. Confirmed that Inline tip icon settings are shown under brave://settings/rewards

1.60.103

step 5 step 7 step 9 step 10
image image image image
  1. Upgrade the profile to 1.62.x
  2. Verify the publisher pages and brave://settings/rewards page
  3. Confirm that Inline tip is NOT shown for any of the pubs
  4. Confirmed that Inline tip icon settings are removed from brave://settings/rewards

1.62.105

step 5 step 7 step 9 step 10
image image image image

@LaurenWags LaurenWags added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Dec 14, 2023
@LaurenWags
Copy link
Member

LaurenWags commented Dec 14, 2023 •
edited
Loading

Verified with

Brave | 1.62.107 Chromium: 120.0.6099.115 (Official Build) beta (x86_64)
-- | --
Revision | 67a3b21572338a0660bb25a5855da0f1e9372a39
OS | macOS Version 13.6.1 (Build 22G313)

Clean profile

Rewards Enabled - PASSED
  1. Clean profile launch brave using --args --enable-logging=stderr --vmodule="*/bat-native-ledger/*"=9,"*/brave_rewards/*"=9,"*/bat-native-ads/*"=9,"*/bat-native-confirmations/*"=9,"*/brave_ads/*"=9,"*/brave_user_model/*"=9 --rewards=debug=true,staging=true
  2. Enable rewards and restart the browser
  3. Visit all the publishers one by one
  4. Open https://twitter.com/brave
  5. Confirm that Inline tip is NOT shown
  6. Visit Remove inline Tip buttons #33783
  7. Confirm that Inline tip is NOT shown
  8. Open https://www.reddit.com and old.reddit.com
  9. Confirm that Inline tip is NOT shown
  10. Visit brave://settings/rewards
  11. Confirmed that Inline tip icon settings are removed from brave://settings/rewards
  12. Connect a custodian
  13. Open brave://rewards settings page
  14. Confirm that Inline tip icon settings are removed from Contributions via brave://rewards page
step 5 step 7 step 9 step 9 step 11 step 14
5 7 9a 9b 11 14
Rewards not enabled - PASSED
  1. Clean profile launch brave using --args --enable-logging=stderr --vmodule="*/bat-native-ledger/*"=9,"*/brave_rewards/*"=9,"*/bat-native-ads/*"=9,"*/bat-native-confirmations/*"=9,"*/brave_ads/*"=9,"*/brave_user_model/*"=9 --rewards=debug=true,staging=true
  2. Don't enable rewards
  3. Visit all the publishers one by one
  4. Open https://twitter.com/brave
  5. Confirm that Inline tip is NOT shown
  6. Visit Remove inline Tip buttons #33783
  7. Confirm that Inline tip is NOT shown
  8. Open https://www.reddit.com and old.reddit.com
  9. Confirm that Inline tip is NOT shown
  10. Visit brave://settings/rewards
  11. Confirmed that Inline tip icon settings are removed from brave://settings/rewards
step 5 step 7 step 9 step 9 step 11
5 7 9a 9b 11

Upgrade profile

Rewards enabled - PASSED
  1. Clean profile 1.61.x, launch brave using --args --enable-logging=stderr --vmodule="*/bat-native-ledger/*"=9,"*/brave_rewards/*"=9,"*/bat-native-ads/*"=9,"*/bat-native-confirmations/*"=9,"*/brave_ads/*"=9,"*/brave_user_model/*"=9 --rewards=debug=true,staging=true
  2. Enable rewards and connect a custodian and restart the browser
  3. Visit all the publishers one by one
  4. Open https://twitter.com/brave
  5. Confirm that Inline tip is NOT shown
  6. Visit Remove inline Tip buttons #33783
  7. Confirm that Inline tip is NOT shown
  8. Open https://www.reddit.com/ and old.reddit.com
  9. Confirm that Inline tip is NOT shown
  10. Visit brave://settings/rewards
  11. Confirmed that Inline tip icon settings are shown under brave://settings/rewards
  12. Visit brave://rewards
  13. Confirm tip settings icon is shown under the Contributions panel
  14. Confirm tip settings can be opened from the Contributions panel

1.61.x

step 5 step 7 step 9 step 9 step 11 step 13 step 14
5 7 9a 9b 11 13 14
  1. Upgrade the profile to 1.62.x (rename profile and launch with Beta)
  2. Verify the each of the publisher pages and brave://settings/rewards page
  3. Confirm that Inline tip is NOT shown for any of the pubs
  4. Confirmed that Inline tip icon settings are removed from brave://settings/rewards
  5. Visit brave://rewards
  6. Confirm tip icon settings are not accessible from Contributions panel any more

1.62.x

step 17 step 17 step 17 step 17 step 18 step 20
a b c d 18 20
Rewards not enabled - PASSED
  1. Clean profile 1.61.x, launch brave using --args --enable-logging=stderr --vmodule="*/bat-native-ledger/*"=9,"*/brave_rewards/*"=9,"*/bat-native-ads/*"=9,"*/bat-native-confirmations/*"=9,"*/brave_ads/*"=9,"*/brave_user_model/*"=9 --rewards=debug=true,staging=true
  2. Don't enable rewards
  3. Visit all the publishers one by one
  4. Open https://twitter.com/brave
  5. Confirm that Inline tip is NOT shown
  6. Visit Remove inline Tip buttons #33783
  7. Confirm that Inline tip is NOT shown
  8. Open https://www.reddit.com/ and old.reddit.com
  9. Confirm that Inline tip is NOT shown
  10. Visit brave://settings/rewards
  11. Confirmed that Inline tip icon settings are shown under brave://settings/rewards

1.61.x

step 5 step 7 step 9 step 9 step 11
5 7 9a 9b 11
  1. Upgrade the profile to 1.62.x (rename profile and launch with Beta)
  2. Verify the publisher pages and brave://settings/rewards page
  3. Confirm that Inline tip is NOT shown for any of the pubs
  4. Confirmed that Inline tip icon settings are removed from brave://settings/rewards

1.62.x

step 13 step 13 step 13 step 13 step 15
a b c d e

@LaurenWags LaurenWags added QA Pass-macOS QA/In-Progress Indicates that QA is currently in progress for that particular issue and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Dec 15, 2023
@LaurenWags
Copy link
Member

LaurenWags commented Dec 18, 2023 •
edited
Loading

Verified with

Brave	1.62.112 Chromium: 120.0.6099.115 (Official Build) beta (64-bit) 
Revision	ae1e179b9884b2de2f4ba0bdea7da3beaad93ffa
OS	Linux
Clean Profile - Rewards not enabled - PASSED
  1. Clean profile launch brave using --args --enable-logging=stderr --vmodule="*/bat-native-ledger/*"=9,"*/brave_rewards/*"=9,"*/bat-native-ads/*"=9,"*/bat-native-confirmations/*"=9,"*/brave_ads/*"=9,"*/brave_user_model/*"=9 --rewards=debug=true,staging=true
  2. Don't enable rewards
  3. Visit all the publishers one by one
  4. Open https://twitter.com/brave
  5. Confirm that Inline tip is NOT shown
  6. Visit Remove inline Tip buttons #33783
  7. Confirm that Inline tip is NOT shown
  8. Open https://www.reddit.com and old.reddit.com
  9. Confirm that Inline tip is NOT shown
  10. Visit brave://settings/rewards
  11. Confirmed that Inline tip icon settings are removed from brave://settings/rewards
step 5 step 7 step 9 step 9 step 11
4 7 9a 9b 11
Upgrade profile - Rewards enabled - PASSED
  1. Clean profile 1.61.x, launch brave using --args --enable-logging=stderr --vmodule="*/bat-native-ledger/*"=9,"*/brave_rewards/*"=9,"*/bat-native-ads/*"=9,"*/bat-native-confirmations/*"=9,"*/brave_ads/*"=9,"*/brave_user_model/*"=9 --rewards=debug=true,staging=true
  2. Enable rewards and connect a custodian and restart the browser
  3. Visit all the publishers one by one
  4. Open https://twitter.com/brave
  5. Confirm that Inline tip is NOT shown
  6. Visit Remove inline Tip buttons #33783
  7. Confirm that Inline tip is NOT shown
  8. Open https://www.reddit.com/ and old.reddit.com
  9. Confirm that Inline tip is NOT shown
  10. Visit brave://settings/rewards
  11. Confirmed that Inline tip icon settings are shown under brave://settings/rewards
  12. Visit brave://rewards
  13. Confirm tip settings icon is shown under the Contributions panel
  14. Confirm tip settings can be opened from the Contributions panel

1.61.x

step 5 step 7 step 9 step 9 step 11 step 13 step 14
5 7 9a 9b 11 13 14
  1. Upgrade the profile to 1.62.x (rename profile and launch with Beta)
  2. Verify the each of the publisher pages and brave://settings/rewards page
  3. Confirm that Inline tip is NOT shown for any of the pubs
  4. Confirmed that Inline tip icon settings are removed from brave://settings/rewards
  5. Visit brave://rewards
  6. Confirm tip icon settings are not accessible from Contributions panel any more

1.62.x

step 17 step 17 step 17 step 17 step 18 step 20
a b c d e f

@LaurenWags LaurenWags added QA Pass-Linux and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Dec 18, 2023
@LaurenWags LaurenWags mentioned this issue Jan 24, 2024
Closed
@rebron rebron mentioned this issue Feb 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emerick emerick

Labels
feature/rewards greaselion OS/Desktop perf priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/include
Projects
Brave Rewards
Status: Done
Milestone
1.62.x - Release
Development

Successfully merging a pull request may close this issue.

Remove support for inline tip buttons brave/brave-core
4 participants
@emerick @Miyayes @LaurenWags @GeetaSarvadnya