Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C87 regression - button shape #12418

Closed
LaurenWags opened this issue Oct 30, 2020 · 3 comments · Fixed by brave/brave-core#6997
Closed

C87 regression - button shape #12418

LaurenWags opened this issue Oct 30, 2020 · 3 comments · Fixed by brave/brave-core#6997

Comments

@LaurenWags
Copy link
Member

Description

In some places the button shape is not correct. See below for 2 examples of where buttons on a bubble are not the same shape as they were on 1.16.x/C86

Steps to Reproduce

  1. Clean profile 1.18.x w/ C87
  2. Navigate to reddit.com --> look at bubble asking to Show Notifications
  3. Navigate to 3zsistemi.si --> look at bubble offering Google Translate installation

Actual result:

Buttons are rectangular
Screen Shot 2020-10-30 at 7 26 38 AM
Screen Shot 2020-10-30 at 7 26 54 AM

Expected result:

Buttons to be pill shaped
Screen Shot 2020-10-30 at 7 29 17 AM
Screen Shot 2020-10-30 at 7 29 29 AM

Reproduces how often:

Brave version (brave://version info)

Brave 1.18.18 Chromium: 87.0.4280.27 (Official Build) nightly (x86_64)
Revision d8c1fe98de8d9c6bd46ebe8b0cc9d2b6bdccca1e-refs/branch-heads/4280@{#556}
OS macOS Version 10.14.6 (Build 18G6032)

Version/Channel Information:

  • Can you reproduce this issue with the current release? no 1.16.x
  • Can you reproduce this issue with the beta channel? no 1.17.x
  • Can you reproduce this issue with the nightly channel? yes 1.18.x

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @mkarolin @rebron

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Oct 30, 2020

button shape is not as per the brave brand. Pages which doesn't have the brave branded shapes are listed below:

Edit bookmarks buttons:
image
image

Cookies in Use:
image
image

@bbondy
Copy link
Member

bbondy commented Oct 30, 2020

Please do not assign milestones until issues are closed. If this is release blocking though it can stay but add a release/blocking label.
Screen Shot 2020-10-30 at 1 22 17 PM
https://github.com/brave/brave-browser/wiki/Triage-Guidelines#milestones-and-issues

@bbondy bbondy removed this from the 1.18.x - Nightly milestone Oct 30, 2020
@simonhong simonhong added this to the 1.18.x - Nightly milestone Oct 30, 2020
@LaurenWags
Copy link
Member Author

LaurenWags commented Nov 9, 2020

Verified passed with

Brave | 1.17.63 Chromium: 87.0.4280.49 (Official Build) unknown (x86_64)
-- | --
Revision | f77f85899646b42a1d3c8ff36794e00becab9171-refs/branch-heads/4280@{#1115}
OS | macOS Version 10.14.6 (Build 18G6032)

Verified expected button shape on screens mentioned in #12418 (comment)

Screenshots Screen Shot 2020-11-09 at 5 45 05 AM Screen Shot 2020-11-09 at 5 45 24 AM

Verified expected button shape on screens mentioned in #12418 (comment)

Screenshots Screen Shot 2020-11-09 at 5 45 48 AM Screen Shot 2020-11-09 at 5 46 03 AM Screen Shot 2020-11-09 at 5 46 19 AM

Verified passed with

Brave 1.17.63 Chromium: 87.0.4280.49 (Official Build) dev (64-bit)
Revision f77f85899646b42a1d3c8ff36794e00becab9171-refs/branch-heads/4280@{#1115}
OS Windows 7 Service Pack 1 (Build 7601.24544)

Verified STR from description

Verified expected button shape on screens mentioned in #12418 (comment)

Screenshots

image
image

Verified expected button shape on screens mentioned in #12418 (comment)

Screenshots

image
image
image


Verification passed on

Brave 1.17.63 Chromium: 87.0.4280.49 (Official Build) dev (64-bit)
Revision f77f85899646b42a1d3c8ff36794e00becab9171-refs/branch-heads/4280@{#1115}
OS Ubuntu 18.04 LTS

Verified STR from description

Verified expected button shape on screens mentioned in #12418 (comment)

Screenshots

image
image

Verified expected button shape on screens mentioned in #12418 (comment)

Screenshots

image
image
image

@rebron rebron changed the title [Desktop] C87 regression - button shape C87 regression - button shape Nov 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment