Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Google support page opened when clicking on help icon in settings #12481

Closed
srirambv opened this issue Nov 3, 2020 · 1 comment · Fixed by brave/brave-core#7052
Closed

Google support page opened when clicking on help icon in settings #12481

srirambv opened this issue Nov 3, 2020 · 1 comment · Fixed by brave/brave-core#7052
Assignees
@samartnik
Labels
branding bug OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA Pass - Android Tab QA/Yes regression release-notes/exclude
Milestone
1.17.x - Release #1

Comments

@srirambv
Copy link
Contributor

srirambv commented Nov 3, 2020

Description

Google support page opened when clicking on help icon in settings

Steps to reproduce

  1. Install 1.18.27 x64 nightly build
  2. Open settings and click on ❔
  3. Opens Google support page

Actual result

Google support page opened when clicking on help icon in settings

Expected result

Should open Brave support page

Issue reproduces how often

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? No
  • Can you reproduce this issue with the current Play Store Beta version? No
  • Can you reproduce this issue with the current Play Store Nightly version? Yes

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): Phone
  • Android version: 10

Brave version

1.18.27 Nightly build

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Additional information
@srirambv srirambv added bug QA/Yes regression branding OS/Android Fixes related to Android browser functionality labels Nov 3, 2020
@samartnik samartnik self-assigned this Nov 4, 2020
This was referenced Nov 4, 2020
Merged
Merged
@samartnik samartnik added this to the 1.18.x - Nightly milestone Nov 4, 2020
@srirambv
Copy link
Contributor Author

Verification passed on Samsung Tab A with Android 10 running 1.17.66 x64 beta build

  • Verified no Google support page is opened from settings

Verification passed on OnePlus 6T with Android 10 running 1.17.66 x64 beta build

  • Verified no Google support page is opened from settings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samartnik samartnik

Labels
branding bug OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA Pass - Android Tab QA/Yes regression release-notes/exclude
Projects
None yet
Milestone
1.17.x - Release #1
Development

Successfully merging a pull request may close this issue.

[Android] Fixed feedback url in settings brave/brave-core
3 participants
@kjozwiak @srirambv @samartnik