Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Fixed feedback url in settings #7052

Merged
merged 1 commit into from
Nov 4, 2020
Merged

Conversation

samartnik
Copy link
Contributor

@samartnik samartnik commented Nov 4, 2020

Resolves brave/brave-browser#12481

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@samartnik samartnik added CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels Nov 4, 2020
@samartnik samartnik added this to the 1.18.x - Nightly milestone Nov 4, 2020
@samartnik samartnik self-assigned this Nov 4, 2020
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@SergeyZhukovsky SergeyZhukovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@samartnik samartnik merged commit 4f4ff53 into master Nov 4, 2020
@samartnik samartnik deleted the android_feedback_url_fix branch November 4, 2020 17:37
mkarolin pushed a commit that referenced this pull request Nov 7, 2020
[Android] Fixed feedback url in settings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Google support page opened when clicking on help icon in settings
3 participants