Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crash when clicking on BAT panel after skipping onboarding #12509

Closed
kjozwiak opened this issue Nov 4, 2020 · 2 comments
Closed

crash when clicking on BAT panel after skipping onboarding #12509

kjozwiak opened this issue Nov 4, 2020 · 2 comments
Assignees
@SergeyZhukovsky
Labels
ARM Android ARM related issues crash feature/rewards OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA Pass - Android Tab QA/Yes release/blocking release-notes/include
Milestone
1.16.x - Release #4

Comments

@kjozwiak
Copy link
Member

kjozwiak commented Nov 4, 2020 •
edited
Loading

Description

Brave will crash every time the BAT panel icon is tapped when onboarding has been skipped.

Steps to reproduce

  1. launch either 1.16.73 CR 86.0.4240.185 or 1.16.70 CR: 86.0.4240.111
  2. skip/don't enable Privacy Reporting
  3. tap on BAT icon and skip the Rewards onboarding
  4. tap on the BAT icon and Brave will crash (this happens every time)

Actual result

Example of Brave crashing --> https://youtu.be/_yquqm4BiTw

Expected result

Brave shouldn't be crashing.

Issue reproduces how often

100% reproducible using the above STR.

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? Yes
  • Can you reproduce this issue with the current Play Store Beta version? No
  • Can you reproduce this issue with the current Play Store Nightly version? No

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): Samsung S10+ (Phone)
  • Android version: Android 10

Brave version

  • 1.16.70 CR: 86.0.4240.111 - Reproduced
  • 1.16.73 CR 86.0.4240.185 - Reproduced

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Does the issue resolve itself when disabling Brave Rewards? No, if you enable/disable, still crashes
  • Is the issue reproducible on the latest version of Chrome? N/A

Additional information

CCing @bsclifton @SergeyZhukovsky @aekeus @srirambv
@kjozwiak kjozwiak added this to the 1.16.x - Release #4 milestone Nov 4, 2020
@SergeyZhukovsky SergeyZhukovsky self-assigned this Nov 4, 2020
@SergeyZhukovsky SergeyZhukovsky mentioned this issue Nov 4, 2020
Merged
33 tasks
@NejcZdovc
Copy link
Contributor

fixed by brave/brave-core#7051

@LaurenWags LaurenWags added the ARM Android ARM related issues label Nov 4, 2020
@btlechowski
Copy link

btlechowski commented Nov 4, 2020 •
edited by kjozwiak
Loading

Verification passed on Brave v1.16.74 on Samsung Galaxy Tab S5e (Android 9.0)

Reproduced the crash on 1.16.70
Verified no crash on v1.16.74. Verified 7 times.

Verification PASSED on Samsung S10+ on Android 10 using 1.16.74 CR: 86.0.4240.185

This was referenced Nov 4, 2020
Closed
Closed
@kjozwiak kjozwiak mentioned this issue Nov 4, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SergeyZhukovsky SergeyZhukovsky

Labels
ARM Android ARM related issues crash feature/rewards OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA Pass - Android Tab QA/Yes release/blocking release-notes/include
Projects
None yet
Milestone
1.16.x - Release #4
Development

No branches or pull requests
5 participants
@kjozwiak @NejcZdovc @SergeyZhukovsky @LaurenWags @btlechowski