Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Desktop] Tip button on Reddit is missing hover color and text #12537

Closed
LaurenWags opened this issue Nov 5, 2020 · 0 comments
Closed

[Desktop] Tip button on Reddit is missing hover color and text #12537

LaurenWags opened this issue Nov 5, 2020 · 0 comments

Comments

@LaurenWags
Copy link
Member

Description

When you hover over the in-line tip button on Reddit, the text "Tip" does not change color to orange and there is no hover text. Was expecting it to behave similar to GitHub in-line tip button.

Steps to Reproduce

  1. Have Rewards enabled
  2. Navigate to a Reddit page (ex. reddit.com/r/brave_browser or reddit.com/user/alex_the_brave)
  3. Look for Tip button (note, if you don't see any text saying "Tip", you've encountered [Desktop] race condition with Greaselion and localizations #12264 and need to restart your browser)
  4. Hover over Tip button/text

Actual result:

reddit.com/r/brave_browser:
Reddit 1

reddit.com/user/alex_the_brave:
Reddit 2

Expected result:

Similar to GitHub:
GH issue and PR example

Reproduces how often:

Brave version (brave://version info)

Brave 1.17.62 Chromium: 86.0.4240.185 (Official Build) dev (x86_64)
Revision 37e6f852ed18086458552039ad26421aa9fc7acc-refs/branch-heads/4240@{#1377}
OS macOS Version 10.14.6 (Build 18G6032)

Version/Channel Information:

  • Can you reproduce this issue with the current release? somewhat. on 1.16.x the first example above text changes to orange when hovered, but the second does not. Neither has hover text on 1.16.x
  • Can you reproduce this issue with the beta channel? yes, 1.17.x
  • Can you reproduce this issue with the nightly channel? yes 1.18.x

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Does the issue resolve itself when disabling Brave Rewards? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Miscellaneous Information:

cc @NejcZdovc @emerick

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants