Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send a tip tooltip is not shown for Reddit and Twitter publishers #25558

Closed
GeetaSarvadnya opened this issue Sep 22, 2022 · 3 comments
Closed
Assignees
Labels
bug closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. feature/rewards greaselion OS/Desktop polish Nice to have — usually related to front-end/visual tasks priority/P4 Planned work. We expect to get to it "soon". QA/No

Comments

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Sep 22, 2022

Description

Send a tip tooltip is not shown for Reddit and Twitter publishers

Actual result:

Reddit
image

Twitter
image

Expected result:

discussed with @mkarolin
As per the code the Send a tip tooltip should be shown for Twitter and reddit
image

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.44.95 Chromium: 106.0.5249.40 (Official Build) (64-bit)
Revision fab1d91915d2722d6339aaa7f4e9ce44f1e9b103-refs/branch-heads/5249@{#442}
OS Windows 10 Version 21H2 (Build 19044.2006)

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @brave/qa-team @Miyayes

@LaurenWags
Copy link
Member

LaurenWags commented Oct 3, 2022

This is a duplicate of:

However, I know @Miyayes likes new issues (not old ones 😉 ) so cc'ing him to determine which to keep open and which to close.

@Miyayes Miyayes self-assigned this Nov 9, 2022
@Miyayes
Copy link
Collaborator

Miyayes commented Nov 9, 2022

@Miyayes Go back and check old issues and make sure they're up to date.

@Miyayes Miyayes added polish Nice to have — usually related to front-end/visual tasks priority/P4 Planned work. We expect to get to it "soon". greaselion labels Nov 30, 2022
@Miyayes Miyayes assigned mkarolin and unassigned Miyayes Nov 30, 2022
@mkarolin
Copy link
Contributor

Closing as we no longer use tooltips with the inline tipping buttons (#28699).

@mkarolin mkarolin added QA/No closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. and removed QA/Yes QA/Test-Plan-Specified labels Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. feature/rewards greaselion OS/Desktop polish Nice to have — usually related to front-end/visual tasks priority/P4 Planned work. We expect to get to it "soon". QA/No
Projects
None yet
Development

No branches or pull requests

4 participants