Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layer violation for includes at brave_sync_profile_sync_service.cc #12614

Closed
AlexeyBarabash opened this issue Nov 10, 2020 · 0 comments · Fixed by brave/brave-core#7107
Closed
Assignees
Labels
build OS/Android Fixes related to Android browser functionality OS/Desktop QA/No release-notes/exclude

Comments

@AlexeyBarabash
Copy link
Contributor

Bad effect of brave/brave-core#6732

@bridiver reported the error

In file included from ../../brave/components/sync/driver/brave_sync_profile_sync_service.cc:15:
In file included from ../../brave/chromium_src/chrome/browser/profiles/profile_manager.h:20:
In file included from ../../brave/chromium_src/chrome/browser/profiles/../../../../../chrome/browser/profiles/profile_manager.h:23:
In file included from ../../chrome/browser/profiles/profile.h:20:
In file included from ../../brave/chromium_src/content/public/browser/browser_context.h:9:
../../brave/chromium_src/content/public/browser/../../../../../content/public/browser/browser_context.h:24:10: fatal error: 'services/content/public/mojom/navigable_contents_factory.mojom-forward.h' file not found
#include "services/content/public/mojom/navigable_contents_factory.mojom-forward.h"
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.

Violation is fixed by brave/brave-core#7001 , but includes are forgotten. Removing of these includes helps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build OS/Android Fixes related to Android browser functionality OS/Desktop QA/No release-notes/exclude
Projects
None yet
1 participant