-
Notifications
You must be signed in to change notification settings - Fork 868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync remove other device #6732
Merged
Merged
Sync remove other device #6732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexeyBarabash
force-pushed
the
sync_remove_other_device
branch
4 times, most recently
from
October 9, 2020 16:05
204a9e8
to
a28707c
Compare
AlexeyBarabash
force-pushed
the
sync_remove_other_device
branch
from
October 13, 2020 19:24
7cf3d47
to
a4a74e4
Compare
AlexeyBarabash
force-pushed
the
sync_remove_other_device
branch
2 times, most recently
from
October 21, 2020 20:19
f76c170
to
bc797e6
Compare
AlexeyBarabash
requested review from
darkdh,
petemill,
SergeyZhukovsky,
bradleyrichter,
bridiver and
jamesmudgett
October 21, 2020 20:29
mkarolin
approved these changes
Oct 21, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
chromium_src
change LGTM
darkdh
requested changes
Oct 21, 2020
AlexeyBarabash
force-pushed
the
sync_remove_other_device
branch
from
October 22, 2020 14:40
9e121d0
to
b4d362f
Compare
AlexeyBarabash
force-pushed
the
sync_remove_other_device
branch
from
October 22, 2020 21:38
b4d362f
to
fe77992
Compare
darkdh
reviewed
Oct 22, 2020
darkdh
reviewed
Oct 26, 2020
…from other devices
Allow delete other device only if remote device support that (Android)
…d test This modification of DeviceInfoSyncBridgeTest.ApplySyncChangesWithLocalGuid covers the case when DeviceInfoSyncBridge should process delete device record.
AlexeyBarabash
force-pushed
the
sync_remove_other_device
branch
from
October 29, 2020 10:10
c58940a
to
9b67d15
Compare
Rebased to the latest C87 master, fixed conflicts 9b67d15 . |
All CI is green |
32 tasks
This was referenced Oct 30, 2020
24 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#11232
Fixed brave/brave-browser#12490 for text change
Submitter Checklist:
npm run lint
,npm run gn_check
)git rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
I. Sync UI is changed on Android
II. detection of device which does not support self-delete
III. All devices support self-delete
Reviewer Checklist:
After-merge Checklist:
changes has landed on.