Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of BRAVE_CHROMIUM_BUILD everywhere #12740

Closed
iefremov opened this issue Nov 17, 2020 · 1 comment · Fixed by brave/brave-core#7969
Closed

Get rid of BRAVE_CHROMIUM_BUILD everywhere #12740

iefremov opened this issue Nov 17, 2020 · 1 comment · Fixed by brave/brave-core#7969
Assignees
@mariospr
Labels
dev-concern OS/Android Fixes related to Android browser functionality OS/Desktop QA/No release-notes/exclude
Milestone
1.22.x - Release

Comments

@iefremov
Copy link
Contributor

For now we inconsistently use BRAVE_CHROMIUM_BUILD in patches. The initial idea was to use it to change the program flow in compile time (i.e. using #ifdef BRAVE_CHROMIUM BUILD ... #else ... #endif), but mostly this macro is misused. We'd better to erase it from the codebase (and wiki), and use #if 0 instead to replace unwanted code with ours.
@iefremov iefremov added dev-concern OS/Android Fixes related to Android browser functionality OS/Desktop labels Nov 17, 2020
@iefremov
Copy link
Contributor Author

also there is a couple of files in chromium_src containing this

mariospr added a commit to brave/brave-core that referenced this issue Feb 16, 2021
@mariospr
Remove usage of BRAVE_CHROMIUM_BUILD and brave_chromium_build
0c6823c 
It will assumed from now on that all of Brave's own code plus patches
to upstream Chromium will always be built and run as part of a Brave
build, so we can drop these guards and reduce the patching surface.

Note that github.com/brave/brave-browser/wiki/Patching-Chromium should
also be updated to reflect the change implemented in this patch.

Fix brave/brave-browser#12740
@mariospr mariospr added this to the 1.22.x - Nightly milestone Feb 16, 2021
This was referenced Feb 16, 2021
Merged
Closed
mariospr added a commit to brave/brave-core that referenced this issue Feb 18, 2021
@mariospr
Remove usage of BRAVE_CHROMIUM_BUILD and brave_chromium_build
704fa8b 
It will assumed from now on that all of Brave's own code plus patches
to upstream Chromium will always be built and run as part of a Brave
build, so we can drop these guards and reduce the patching surface.

Note that github.com/brave/brave-browser/wiki/Patching-Chromium should
also be updated to reflect the change implemented in this patch.

Fix brave/brave-browser#12740
mariospr added a commit to brave/brave-core that referenced this issue Feb 22, 2021
@mariospr
Remove usage of BRAVE_CHROMIUM_BUILD and brave_chromium_build
b39991f 
It will assumed from now on that all of Brave's own code plus patches
to upstream Chromium will always be built and run as part of a Brave
build, so we can drop these guards and reduce the patching surface.

Note that github.com/brave/brave-browser/wiki/Patching-Chromium should
also be updated to reflect the change implemented in this patch.

Fix brave/brave-browser#12740
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mariospr mariospr

Labels
dev-concern OS/Android Fixes related to Android browser functionality OS/Desktop QA/No release-notes/exclude
Projects
None yet
Milestone
1.22.x - Release
Development

Successfully merging a pull request may close this issue.

Remove usage of BRAVE_CHROMIUM_BUILD and brave_chromium_build brave/brave-core
2 participants
@mariospr @iefremov