Brave ads appear underneath MacOS dock/menu bar and Windows taskbar

[stshank]

Description

Ads appear underneath the dock on MacOS Catalina and Big Sur when the dock is positioned on the right edge of the screen.
Brave ads appear to low if the menubar is hidden.

Ads appear underneath the taskbar on Windows when the taskbar is positioned on the right edge of the screen.

Steps to Reproduce

1. Move dock to right edge of screen
2. Wait for ad to appear

Actual result:

Ad appears underneath the dock icons.

Expected result:

Ad should appear on top of dock (or maybe flush with right edge of browser window?)

Reproduces how often:

Always

Brave version (brave://version info)

Brave	1.19.48 Chromium: 87.0.4280.88 (Official Build) dev (x86_64)
Revision	89e2380a3e36c3464b5dd1302349b1382549290d-refs/branch-heads/4280@{#1761}
OS	macOS Version 11.0.1 (Build 20B29)
JavaScript	V8 8.7.220.29
Flash	(Disabled)
User Agent	Mozilla/5.0 (Macintosh; Intel Mac OS X 11_0_1) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/87.0.4280.88 Safari/537.36
Command Line	/Applications/Brave Browser Dev.app/Contents/MacOS/Brave Browser Dev --enable-dom-distiller --disable-domain-reliability --no-pings --extension-content-verification=enforce_strict --extensions-install-verification=enforce --origin-trial-public-key=bYUKPJoPnCxeNvu72j4EmPuK7tr1PAC7SHh8ld9Mw3E=,fMS4mpO6buLQ/QMd+zJmxzty/VQ6B1EUZqoCU04zoRU= --sync-url=https://sync-v2.brave.com/v2 --lso-url=https://no-thanks.invalid --variations-server-url=https://variations.brave.com/seed --enable-features=AutoupgradeMixedContent,LegacyTLSEnforced,WebUIDarkMode,ReducedReferrerGranularity,PasswordImport,PrefetchPrivacyChanges --disable-features=PrivacySettingsRedesign,AutofillServerCommunication,AutofillEnableAccountWalletStorage,TextFragmentAnchor,SmsReceiver,NotificationTriggers,PasswordCheck,NetworkTimeServiceQuerying,TabHoverCards,SignedExchangeSubresourcePrefetch,SafeBrowsingEnhancedProtection,AllowPopupsDuringPageUnload,VideoPlaybackQuality,IdleDetection --flag-switches-begin --flag-switches-end
--	--

[btlechowski]

Based on the test plan from brave/brave-core#7363, added QA/Test-All-Platforms

[stephendonner]

Hi @stshank! If you wouldn't mind, could you let us know 1) screen resolution settings (default/scaled, etc.) 2) # of items in your dock, when you saw this issue? And, anything else which might be pertinent in reproducing this issue? I've tried on Big Sur 11.2.3 with various builds, but so far haven't triggered your specific scenario, and I'd like to be able to do so before confidently verifying the fix; thanks!

[tmancey]

@stephendonner If you could send a calendar event, or let me know when online and I can demonstrate the issue. The issue was fixed in 1.23.33 and will only occur in nightly as custom ad notifications are glued to nightly builds at this time. Thanks, Terry

[stshank]

I haven't seen this issue since I initially reported it. Brave rolled back the approach for awhile, apparently. I can't recall if the new style of ads is back. (I use Brave stable more often these days.)

…

________________________________ From: Stephen Donner ***@***.***> Sent: Monday, March 22, 2021 12:03 PM To: brave/brave-browser ***@***.***> Cc: Stephen Shankland ***@***.***>; Mention ***@***.***> Subject: Re: [brave/brave-browser] Brave ads appear underneath MacOS dock/menu bar and Windows taskbar (#13065) External: Scrutinize Sender Hi @stshank<https://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fstshank&data=04%7C01%7Cstephen.shankland%40cnet.com%7Cbb41ecfd169b46e2593308d8ed652015%7C4289d6102cfd46218c9644a1518ddb0a%7C0%7C0%7C637520365875501257%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=%2BLKMkDjTgraB%2BRWPitazEkfkZSv%2By9oxLxpTU7dF4Kw%3D&reserved=0>! If you wouldn't mind, could you let us know 1) screen resolution settings (default/scaled, etc.) 2) # of items in your dock, when you saw this issue? And, anything else which might be pertinent in reproducing this issue? I've tried on Big Sur 11.2.3 with various builds, but so far haven't triggered your specific scenario, and I'd like to be able to do so before confidently verifying the fix; thanks! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<https://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fbrave%2Fbrave-browser%2Fissues%2F13065%23issuecomment-804317144&data=04%7C01%7Cstephen.shankland%40cnet.com%7Cbb41ecfd169b46e2593308d8ed652015%7C4289d6102cfd46218c9644a1518ddb0a%7C0%7C0%7C637520365875501257%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=AK65THinHuvUcT9bJbu%2F5f2YpS2BXC9Cr4iG0ZfsikU%3D&reserved=0>, or unsubscribe<https://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAEANVY36NRGDC6FRG2MWM73TE6H6TANCNFSM4UPZQ6FA&data=04%7C01%7Cstephen.shankland%40cnet.com%7Cbb41ecfd169b46e2593308d8ed652015%7C4289d6102cfd46218c9644a1518ddb0a%7C0%7C0%7C637520365875511252%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=XX8FRFvdcjPwVhsAlNqLYqpd1yZw1g1gHXM6QIMpdeI%3D&reserved=0>.

[stephendonner]

@tmancey @stshank thanks, both of you; easily reproduced this bug using nightly version 1.23.33 on macOS 11.2.3

[stephendonner]

Verified FIXED on macOS Big Sur (11.2.3) using beta build

Brave	1.23.53 Chromium: 89.0.4389.105 (Official Build) beta (x86_64)
Revision	14f44e21a9d539cd49c72468a29bfca4fa43f710-refs/branch-heads/4389_90@{#7}
OS	macOS Version 11.2.3 (Build 20D91)

Steps:

1. clean profile
2. launched Brave using --args --enable-logging=stderr --vmodule="*/bat-native-ledger/*"=6,"*/brave_rewards/*"=6,"*/bat-native-ads/*"=6,"*/bat-native-confirmations/*"=6,"*/brave_ads/*"=6,"*/brave_user_model/*"=6 --brave-ads-staging --rewards=staging=true
3. set Position on Screen for the dock to {Bottom (default), Left, and Right}
4. opened a few new-tab pages
5. clicked on Start using Rewards
6. waited a bit
7. confirmed I received a Brave ad notification:

• at the appropriate location and position for each corresponding dock placement
• ads were not clipped behind any of the docks

Bottom	Left	Right

---

Verification passed on

Brave | 1.23.56 Chromium: 89.0.4389.105 (Official Build) dev (64-bit)
-- | --
Revision | 14f44e21a9d539cd49c72468a29bfca4fa43f710-refs/branch-heads/4389_90@{#7}
OS | Windows 10 OS Version 2004 (Build 19041.867)

• Ensured that Ad notification isn't overlapped on the taskbar

Taskbar is set to Bottom

Taskbar is set to Top

Taskbar is set to Left

Taskbar is set to Right

---

Verification PASSED on Ubuntu 20.04 x64 using the following build:

Brave | 1.23.68 Chromium: 90.0.4430.51 (Official Build) (64-bit)
--- | ---
Revision | 32e5fa33a31641bded70a90e60121060691e7125-refs/branch-heads/4430@{#927}
OS | Linux

This doesn't really affect Linux as ad notifications are displayed in the middle at the top of the screen. You can only place the dock on either the right/left or bottom of the screen. Either way, switched the dock into the various positions and ensured that the ad notifications are appearing correctly under Linux.

Right Example	Left Example	Bottom Example