Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Follow up issue for P3A #13486

Closed
deeppandya opened this issue Jan 11, 2021 · 1 comment · Fixed by brave/brave-core#7565
Closed

Follow up issue for P3A #13486

deeppandya opened this issue Jan 11, 2021 · 1 comment · Fixed by brave/brave-core#7565
Assignees
@deeppandya
Labels
OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/exclude
Milestone
1.20.x - Release

Comments

@deeppandya
Copy link

Description

This is the follow up issue of #12723 to make p3a enabled by default.

Test plan

P3A should be enabled for new users and existing user if user dismisses the full screen modal.
@deeppandya deeppandya added QA/Yes release-notes/exclude OS/Android Fixes related to Android browser functionality labels Jan 11, 2021
@deeppandya deeppandya self-assigned this Jan 11, 2021
@deeppandya deeppandya mentioned this issue Jan 11, 2021
Merged
23 tasks
This was referenced Jan 12, 2021
Closed
Closed
@srirambv
Copy link
Contributor

srirambv commented Feb 8, 2021

Verification passed on OnePlus 6T with Android 10 running 1.20.100 x64 build

  • Verified on a clean install, P3A is enabled by default
  • Verified unchecking P3A and background the app disables the setting
  • Verified on an upgrade profile user is prompted for P3A right after install-launch
  • Verified P3A is enabled by default for upgrade profile as well

Verification passed on Samsung Tab A with Android 10 running 1.20.100 x64 build

  • Verified on a clean install, P3A is enabled by default
  • Verified unchecking P3A and background the app disables the setting
  • Verified on an upgrade profile user is prompted for P3A right after install-launch
  • Verified P3A is enabled by default for upgrade profile as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@deeppandya deeppandya

Labels
OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.20.x - Release
Development

Successfully merging a pull request may close this issue.

Set p3a enable brave/brave-core
2 participants
@deeppandya @srirambv