Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add p3a UI android (Uplift to 1.19.x) #7563

Closed
wants to merge 6 commits into from
Closed

add p3a UI android (Uplift to 1.19.x) #7563

wants to merge 6 commits into from

Conversation

deeppandya
Copy link
Contributor

@deeppandya deeppandya commented Jan 11, 2021 •
edited by srirambv
Loading

Uplift of #7550 #7565
Resolves brave/brave-browser#12723
Resolves brave/brave-browser#13486

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@deeppandya deeppandya added CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels Jan 11, 2021
@deeppandya deeppandya added this to the 1.19.x - Beta milestone Jan 11, 2021
@deeppandya deeppandya requested a review from a team January 11, 2021 20:20
@deeppandya deeppandya self-assigned this Jan 11, 2021
@kjozwiak
Copy link
Member

kjozwiak commented Jan 13, 2021 •
edited
Loading

After discussing with @brave/uplift-approvers, we decided to deny this uplift and have it ride the trains. We're too close to 1.19.x being released and @GeetaSarvadnya is finding several issues that needs clarification. We need more time to properly go through P3A and ensure that it's working as expected and collecting the required data.

Because #7565 isn't being uplifted, P3A won't be enabled in 1.19.x.

@kjozwiak kjozwiak closed this Jan 13, 2021
@kjozwiak kjozwiak removed the request for review from a team January 13, 2021 18:55
@kjozwiak kjozwiak removed this from the 1.19.x - Beta milestone Jan 13, 2021
@bsclifton bsclifton deleted the origin/add_p3a_ui_android_1.19.x branch January 25, 2021 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@deeppandya @kjozwiak