clicking on "Save Torrent File" attempts to download the file twice

[kjozwiak]

Description

Clicking on Save Torrent File under the webtorrent page when clicking/loading .torrent links attempts to download the .torrent file twice which triggers website is attempting to download multiple files notification. Clicking on Save Torrent File should only download the .torrent file once. This wasn't happening under muon.

Steps to Reproduce

1. install & run either beta or dev
2. in a new tab, load https://webtorrent.io/torrents/big-buck-bunny.torrent
3. click on Save Torrent File
4. you'll receive the [websites domain] wants to Download multiple files
5. click on Allow
6. click on Save Torrent File again and you'll notice Brave attempting to download two .torrent

If you click on Block, you'll only download a single file, however, we shouldn't be triggering the multiple downloads notification when someone decides they want to download the .torrent file.

Actual result:

Expected result:

Brave shouldn't trigger the [websites domain] wants to Download multiple files notification. Clicking on Save Torrent File should only save one .torrent file.

Reproduces how often:

100% reproducible using the above STR.

Brave version (chrome://version info)

Brave	0.55.10 Chromium: 70.0.3538.22 (Official Build) beta(64-bit)
Revision	ac9418ba9c3bd7f6baaffa0b055dfe147e0f8364-refs/branch-heads/3538@{#468}
OS	Mac OS X

Reproducible on current release:

• Does it reproduce on brave-browser dev/beta builds?

Not reproducible under 0.24.x which is the latest muon live release.

• Does it reproduce on browser-laptop?

Reproducible on both dev and beta

Brave	0.56.1 Chromium: 70.0.3538.22 (Official Build) dev (64-bit)
Revision	ac9418ba9c3bd7f6baaffa0b055dfe147e0f8364-refs/branch-heads/3538@{#468}
OS	Mac OS X

Additional Information

• Reproduced by @LaurenWags on macOS as well
• Reproduced by @srirambv on Win 10
• Reproduced by @btlechowski on Win 7

[yrliou]

I think it was an issue of Button component in brave-ui which was fixed by @petemill recently.
brave/brave-ui#197
I just tried with 0.55.16 and cannot reproduce it, @LaurenWags also got the same result as me on 0.55.16.
Please give it a try again with 0.55.16, and feel free to reopen it if it is still an issue, thanks.

[kjozwiak]

@yrliou yup, seems to be working! 🎉Used the following build:

Brave	0.55.16 Chromium: 70.0.3538.54 (Official Build) (64-bit)
Revision	4f8e578b6680574714e9ed3bb9f02922b4dde40d-refs/branch-heads/3538@{#937}

Platforms checked:

• macOS 10.13.6 x64 - PASSED
• Win 10 x64 - PASSED

Verification Passed on

Brave	0.55.16 Chromium: 70.0.3538.54 (Official Build) (64-bit)
Revision	4f8e578b6680574714e9ed3bb9f02922b4dde40d-refs/branch-heads/3538@{#937}
OS	Linux