Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow user to turn off web notifications globally in Setting #937

Closed
bsclifton opened this issue Sep 3, 2018 · 2 comments
Closed

Allow user to turn off web notifications globally in Setting #937

bsclifton opened this issue Sep 3, 2018 · 2 comments
Labels
feature/global-settings Settings at browser level independent of shields settings feature/notifications suggestion

Comments

@bsclifton
Copy link
Member

bsclifton commented Sep 3, 2018

Carried over from brave/browser-laptop#13624

This is for parity with other browsers:
http://www.thewindowsclub.com/disable-web-notifications-chrome-firefox-edge

@bsclifton bsclifton added suggestion feature/global-settings Settings at browser level independent of shields settings labels Sep 3, 2018
@bsclifton bsclifton added this to the 2.x Backlog milestone Sep 3, 2018
@bbondy bbondy modified the milestones: 2.x Backlog, 1.x Backlog Sep 30, 2018
@rebron rebron modified the milestone: 1.x Backlog Feb 7, 2019
@bsclifton bsclifton changed the title Allow user to turn web notifications globally in Setting Allow user to turn off web notifications globally in Setting Mar 6, 2019
@daviddahl
Copy link

Related to this, with no allowed origins in the notifications settings, I still receive notifications from some domains. I do not see an issue like that here. Is that a known issue? Otherwise I will file one. This global disable feature is needed.

@daviddahl
Copy link

Actually, Now that I understand the label in both chrome and brave, this seems as though it is implemented and this issue should be closed, no?

image

@bbondy bbondy added this to the Closed / Invalid milestone Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/global-settings Settings at browser level independent of shields settings feature/notifications suggestion
Projects
None yet
Development

No branches or pull requests

5 participants