Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maybe tone down "NOT A RECOMMENDED BRAVE EXTENSION!" #1408

Closed
MisinformedDNA opened this issue Oct 3, 2018 · 21 comments · Fixed by brave/brave-core#655
Closed

Maybe tone down "NOT A RECOMMENDED BRAVE EXTENSION!" #1408

MisinformedDNA opened this issue Oct 3, 2018 · 21 comments · Fixed by brave/brave-core#655

Comments

@MisinformedDNA
Copy link

Description

When I try to add the "Cisco Webex Extension" (and other extensions), I get a message screaming "NOT A RECOMMENDED BRAVE EXTENSION! Add "Cisco Webex Extension"? This makes me think that I'm doing something wrong/dangerous/damaging. Furthermore, I couldn't find anything about recommended extensions anywhere in the documentation, community or GitHub.

We should improve the warning message to not drive fear into the heart of the users. Maybe something like '"Cisco Webex Extension" has not been verified by Brave'?

And then if we could either add a link or open a tab to explain what "verified" or "recommended" actually means, I think that would help.

Steps to Reproduce

  1. Open https://chrome.google.com/webstore/detail/cisco-webex-extension/jlhmfgmfgeifomenelglieieghnjghma?hl=en in Brave
  2. Click "Add to Chrome"

Actual result:

Get install message with a shouting warning
image

Expected result:

Get install message

Reproduces how often:

Easily reproduced

Brave version (chrome://version info)

Brave | 0.55.10 Chromium: 70.0.3538.22 (Official Build) beta (64-bit)
Revision | ac9418ba9c3bd7f6baaffa0b055dfe147e0f8364-refs/branch-heads/3538@{#468}
OS | Windows

@srirambv
Copy link
Contributor

srirambv commented Oct 3, 2018

cc: @davidtemkin @bbondy @tomlowenthal

@bbondy bbondy added this to the 1.x Backlog milestone Oct 3, 2018
@davidtemkin
Copy link

WHAT'S WRONG WITH SHOUTING??

@rebron rebron modified the milestones: 1.x Backlog, 1.0 (0.56.x) Oct 5, 2018
@rebron
Copy link
Collaborator

rebron commented Oct 5, 2018

Text edit only.

@rebron rebron assigned bbondy and unassigned tildelowengrimm Oct 16, 2018
@rebron
Copy link
Collaborator

rebron commented Oct 16, 2018

cc: @bbondy
Text for dialog box should read: "Brave hasn't reviewed this extension yet - it might be malicious. Add "[Extension Name]" anyway?"

@rebron rebron modified the milestones: 1.0, FROZEN: 0.55.x - Release Oct 16, 2018
@petemill
Copy link
Member

I can take this one whilst we're only changing the title and not modifying the content yet (for 0.55). We should open another issue for a cleaner dialog which adds in the text we want to the content area @rebron

@srirambv
Copy link
Contributor

srirambv commented Oct 18, 2018

Verification Passed on

Brave 0.55.17 Chromium: 70.0.3538.67 (Official Build) (64-bit)
Revision 9ab0cfab84ded083718d3a4ff830726efd38869f-refs/branch-heads/3538@{#1002}
OS Linux

image

Verification Passed on

Brave 0.55.17 Chromium: 70.0.3538.67 (Official Build) (32-bit)
Revision 9ab0cfab84ded083718d3a4ff830726efd38869f-refs/branch-heads/3538@{#1002}
OS Windows

image

image

Verified passed with

Brave 0.55.17 Chromium: 70.0.3538.67 (Official Build) (64-bit)
Revision 9ab0cfab84ded083718d3a4ff830726efd38869f-refs/branch-heads/3538@{#1002}
OS Mac OS X

screen shot 2018-10-18 at 10 25 45 am

screen shot 2018-10-18 at 10 27 18 am

@jonathansampson
Copy link
Contributor

The wording is a bit hard, and comes across as hinting suspicion of maliciousness. @davidtemkin suggested the following, which I think more accurately communicates our intended message:

Brave hasn’t yet reviewed this extension for security and safety.

@davidtemkin
Copy link

Thanks @jonathansampson -- let's get feedback from @rebron @bradleyrichter

@diracdeltas
Copy link
Member

also please get approval from @tomlowenthal

we did originally intend for the wording to make users think twice before installing. extensions are one of the biggest security risks to browsers IMO and many of them are indeed malicious. see https://www.wired.com/story/chrome-extension-malware/ for instance

personally i am suspicious of almost all extensions in the chrome web store

@MisinformedDNA
Copy link
Author

I agree. What about

Extensions can act as malware. Brave hasn't reviewed this extension. Only install extensions you trust.

@2635599
Copy link

2635599 commented Jan 10, 2019

AGAIN chrome HAS reviewed the extension before it went into the store, so no meed for the ridiculous message in brave.

@MisinformedDNA
Copy link
Author

@2635599 So what are they looking for in their review if Chrome Extensions keep ending up with malware?

I'm not saying I agree that the message needs to be there at all (people mostly ignore messages), but if it's going to be there, it should be more unbiased.

@2635599
Copy link

2635599 commented Jan 10, 2019

@MisinformedDNA and in the real world peeps see a message in all caps they figure the manufacture did something wrong. since the extension HAS been vetted alreday by google there is no need for the warning / message in brave. if there must be any kind of warning something like this WITHOUT the extensions name being added to it right across the top of the extensions page.

"Installing 3rd Party Extensions In Brave May Damage The Browser."

@diracdeltas
Copy link
Member

i think everyone here agrees there's no need for all-caps. maybe "Brave has not reviewed this extension for security and safety. Only install extensions you trust."

@jonathansampson
Copy link
Contributor

We should consider re-opening, and working on the messaging a bit more (per the comments above). I think @diracdeltas and @davidtemkin both had excellent suggestions for alternative wording that isn't as abrasive out of the gate.

@karenkliu
Copy link

Here's a mock:
extension dialogue text

@karenkliu karenkliu reopened this Jan 30, 2019
@diracdeltas
Copy link
Member

@karenkliu i like it! only change i would suggest is change "trust it" to "trust the developer"

@karenkliu
Copy link

extension dialogue text

@bbondy
Copy link
Member

bbondy commented Jan 30, 2019

@jonathansampson since this issue was closed with a PR and did its purpose, please open a new issue for this. It makes it hard for tracking across milestones and we lose what landed in which milestone by re-using issues.

@bbondy bbondy closed this as completed Jan 30, 2019
@bbondy
Copy link
Member

bbondy commented Jan 30, 2019

Thanks @jonathansampson !

@karenkliu
Copy link

New issue is here #3231

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment