Update extension dialogue text so it's not as misleading

[karenkliu]

Description

When I try to add any extension to Brave from the Chrome Store, I get this message:

We should improve the warning message so it doesn't send the wrong message to the user.

Steps to Reproduce

1. Go to https://chrome.google.com/webstore/category/extensions
2. Click on any extension
3. Click "Add to Chrome"

Designs

Update message to "Brave has not reviewed this extension for security and safety. Only install this extension if you trust the developer. It can:"

This text has been reviewed in #1408.

[tildelowengrimm]

This text is security approved 👍

[rebron]

cc: @bbondy, @mkarolin can you guys take a look, will likely want to get this in as soon as we can e.g. 62.x.

[mkarolin]

@karenkliu "It can:" label is tied to the permissions. If an extension doesn't ask for any permissions the label isn't shown:

I assume we would still want the label there in such cases, just without "It can:" part?

[tildelowengrimm]

I think it's better to keep the "It can:" separate.

[karenkliu]

@mkarolin @tomlowenthal Yes, correct, we keep "It can: ..." separate so that if the extension doesn't ask for any permissions, it will still say "Brave has not reviewed this extension for security and safety. Only install this extension if you trust the developer." without the "It can: ..." part.

[LaurenWags]

@karenkliu @tomlowenthal @simonhong @rebron

A couple of questions:

1. We don't seem to show this new message for some extensions (LastPass, Honey, Grammarly, etc). Is this ok? If so, is it necessary to have a full list of extensions which would be exempt from this message for QA to check?

2. When this new message displays, we're no longer showing the extension name in the message box, is this ok?
   ex. This is how the message displays for Google Translate:
   https://chrome.google.com/webstore/detail/google-translate/aapbdbdomjkkjkaonfhkkikfgjllcleb
   

cc @kjozwiak

[tildelowengrimm]

@LaurenWags

1. Yes, there's a list of several extensions we've reviewed, and which shouldn't show this warning. I think @rebron owns that document.

2. No, that's a bug. The design spec up at the top shows the extension name by way of a header. That should be implemented.

[rebron]

@LaurenWags Should we keep this one closed and file a new issue for the extension name in header?
I'll get you the list of extensions where this warning isn't supposed to show up.

[LaurenWags]

@rebron yep - that's the correct process. I'll close this one again and have logged #5575. Please take a look at the new issue - I added all the same labels as this (including priority) - which may need to be adjusted.

[btlechowski]

Verification passed on

Brave	0.68.118 Chromium: 76.0.3809.87 (Official Build) beta (64-bit)
Revision	111fe1e15d5ced26080a7dc239bcfe70f6c49aad-refs/branch-heads/3809@{#967}
OS	Ubuntu 18.04 LTS

Reproduced #5575

• Verification passed on

Brave	0.68.129 Chromium: 76.0.3809.100 (Official Build) (64-bit)
Revision	ed9d447d30203dc5069e540f05079e493fc1c132-refs/branch-heads/3809@{#990}
OS	Windows 10 OS Version 1803 (Build 17134.523)

• Encountered Extension name not in dialog box - follow up to 3231 #5575
• Verified that the warning message is not displayed for Pocket/Last Pass/Honey/Grammarly
• Verified that the warning message displayed as expected for few extensions uBlock/Google hangouts/Google Translate /Speedtest/Line/Momentum/Evernote web clipper

Verified passed with

Brave	0.68.130 Chromium: 76.0.3809.100 (Official Build) (64-bit)
Revision	ed9d447d30203dc5069e540f05079e493fc1c132-refs/branch-heads/3809@{#990}
OS	Mac OS X

• Encountered Extension name not in dialog box - follow up to 3231 #5575
• Verified that the warning message is not displayed for Pocket/Last Pass/Honey/Grammarly
• Verified that the warning message displayed as expected for few extensions Custom Cursor/Google Translate/Dark Reader/Colorful Rubik's Cube