Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleted publisher gets added back when the site is revisited #1440

Closed
srirambv opened this issue Oct 5, 2018 · 2 comments
Closed

Deleted publisher gets added back when the site is revisited #1440

srirambv opened this issue Oct 5, 2018 · 2 comments

Comments

@srirambv
Copy link
Contributor

srirambv commented Oct 5, 2018

Description

While testing #1379, found that deleted publisher gets added back when the site is revisited

Steps to Reproduce

  1. Enable Brave Rewards on 0.55.11
  2. Visit https://brianbondy.com for min time ensure its added to the list
  3. Visit https://clifton.io for min time ensure its added to the list as well
  4. Delete brianbondy.com from the list
  5. Visit https://brianbondy.com/ in a new tab for the min time, gets added back to the list

Actual result:

Deleted publisher gets added back when the site is revisited

Expected result:

Should show the deleted list and removing it from there and visiting the site should add it back to the list

Reproduces how often:

Easy

Brave version (chrome://version info)

Brave 0.55.11 Chromium: 70.0.3538.35 (Official Build) beta (64-bit)
Revision 28dcb499844fa40c28d5f62e337876cb936f79f5-refs/branch-heads/3538@{#678}
OS Linux

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds? Yes
  • Does it reproduce on browser-laptop? No. B-l doesn't add back the site to list unless its removed from the deleted site list

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
  • Is the issue reproducible on the latest version of Chrome?

Additional Information

cc: @LaurenWags @kjozwiak @NejcZdovc

@LaurenWags
Copy link
Member

LaurenWags commented Oct 8, 2018

Reproduced on macOS with

Brave 0.55.11 Chromium: 70.0.3538.35 (Official Build) beta(64-bit)
Revision 28dcb499844fa40c28d5f62e337876cb936f79f5-refs/branch-heads/3538@{#678}
OS Mac OS X

Reproduced on Win 7

Brave 0.55.12 Chromium: 70.0.3538.45 (Official Build) (64-bit)
Revision cbdc32e4334458954e9def214d7e5fa1ca1960eb-refs/branch-heads/3538@{#830}
OS Windows 7

@rebron rebron added the priority/P2 A bad problem. We might uplift this to the next planned release. label Oct 19, 2018
@rebron rebron modified the milestones: 1.x Backlog, 0.56.x - Beta Oct 19, 2018
@LaurenWags
Copy link
Member

LaurenWags commented Nov 1, 2018

Verified passed with

Brave 0.56.7 Chromium: 70.0.3538.77 (Official Build) beta(64-bit)
Revision 0f6ce0b0cd63a12cb4eccea3637b1bc9a29148d9-refs/branch-heads/3538@{#1039}
OS Mac OS X
  • Verified STR from description

Verification passed on

Brave 0.56.8 Chromium: 70.0.3538.77 (Official Build) (64-bit)
Revision 0f6ce0b0cd63a12cb4eccea3637b1bc9a29148d9-refs/branch-heads/3538@{#1039}
OS Windows
  • Verified STR from description

Verification Passed on

Brave 0.56.8 Chromium: 70.0.3538.77 (Official Build) (64-bit)
Revision 0f6ce0b0cd63a12cb4eccea3637b1bc9a29148d9-refs/branch-heads/3538@{#1039}
OS Linux

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment