Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add remove to auto-contribute table #1379

Closed
NejcZdovc opened this issue Oct 1, 2018 · 1 comment · Fixed by brave/brave-core#537
Closed

Add remove to auto-contribute table #1379

NejcZdovc opened this issue Oct 1, 2018 · 1 comment · Fixed by brave/brave-core#537
Assignees
@NejcZdovc
Labels
feature/rewards QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes
Milestone
0.55.x - Release ...

Comments

@NejcZdovc
Copy link
Contributor

NejcZdovc commented Oct 1, 2018 •
edited
Loading

We need to add remove for top five sites as well in auto contribute section in Rewards

image
@NejcZdovc NejcZdovc added this to the Releasable builds 0.55.x milestone Oct 1, 2018
@NejcZdovc NejcZdovc self-assigned this Oct 1, 2018
NejcZdovc added a commit to brave/brave-core that referenced this issue Oct 1, 2018
@NejcZdovc
Adds remove option to ac table in rewards
b02715e 
Resolves brave/brave-browser#1379
@NejcZdovc NejcZdovc mentioned this issue Oct 1, 2018
Merged
11 tasks
@srirambv
Copy link
Contributor

srirambv commented Oct 5, 2018 •
edited by btlechowski
Loading

Verification Passed on

Brave 0.55.11 Chromium: 70.0.3538.35 (Official Build) beta (64-bit)
Revision 28dcb499844fa40c28d5f62e337876cb936f79f5-refs/branch-heads/3538@{#678}
OS Linux
  • Verified remove X is shown next to the publishers when there are 5 or less publishers listed
    image

Verified passed with

Brave 0.55.11 Chromium: 70.0.3538.35 (Official Build) beta(64-bit)
Revision 28dcb499844fa40c28d5f62e337876cb936f79f5-refs/branch-heads/3538@{#678}
OS Mac OS X

Verification passed on

Brave 0.55.11 Chromium: 70.0.3538.35 (Official Build) beta (64-bit)
Revision 28dcb499844fa40c28d5f62e337876cb936f79f5-refs/branch-heads/3538@{#678}
OS Windows 7

@srirambv srirambv mentioned this issue Oct 5, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NejcZdovc NejcZdovc

Labels
feature/rewards QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes
Projects
None yet
Milestone
0.55.x - Release (Release Channel)
Development

Successfully merging a pull request may close this issue.

Adds remove option to ac table in rewards brave/brave-core
4 participants
@NejcZdovc @srirambv @LaurenWags @btlechowski