PDF.js should NOT be shown in brave://extensions when launched with --show-component-extension-options

[stephendonner]

Description

PDF.js should NOT be shown in brave://extensions when launched with --show-component-extension-options

(Sorry!) I missed this, apparently, when verifying #14338 (with the testcase in brave/brave-core#8061)

Steps to Reproduce

1. Go to https://chrome.google.com/webstore/detail/pdf-viewer/oemmndcbldboiebfnladdacbdfmadadm
2. Verify that you can install PDF.js
3. Verify that PDF.js puts a browser action button in the extension area
4. Verify that PDF.js shows in brave://extensions
5. Open a PDF document and verify PDF.js is used
6. Launch Brave from the command line with --show-component-extension-options
7. Load brave://extensions
8. Look for the PDF Viewer / PDF.js extension (shouldn't be there)

Actual result:

Expected result:

There should be no PDF.js / PDF Viewer extensions visible in brave://extensions, when launched with --show-component-extension-options

Reproduces how often:

100%

Brave version (brave://version info)

Brave	1.25.2 Chromium: 90.0.4430.51 (Official Build) nightly (x86_64)
Revision	32e5fa33a31641bded70a90e60121060691e7125-refs/branch-heads/4430@{#927}
OS	macOS Version 11.2.3 (Build 20D91)

Version/Channel Information:

• Can you reproduce this issue with the current release? yes
• Can you reproduce this issue with the beta channel? yes
• Can you reproduce this issue with the nightly channel? yes

/cc @kjozwiak @mariospr @GeetaSarvadnya

[GeetaSarvadnya]

Reproduced in Windows 10 x64 - 1.23.65

[simonhong]

@stephendonner I think this is expected behavior. With --show-component-extension-options, brave://extensions page shows all installed extensions(extensions from webstore and component extensions like wallet.

[bsclifton]

@simonhong is exactly right; any installed extensions will show here

Had me doing a double take as we used to package PDF.js with the browser (and it was hidden by default) and I thought something regressed! 😂 Read your tests steps and this is working as designed. You can try the same steps in Chrome

@stephendonner if you were using test plan from brave/brave-core#2342 you'll want to ignore anything mentioning PDF.js as we removed that from packaging. It's treated the same as any regular extension now

[kjozwiak]

@stephendonner if you were using test plan from brave/brave-core#2342 you'll want to ignore anything mentioning PDF.js as we removed that from packaging. It's treated the same as any regular extension now

That's where the confusion occurred. I was running through Linux and noticed that I can still see the PDF Viewer we installed via brave://extensions while running Brave with --show-component-extension-options. The test case basically mentioned that we shouldn't be visible which was strange but figured it was an issue. @stephendonner confirmed he was seeing the same thing.

Thanks for clearing it up @simonhong & @bsclifton 👍

[GeetaSarvadnya]

@simonhong Test plan for Test that PDF.js does not show needs to be corrected in brave/brave-core#2342
(Step 4: Verify PDF.js does not show in brave://extensions)

[bsclifton]

@GeetaSarvadnya the test plan shown was from a PR 3 years ago; maybe the right thing to do would have been to copy the test plan and edit instead of linking to the old test plan in brave/brave-core#8061