Remove chrome-common-chrome_content_client_constants.cc.patch

[mariospr]

Description

This patch could be removed in favour of chromium_src overrides to redefine the values for the constants we're interested in.

Desktop Brave version:

Brave 1.23.1 (Chromium 89.0.4389.58)

Miscellaneous Information:

This removal references a patch initially introduced with brave/brave-core#2342

[stephendonner]

Verified PASSED with the testplan from brave/brave-core#2342, using nightly build

Brave	1.23.19 Chromium: 89.0.4389.72 (Official Build) nightly (x86_64)
Revision	3f345f156bfd157bd1bea06310e55f3fb2490359-refs/branch-heads/4389@{#1393}
OS	macOS Version 11.2.2 (Build 20D80)

Test fix for brave/brave-browser#3694

1. Go to https://docs.google.com and login
2. Create a new Google Sheets document
3. Type some values in there
4. Pick File => Print from the Google apps menu (not the browser menu)
5. Try to print document
6. Document should actually print (you should not be prompted to save as PDF)

NOTE: Same behavior on 1.21.73 Chromium: 89.0.4389.72 (Official Build) (x86_64); this looks to be #11913

Test fix for brave/brave-browser#884

1. Go to http://citeseerx.ist.psu.edu/viewdoc/download?doi=10.1.1.144.7135&rep=rep1&type=pdf
2. Document should load properly

Test fix for brave/brave-browser#4424

1. Go to http://pdfkit.org/demo/browser.html
2. Document on right hand side should load properly

Embed test (possible fix for brave/brave-browser#3119)

1. Go to https://pdfobject.com/examples/detection.html
2. Message This browser supports inline PDFs should be shown (green color)

Test that PDF.js is still installable

1. Go to https://chrome.google.com/webstore/detail/pdf-viewer/oemmndcbldboiebfnladdacbdfmadadm
2. Verify that you can install PDF.js
3. Verify that PDF.js puts a browser action button in the extension area
4. Verify that PDF.js shows in brave://extensions
5. Open a PDF document and verify PDF.js is used

Test that PDF.js does not show

1. Have an existing profile BEFORE testing this. Make sure PDF.js works
2. Upgrade to a build with this fix
3. Launch Brave from the command line with --show-component-extension-options
4. Verify PDF.js does NOT show in brave://extensions

5. Verify PDF.js does NOT show in brave://components

---

Verification passed on

Brave | 1.23.59 Chromium: 89.0.4389.114 (Official Build) dev (64-bit)
-- | --
Revision | 1ea76e193b4fadb723bfea2a19a66c93a1bc0ca6-refs/branch-heads/4389@{#1616}
OS | Windows 10 OS Version 2004 (Build 19041.867)

Test fix for brave/brave-browser#3694

1. Go to https://docs.google.com and login
2. Create a new Google Sheets document
3. Type some values in there
4. Pick File => Print from the Google apps menu (not the browser menu)
5. Try to print document
6. Document should actually print (you should not be prompted to save as PDF)

Click on Print icon in the google apps menu for excel doc is still prompting save the file instead of Print dialogue, the issue is not fixed, encountered the issue #11913

Test fix for brave/brave-browser#884

1. Go to http://citeseerx.ist.psu.edu/viewdoc/download?doi=10.1.1.144.7135&rep=rep1&type=pdf
2. Document should load properly
   

Test fix for brave/brave-browser#4424

1. Go to http://pdfkit.org/demo/browser.html
2. Document on right hand side should load properly
   

Embed test (possible fix for brave/brave-browser#3119)

1. Go to https://pdfobject.com/examples/detection.html
2. Message This browser supports inline PDFs should be shown (green color)
   

Test that PDF.js is still installable

1. Go to https://chrome.google.com/webstore/detail/pdf-viewer/oemmndcbldboiebfnladdacbdfmadadm
2. Verify that you can install PDF.js
3. Verify that PDF.js puts a browser action button in the extension area
4. Verify that PDF.js shows in brave://extensions
5. Open a PDF document and verify PDF.js is used

Test that PDF.js does not show

1. Have an existing profile BEFORE testing this. Make sure PDF.js works
2. Upgrade to a build with this fix
3. Launch Brave from the command line with --show-component-extension-options
4. Verify PDF.js/ PDF viewer show in brave://extensions

Installed 1.22.52 and installed PDF.js extension https://chrome.google.com/webstore/detail/pdf-viewer/oemmndcbldboiebfnladdacbdfmadadm/related

Upgraded the profile to 1.23.59 and launched the browser using brave.exe --show-component-extension-options and ensured PDF.js / PDF viewer shown in brave://extensions

Verify PDF.js does NOT show in brave://components

---

Verification PASSED on Ubuntu 20.04 x64 using the following build:

Brave | 1.23.66 Chromium: 89.0.4389.114 (Official Build) beta (64-bit)
--- | ---
Revision | 1ea76e193b4fadb723bfea2a19a66c93a1bc0ca6-refs/branch-heads/4389@{#1616}
OS | Linux

Test fix for brave/brave-browser#3694

1. Go to https://docs.google.com and login
2. Create a new Google Sheets document
3. Type some values in there
4. Pick File => Print from the Google apps menu (not the browser menu)
5. Try to print document
6. Document should actually print (you should not be prompted to save as PDF)

NOTE: Ran into #11913 when going through this case. Asking me to save the PDF rather than printing it which is known.

Example	Example

Test fix for brave/brave-browser#884

1. Go to http://citeseerx.ist.psu.edu/viewdoc/download?doi=10.1.1.144.7135&rep=rep1&type=pdf
2. Document should load properly

Test fix for brave/brave-browser#4424

1. Go to http://pdfkit.org/demo/browser.html
2. Document on right hand side should load properly

Embed test (possible fix for brave/brave-browser#3119)

1. Go to https://pdfobject.com/examples/detection.html
2. Message This browser supports inline PDFs should be shown (green color)

Test that PDF.js is still installable

1. Go to https://chrome.google.com/webstore/detail/pdf-viewer/oemmndcbldboiebfnladdacbdfmadadm
2. Verify that you can install PDF.js
3. Verify that PDF.js puts a browser action button in the extension area
4. Verify that PDF.js shows in brave://extensions
5. Open a PDF document and verify PDF.js is used

Test that PDF.js does not show

1. Have an existing profile BEFORE testing this. Make sure PDF.js works
2. Upgrade to a build with this fix
3. Launch Brave from the command line with --show-component-extension-options
4. Verify PDF.js does NOT show in brave://extensions

Note: Found #15185 while running through the above case. Looks like PDF Viewer isn't being removed from brave://extensions when launching Brave via --show-component-extension-options. @stephendonner reproduced as well.

5. Verify PDF.js does NOT show in brave://components

[srirambv]

Removing OS/Android label as PDF is handled natively in Android and chrome://extensions doesn't resolve as extension support is not available on Android