Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crashed when dragging enters into sidebar web panel #15505

Closed
simonhong opened this issue Apr 27, 2021 · 5 comments · Fixed by brave/brave-core#8649
Closed

Crashed when dragging enters into sidebar web panel #15505

simonhong opened this issue Apr 27, 2021 · 5 comments · Fixed by brave/brave-core#8649

Comments

@simonhong
Copy link
Member

simonhong commented Apr 27, 2021

Crashed when dragging enters into sidebar webpanel. Only happen on macOS.

Description

Steps to Reproduce

  1. Enable sidebar feature via brave://flags and re-launch
  2. Load brave.com in a new tab
  3. Click sidebar's brave together panel
  4. Dragging brave.com tab's site info (security icon in omnibox) into sidebar web panel

Actual result:

Crashed

Expected result:

Not crashed

Reproduces how often:

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release? NO
  • Can you reproduce this issue with the beta channel? NO
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@simonhong simonhong self-assigned this Apr 27, 2021
simonhong added a commit to brave/brave-core that referenced this issue Apr 27, 2021
fix brave/brave-browser#15505
Set dummy WebContentsDelegate to sidebar WebContents.
Real delegate implementation will be done as a separate task.
@stephendonner
Copy link

Marking as QA/Blocked until we get Sidebar merged into the 1.25.x branch.

@LaurenWags
Copy link
Member

LaurenWags commented May 12, 2021

cc @rebron to confirm, but I think sidebar is behind a flag - so I think we should be able to test this one.

@simonhong
Copy link
Member Author

@LaurenWags Yes, sidebar is behind a flag and that flag is only available for nightly. it's not available for beta/stable yet.

@LaurenWags
Copy link
Member

per discussion with @simonhong @rebron @stephendonner this can be tested on Nightly

@LaurenWags
Copy link
Member

LaurenWags commented May 17, 2021

Verified passed with

Brave	1.26.21 Chromium: 91.0.4472.57 (Official Build) nightly (x86_64)
Revision	e3443317fa07f1e9997e4a9c738eddfefc3c0292-refs/branch-heads/4472_54@{#6}
OS	macOS Version 10.15.7 (Build 19H1030)

Verified STR from description. Confirmed no crash was observed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants