-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
summary table should be cleared when another wallet is restored #1559
Comments
@NejcZdovc @jenn-rhim @jasonrsadler @kjozwiak @mandar-brave Not so sure about this. When a wallet is restored, it seems to me that we should change the source of payments from that point forward to be the newly restored wallet. However, the transaction history (including history of contributions, tips, and so on) I believe should not be cleared, just as the Auto-Contribute table remains intact, and the Monthly Tips table remain intact, etc. A given user would want previous transactions as part of the record (including on monthly statements) regardless of a change in wallets (e.g., payment source). I would expect anything in the Grants popdown to be replaced upon wallet restore, as grants are attached to a given wallet. (This does raise the question of how a user would entirely clear Brave Rewards state. Currently you'd need to delete the user profile to do so, as turning rewards on/off does not do it (it just pauses activity), and under the logic here, wallet restore wouldn't do it either. But we do not need to solve that here). Thoughts? |
The contributions are attached to a given wallet as well. @NejcZdovc Do we currently (or is it in the works) for users to download a tx history pdf? I would say we should advise users with a tx history to backup or save the reports before restoring. |
@jasonrsadler This is not a technical question or a matter of how the underlying implementation works. The question is about what model we want to present to the user. I do not believe we should turn "restore wallet" into "reset Brave Rewards". It means just that -- "restore wallet", not "delete old reports", "clear my transaction history", etc. This was discussed recently in the context of another issue; @jenn-rhim and @NejcZdovc weighed in. I believe the conclusion in that context was that we should replace the wallet proper when restoring, and not replace/clear anything else. |
Of course. I was responding in a user-context sort of way. A consideration is if a user restores a wallet and we leave the summary, are there any drawbacks to a user wondering what wallet something on the summary came from? Just putting my 2 cents but I'll let you and others make the decision :) |
Verification passed on
Verification passed on
Verified passed with
|
Description
When you accept a grant with a new wallet, and then restore another wallet, the grant that was accepted with the first wallet still appears in the summary table. We should be clearing the summary table as the accepted grant mentioned above isn't associated with the new restored wallet.
Steps to Reproduce
chrome://rewards
Settings
->Restore your Wallet
You'll notice that the accepted grant wasn't removed from the summary table
Actual result:
Notice that the
Grant
dropdown menu has been removed below the total as a new wallet was imported. However, the original 25 BAT that was accepted remained in the summary table.Expected result:
We should be clearing anything that's associated with a wallet once another wallet has been restored.
Reproduces how often:
100% reproducible using the above STR.
Brave version (chrome://version info)
Reproducible on current release:
Yes, reproducible on both
dev
andbeta
builds:N/A as
b-l
didn't have a summary table that displayed accepted grants.The text was updated successfully, but these errors were encountered: