Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New tab page Thumbnail Removed popup persists even after Brave is restarted #1646

Closed
cndouglas opened this issue Oct 17, 2018 · 4 comments
Closed
Labels
closed/duplicate Issue has already been reported closed/invalid

Comments

@cndouglas
Copy link
Contributor

Description

If a top site thumbnail on the new tab page is deleted, the popup that says "Thumb Removed." is shown, as expected. However, if Brave is quit and restarted, the popup still shows. This is confusing because the thumbnail was not removed during the current browsing session.

Steps to Reproduce

  1. Make sure there is at least one top site thumbnail on the new tab page. If not, browse a few websites.
  2. Click the remove button on the thumbnail.
  3. Quit Brave.
  4. Open Brave again.

Actual result:


The Thumbnail Removed popup is still shown.

Expected result:

The popup should not be shown.

Reproduces how often:

Possibly intermittent, but I haven't tested enough to be sure.

Brave version (brave://version info)

Brave 0.56.4 Chromium: 70.0.3538.54 (Official Build) dev (64-bit)
Revision 4f8e578b6680574714e9ed3bb9f02922b4dde40d-refs/branch-heads/3538@{#937}
OS Mac OS X

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds? Yes.
  • Does it reproduce on browser-laptop? Not sure.

Website problems only: not applicable

Additional Information

Labels: feature/new-tab

@bbondy bbondy added this to the 1.x Backlog milestone Oct 18, 2018
@bbondy bbondy added the priority/P4 Planned work. We expect to get to it "soon". label Oct 18, 2018
@cndouglas
Copy link
Contributor Author

May be fixed with the dashboard page redesign (as of 0.60.16 dev). The popup disappears if I close and reopen the window. I haven't tried with quit/restart yet.

@cndouglas
Copy link
Contributor Author

Confirmed fixed as of 0.60.17 dev (after the dashboard page redesign).

@simonhong
Copy link
Member

Fixed by brave/brave-core#1194

@simonhong
Copy link
Member

duplicated with #2772

@srirambv srirambv modified the milestones: 1.x Backlog, Dupe / Invalid / Not actionable Jan 25, 2019
@srirambv srirambv removed the priority/P4 Planned work. We expect to get to it "soon". label Jan 25, 2019
@srirambv srirambv added the closed/duplicate Issue has already been reported label Jan 25, 2019
@bbondy bbondy removed this from the Dupe / Invalid / Not actionable milestone May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed/duplicate Issue has already been reported closed/invalid
Projects
None yet
Development

No branches or pull requests

4 participants