Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

attention % values for sites visited after contribution are incorrect #1656

Closed
LaurenWags opened this issue Oct 17, 2018 · 5 comments
Closed

Comments

@LaurenWags
Copy link
Member

Description

After a contribution occurs, the Auto-Contribute table is cleared as expected. However, when you visit sites and they are added back to the table, the % values aren't adding up to 100.
Found while testing #1501

Steps to Reproduce

  1. clean profile
  2. enable rewards
  3. claim grant
  4. Close Brave. Update reconcile stamp in ledger_state file (I used current time + 15 minutes)
  5. Reopen Brave.
  6. visit some sites so that they are added to the table (note % values add up to 100)
  7. wait for contribution
  8. make sure that table is cleared and reconcile stamp is updated
  9. Visit some sites and verify they are added to the table. Look at Attention % values.

Actual result:

% values aren't recalculated so that they all add up to 100%
screen shot 2018-10-17 at 10 41 03 am

Expected result:

% values should add up to 100%

Reproduces how often:

easily

Brave version (brave://version info)

Brave 0.55.16 Chromium: 70.0.3538.54 (Official Build) (64-bit)
Revision 4f8e578b6680574714e9ed3bb9f02922b4dde40d-refs/branch-heads/3538@{#937}
OS Mac OS X

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds? n/a - code is not there at this time
  • Does it reproduce on browser-laptop? n/a

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Additional Information

cc @NejcZdovc
cc @brave/legacy_qa for verification on other platforms

@NejcZdovc
Copy link
Contributor

@kjozwiak possibly fixed with #1701

@NejcZdovc
Copy link
Contributor

@LaurenWags please re-check after hotfix 2

@kjozwiak
Copy link
Member

kjozwiak commented Oct 24, 2018

@kjozwiak possibly fixed with #1701

I couldn't check this reliably because I kept running into #1796.

@LaurenWags please re-check after hotfix 2

@LaurenWags is on PTO till next week so I'll go through #1796 and this issue once we get a RC 👍

@NejcZdovc
Copy link
Contributor

will close and we can reopen if it's still a problem

@LaurenWags
Copy link
Member Author

LaurenWags commented Nov 2, 2018

Verified passed with

Brave 0.56.8 Chromium: 70.0.3538.77 (Official Build) (64-bit)
Revision 0f6ce0b0cd63a12cb4eccea3637b1bc9a29148d9-refs/branch-heads/3538@{#1039}
OS Mac OS X
  • Verified STR from description (used flags for --rewards-env=stag and --rewards-reconcile-interval=10 instead of manually changing the stamp)

Verification Passed on

Brave 0.56.8 Chromium: 70.0.3538.77 (Official Build) (64-bit)
Revision 0f6ce0b0cd63a12cb4eccea3637b1bc9a29148d9-refs/branch-heads/3538@{#1039}
OS Linux
  • Verified STR with --rewards-env=stag --rewards-reconcile-interval=4

Verification Passed on

Brave 0.56.8 Chromium: 70.0.3538.77 (Official Build) (64-bit)
Revision 0f6ce0b0cd63a12cb4eccea3637b1bc9a29148d9-refs/branch-heads/3538@{#1039}
OS Windows
  • Verified the STR on staging env using BraveSoftware/Brave-Browser/Application/brave.exe --rewards-env=stag --rewards-reconcile-interval=10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment