Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tip 1BAT doesn't get listed #1659

Closed
srirambv opened this issue Oct 17, 2018 · 2 comments
Closed

Tip 1BAT doesn't get listed #1659

srirambv opened this issue Oct 17, 2018 · 2 comments

Comments

@srirambv
Copy link
Contributor

Description

Tip 1BAT doesn't get listed

Steps to Reproduce

  1. Enable rewards and add funds
  2. Visit a site, click BR panel and send tip
  3. Select 1BAT and send tip, shows thanks for tipping but doesn't list it in brave://rewards
  4. Tip with a higher value first 5/10 BAT and then 1BAT gets listed

Actual result:

Tip 1BAT doesn't get listed

Expected result:

Should list even if you start with small amount

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 0.55.16 Chromium: 70.0.3538.54 (Official Build) (64-bit)
Revision 4f8e578b6680574714e9ed3bb9f02922b4dde40d-refs/branch-heads/3538@{#937}
OS Linux

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds?
  • Does it reproduce on browser-laptop?

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
  • Is the issue reproducible on the latest version of Chrome?

Additional Information

Issue reproduced by @kjozwiak on mac

@kjozwiak
Copy link
Member

kjozwiak commented Oct 18, 2018

@NejcZdovc @mandar-brave as per our earlier discussion, this needs to get fixed for tomorrow's release. Most folks are probably going start with a 1 BAT donation to see how the feature works.

As mentioned before, the 5 BAT restriction for grants needs to be removed form production. I'm not sure why this was removed from the FROZEN: 0.55.x - Release milestone as we agreed that this will get fixed before we ship.

@srirambv
Copy link
Contributor Author

srirambv commented Oct 18, 2018

Verification Passed on

Brave 0.55.18 Chromium: 70.0.3538.67 (Official Build) (64-bit)
Revision 9ab0cfab84ded083718d3a4ff830726efd38869f-refs/branch-heads/3538@{#1002}
OS Linux
  • Verified 1BAT is tipped and listed when 1BAT is the first tip

Verification passed on

Brave 0.55.18 Chromium: 70.0.3538.67 (Official Build) (64-bit)
Revision 9ab0cfab84ded083718d3a4ff830726efd38869f-refs/branch-heads/3538@{#1002}
OS Windows 7 x64

image

Went through verification using the following build under macOS 10.13.6 x64 - PASSED

Brave 0.55.18 Chromium: 70.0.3538.67 (Official Build) (64-bit)
Revision 9ab0cfab84ded083718d3a4ff830726efd38869f-refs/branch-heads/3538@{#1002}
OS Mac OS X

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants