Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't connect to www.googleapis.com/chromewebstore/v1.1/items/verify #1672

Closed
tildelowengrimm opened this issue Oct 17, 2018 · 3 comments · Fixed by brave/brave-core#674
Closed

Don't connect to www.googleapis.com/chromewebstore/v1.1/items/verify #1672

tildelowengrimm opened this issue Oct 17, 2018 · 3 comments · Fixed by brave/brave-core#674
Assignees
@diracdeltas
Labels
audit-beta audit-release priority/P2 A bad problem. We might uplift this to the next planned release. privacy/connect This requires making a network connection to a third-party service. privacy QA Pass-Win64 QA/Test-Plan-Specified QA/Yes
Milestone
0.55.x - Release ...

Comments

@tildelowengrimm
Copy link
Contributor

tildelowengrimm commented Oct 17, 2018 •
edited
Loading

Test plan

See brave/brave-core#674
__

On startup, we seem to make connections to https://www.googleapis.com/chromewebstore/v1.1/items/verify. We shouldn't.

Related to #663.
@tildelowengrimm tildelowengrimm added privacy priority/P2 A bad problem. We might uplift this to the next planned release. audit-beta audit-release privacy/connect This requires making a network connection to a third-party service. labels Oct 17, 2018
@bbondy
Copy link
Member

bbondy commented Oct 18, 2018

Removed "https://clients1.google.com/tbproxy/af/query?" since it's fixed here:
#1676

@bbondy bbondy changed the title Don't connect to Google on startup Don't connect to https://www.googleapis.com/chromewebstore/v1.1/items/verify Oct 18, 2018
@bbondy bbondy changed the title Don't connect to https://www.googleapis.com/chromewebstore/v1.1/items/verify Don't connect to www.googleapis.com/chromewebstore/v1.1/items/verify Oct 18, 2018
@diracdeltas diracdeltas self-assigned this Oct 18, 2018
@diracdeltas
Copy link
Member

didn't see this issue til now but i have a PR open for this: brave/brave-core#674

This was referenced Oct 18, 2018
Merged
Closed
@btlechowski
Copy link

btlechowski commented Oct 19, 2018 •
edited
Loading

Verification passed on

Brave 0.55.18 Chromium: 70.0.3538.67 (Official Build) (64-bit)
Revision 9ab0cfab84ded083718d3a4ff830726efd38869f-refs/branch-heads/3538@{#1002}
OS Windows 7 x64

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@diracdeltas diracdeltas

Labels
audit-beta audit-release priority/P2 A bad problem. We might uplift this to the next planned release. privacy/connect This requires making a network connection to a third-party service. privacy QA Pass-Win64 QA/Test-Plan-Specified QA/Yes
Projects
None yet
Milestone
0.55.x - Release (Release Channel)
Development

Successfully merging a pull request may close this issue.

disable CWS signature verification for PDFJS diracdeltas/brave-core
5 participants
@diracdeltas @tildelowengrimm @bbondy @srirambv @btlechowski