Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable CWS signature verification for PDFJS #674

Merged
merged 1 commit into from
Oct 18, 2018

Conversation

diracdeltas
Copy link
Member

@diracdeltas diracdeltas commented Oct 17, 2018

needed for
brave/brave-browser#663 (comment)
fix brave/brave-browser#1672

PDFJS is not directly installed from CWS as of
brave/brave-core-crx-packager#29

test plan (the hard way):

  1. delete your profile folder.
  2. follow instructions in https://github.com/brave/brave-browser/wiki/Tests#privacy-network-audit to start brave with a network log capture. wait a few minutes before closing the browser because it takes a while for PDFJS to load.
  3. inspect the chrome network log from step 1. you should not see a request to https://www.googleapis.com/chromewebstore
  4. if using Little Snitch, it should not prompt for any requests to *.googleapis.com
  5. open some PDFs in brave. it should work.

test plan (the easy way):

  1. wait for add npm command for running a network audit brave-browser#1682 to be merged, or check it out in brave-browser
  2. in brave-browser, run npm run network-audit and wait for it to finish
  3. check that the string 'chromewebstore' does not appear in network-audit-results.json

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

@diracdeltas diracdeltas changed the title [WIP] disable CWS signature verification for PDFJS disable CWS signature verification for PDFJS Oct 18, 2018
@diracdeltas diracdeltas self-assigned this Oct 18, 2018
Copy link
Member

@bbondy bbondy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now this is ok but could you post a counter issue to re-add this but going to our server for our IDs?

@bbondy bbondy merged commit 44729fd into brave:master Oct 18, 2018
bbondy added a commit that referenced this pull request Oct 18, 2018
disable CWS signature verification for PDFJS
bbondy added a commit that referenced this pull request Oct 18, 2018
disable CWS signature verification for PDFJS
bbondy added a commit that referenced this pull request Oct 18, 2018
disable CWS signature verification for PDFJS
@bbondy
Copy link
Member

bbondy commented Oct 18, 2018

master: 44729fd
0.57.x: f975e7e
0.56.x: 7add443
0.55.x: e4e52df

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't connect to www.googleapis.com/chromewebstore/v1.1/items/verify
2 participants