Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't connect to Google for Safe Browsing #1673

Closed
tildelowengrimm opened this issue Oct 17, 2018 · 3 comments · Fixed by brave/brave-core#676
Closed

Don't connect to Google for Safe Browsing #1673

tildelowengrimm opened this issue Oct 17, 2018 · 3 comments · Fixed by brave/brave-core#676
Assignees
@jumde
Labels
audit-beta audit-release priority/P2 A bad problem. We might uplift this to the next planned release. privacy/connect This requires making a network connection to a third-party service. privacy QA Pass-Linux QA Pass-Win64 QA/Test-Plan-Specified QA/Yes
Milestone
0.55.x - Release ...

Comments

@tildelowengrimm
Copy link
Contributor

tildelowengrimm commented Oct 17, 2018 •
edited
Loading

Test plan

see brave/brave-core#676

On startup, we seem to make connections to https://ssl.gstatic.com/safebrowsing/csd/client_model_v5_variation_0.pb. We shouldn't.

Related to #663.
@tildelowengrimm tildelowengrimm added privacy priority/P2 A bad problem. We might uplift this to the next planned release. audit-beta audit-release privacy/connect This requires making a network connection to a third-party service. labels Oct 17, 2018
@jumde
Copy link
Contributor

jumde commented Oct 17, 2018 •
edited
Loading

This should be addressed by: https://github.com/brave/devops/issues/338

@jumde jumde mentioned this issue Oct 17, 2018
Merged
18 tasks
@diracdeltas
Copy link
Member

FYI @tomlowenthal you tagged #633 instead of #663 on this series of issues so they weren't showing up in the parent issue

@diracdeltas diracdeltas mentioned this issue Oct 18, 2018
Closed
@btlechowski
Copy link

btlechowski commented Oct 19, 2018 •
edited by srirambv
Loading

Verification passed on

Brave 0.55.18 Chromium: 70.0.3538.67 (Official Build) (64-bit)
Revision 9ab0cfab84ded083718d3a4ff830726efd38869f-refs/branch-heads/3538@{#1002}
OS Windows 7 x64

Used test plan from brave/brave-core#676

image

Also verified in Fiddler.

Verification Passed on

Brave 0.56.8 Chromium: 70.0.3538.77 (Official Build) (64-bit)
Revision 0f6ce0b0cd63a12cb4eccea3637b1bc9a29148d9-refs/branch-heads/3538@{#1039}
OS Linux

image

@btlechowski btlechowski mentioned this issue Oct 19, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jumde jumde

Labels
audit-beta audit-release priority/P2 A bad problem. We might uplift this to the next planned release. privacy/connect This requires making a network connection to a third-party service. privacy QA Pass-Linux QA Pass-Win64 QA/Test-Plan-Specified QA/Yes
Projects
None yet
Milestone
0.55.x - Release (Release Channel)
Development

Successfully merging a pull request may close this issue.

Proxying requests for safe browsing client model through brave proxy brave/brave-core
5 participants
@diracdeltas @tildelowengrimm @jumde @srirambv @btlechowski