Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

newtab should use brave-ui #633

Closed
cezaraugusto opened this issue Jul 24, 2018 · 1 comment · Fixed by brave/brave-core#1339
Closed

newtab should use brave-ui #633

cezaraugusto opened this issue Jul 24, 2018 · 1 comment · Fixed by brave/brave-core#1339
Assignees
@cezaraugusto
Labels
feature/new-tab QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude
Milestone
0.60.x - Release ...

Comments

@cezaraugusto
Copy link
Contributor

cezaraugusto commented Jul 24, 2018 •
edited by bsclifton
Loading

Test plan

See brave/brave-core#1339

Description

Both private and default new tab should share components and match the same front-end structure
@cezaraugusto cezaraugusto self-assigned this Jul 24, 2018
@bbondy bbondy added this to the Backlog milestone Jul 26, 2018
This was referenced Oct 17, 2018
Closed
Closed
Closed
cezaraugusto added a commit to brave/brave-core that referenced this issue Jan 11, 2019
@cezaraugusto
refactor new tab page to use brave-ui
a74d34d 
close brave/brave-browser#633
@cezaraugusto cezaraugusto mentioned this issue Jan 11, 2019
Closed
cezaraugusto added a commit to brave/brave-core that referenced this issue Jan 11, 2019
@cezaraugusto
refactor new tab page to use brave-ui
d5f1d48 
close brave/brave-browser#633
cezaraugusto added a commit to brave/brave-core that referenced this issue Jan 14, 2019
@cezaraugusto
refactor new tab page to use brave-ui
2c8b25d 
close brave/brave-browser#633
@cezaraugusto cezaraugusto mentioned this issue Jan 14, 2019
Merged
@bsclifton bsclifton modified the milestones: 1.x Backlog, 0.60.x - Dev Jan 14, 2019
cezaraugusto added a commit to brave/brave-core that referenced this issue Jan 15, 2019
@cezaraugusto
refactor new tab page to use brave-ui
82fddb8 
close brave/brave-browser#633
@srirambv
Copy link
Contributor

srirambv commented Feb 12, 2019 •
edited by LaurenWags
Loading

Verification passed on

Brave 0.60.26 Chromium: 72.0.3626.96 (Official Build) beta(64-bit)
Revision 84098ee7ef8622a9defc2ef043cd8930b617b10e-refs/branch-heads/3626@{#836}
OS Linux

Verification passed on

Brave 0.60.28 Chromium: 72.0.3626.96 (Official Build) beta (64-bit)
Revision 84098ee7ef8622a9defc2ef043cd8930b617b10e-refs/branch-heads/3626@{#836}
OS Windows 7

Used test plan from brave/brave-core#1339.

Logged #3347.

633
633 b

Verified passed with

Brave 0.60.28 Chromium: 72.0.3626.96 (Official Build) beta(64-bit)
Revision 84098ee7ef8622a9defc2ef043cd8930b617b10e-refs/branch-heads/3626@{#836}
OS Mac OS X

@btlechowski btlechowski mentioned this issue Feb 13, 2019
Closed
@kjozwiak kjozwiak mentioned this issue Feb 15, 2019
Closed
@kjozwiak kjozwiak mentioned this issue Feb 22, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cezaraugusto cezaraugusto

Labels
feature/new-tab QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude
Projects
None yet
Milestone
0.60.x - Release (Release Channel)
Development

Successfully merging a pull request may close this issue.

refactor ntp to use brave-ui brave/brave-core
refactor ntp to use brave-ui brave/brave-core
7 participants
@bbondy @kjozwiak @cezaraugusto @bsclifton @srirambv @LaurenWags @btlechowski