Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brave crashes when opening the autoplay settings #17808

Closed
pitsi opened this issue Sep 1, 2021 · 21 comments · Fixed by brave/brave-core#9997
Closed

Brave crashes when opening the autoplay settings #17808

pitsi opened this issue Sep 1, 2021 · 21 comments · Fixed by brave/brave-core#9997

Comments

@pitsi
Copy link

pitsi commented Sep 1, 2021

Description

As mentioned in the title, brave crashes and exits completely when clicking on the autoplay settings under brave://settings/content.

Steps to Reproduce

  1. Go to settings > privacy and security > site and shield settings > additional permissions.
  2. Click autoplay.
  3. Watch brave crash.

Actual result:

Brave shouldn't crash and show the relevant submenu.

Expected result:

Brave crashes and has to be relaunched.

Reproduces how often:

Easily

Brave version (brave://version info)

Brave	1.29.76 Chromium: 93.0.4577.58 (Official Build) (64-bit)
Revision	c4410ece044414ea42fa4ba328d08195e818a99c-refs/branch-heads/4577@{#1076}
OS	Linux

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? No idea
  • Can you reproduce this issue with the nightly channel? No idea

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? Not related
  • Does the issue resolve itself when disabling Brave Rewards? Not related
  • Is the issue reproducible on the latest version of Chrome? Not reproducible because chrome lacks the autoplay as a setting in there.

Miscellaneous Information:

None.

@pitsi
Copy link
Author

pitsi commented Sep 1, 2021

Also confirmed on a w10 21h1 x64 installation of a friend.

@Tonev
Copy link
Contributor

Tonev commented Sep 1, 2021

Confirmed the issue in all Stable, Beta, and Nightly.

Brave 1.29.76 Chromium: 93.0.4577.58 (Official Build) (64-bit)
Revision c4410ece044414ea42fa4ba328d08195e818a99c-refs/branch-heads/4577@{#1076}
OS Windows 7 Service Pack 1 (Build 7601)
Brave 1.30.57 Chromium: 93.0.4577.58 (Official Build) beta (64-bit)
Revision c4410ece044414ea42fa4ba328d08195e818a99c-refs/branch-heads/4577@{#1076}
OS Windows 7 Service Pack 1 (Build 7601)
Brave 1.31.10 Chromium: 93.0.4577.58 (Official Build) nightly (64-bit)
Revision c4410ece044414ea42fa4ba328d08195e818a99c-refs/branch-heads/4577@{#1076}
OS Windows 7 Service Pack 1 (Build 7601)

Crash ID's:

Stable -> dfa36d58-6a5b-4a10-ba0d-f5dc66e79b5b
Beta -> d9ef3351-8bac-4b9c-95fe-e4d26884edf1
Nightly -> a53a36d2-ae81-4e3c-b2b1-4528c969d283

@onchov
Copy link

onchov commented Sep 3, 2021

Confirmed for:

Brave | 1.29.76 Chromium: 93.0.4577.58 (Official Build) (64-bit)
Revision | c4410ece044414ea42fa4ba328d08195e818a99c-refs/branch-heads/4577@{#1076}
OS | Linux

on 3 different Ubuntu-based machines.

Edit -- same issue in today's update build:

Brave | 1.29.77 Chromium: 93.0.4577.63 (Official Build) (64-bit)
Revision | ff5c0da2ec0adeaed5550e6c7e98417dac77d98a-refs/branch-heads/4577@{#1135}
OS | Linux

@Tonev
Copy link
Contributor

Tonev commented Sep 3, 2021

This issue is present in the latest update. I had hopes the Chromium upgrade might resolve the issue.

Brave 1.29.77 Chromium: 93.0.4577.63 (Official Build) (64-bit)
Revision ff5c0da2ec0adeaed5550e6c7e98417dac77d98a-refs/branch-heads/4577@{#1135}
OS Windows 7 Service Pack 1 (Build 7601)

CC: @bsclifton @rebron @iefremov

@Brave-Matt
Copy link

@rebron rebron added crash priority/P2 A bad problem. We might uplift this to the next planned release. labels Sep 3, 2021
@donbt09
Copy link

donbt09 commented Sep 3, 2021

I can confirmed Brave crashes when trying to turn off autoplay in settings
I'm running the latest stable version 1.29.77 Chromium: 93.0.4577.63 (Official Build) (64-bit) on Windows 10 21H1

@rebron
Copy link
Collaborator

rebron commented Sep 3, 2021

cc: @darkdh May need some help with this one.

@pitsi
Copy link
Author

pitsi commented Sep 4, 2021

If it helps, this is what brave outputs to the terminal the moment it crashes
/usr/bin/brave-browser: line 48: 5252 Trace/breakpoint trap "$HERE/brave" "$@"
I also upgraded to 1.29.77.

@mac-repo-001
Copy link

Confirmed on Windows 10 21H1 when trying to set Autoplay after first setup
Version 1.29.77 Chromium: 93.0.4577.63 (Official Build) (64-bit)

@darylsonnier
Copy link

Crash still happening in Brave Version 1.29.79 Chromium: 93.0.4577.63 (Official Build) (64-bit)
Windows 10 Pro 21H1, build 19043.1165/Windows Feature Experience Pack 120.2212.3530.0.

@pitsi
Copy link
Author

pitsi commented Sep 9, 2021

It still crashes on 1.29.79, so why was this closed? Can anyone on beta/dev/nightly confirm it was fixed for them?

Brave	1.29.79 Chromium: 93.0.4577.63 (Official Build) (64-bit)
Revision	ff5c0da2ec0adeaed5550e6c7e98417dac77d98a-refs/branch-heads/4577@{#1135}
OS	Linux

@yrliou
Copy link
Member

yrliou commented Sep 9, 2021

@pitsi @darylsonnier We close issues when they landed on nightly, uplifts to beta and release are created at brave/brave-core#10013 and brave/brave-core#10014, which is not yet landed. We'll update the issue milestone when it lands.

@pitsi
Copy link
Author

pitsi commented Sep 9, 2021

Thank you for the clarification. However, on another issue I had opened a few months ago (#16251), the bug was closed when the change reached stable.

@Tonev
Copy link
Contributor

Tonev commented Sep 9, 2021

Your other Github ticket was also closed on the same day the pull request was merged into Nightly. Github allows developers to use special words to link an issue to a pull request and close the issue once the pull request is merged, you can take a look over here - https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue.

@kjozwiak kjozwiak removed this from the 1.31.x - Nightly milestone Sep 9, 2021
@kjozwiak kjozwiak added this to the 1.29.x - Release #5 milestone Sep 9, 2021
@iefremov
Copy link
Contributor

iefremov commented Sep 9, 2021

does anyone have crash ids (aka Uploaded Crash Report ID: on brave://crashes) or backtrace URLs? I'd like to link dumps in backtrace to this issue @darkdh @Brave-Matt

@darylsonnier
Copy link

darylsonnier commented Sep 9, 2021

@iefremov, I can provide more if you'd like, but these are the three most recent crash IDs.

00e9067a-074c-4534-9b64-421f749a29fc

379eed82-3669-4e79-b4a7-ddf5feac7df9

8651aaf6-35a2-466f-a0fe-ec4e479cedd3

edit I'm pretty sure that all of the crashes I've had in this browser have been on autoplay. I cannot recall it crashing at any other time.

@Tonev
Copy link
Contributor

Tonev commented Sep 9, 2021

@iefremov

I provided some crash ID's earlier, believe I even sent via brave://crashes.

#17808 (comment)

@iefremov
Copy link
Contributor

iefremov commented Sep 9, 2021

Thanks a lot @darylsonnier @Tonev , that helped!

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Sep 13, 2021

Verification passed on

Brave | 1.29.80 Chromium: 93.0.4577.63 (Official Build) (64-bit)
-- | --
Revision | ff5c0da2ec0adeaed5550e6c7e98417dac77d98a-refs/branch-heads/4577@{#1135}
OS | Windows 10 OS Version 2009 (Build 19043.1165)

  • Verified the STR from the description
  • Reproduced the issue in the version 1.29.79
  • Verified in both clean and upgraded profile and confirmed that the issue is fixed and working fine in 1.29.80

Verification passed on

Brave 1.29.80 Chromium: 93.0.4577.63 (Official Build) (64-bit)
Revision ff5c0da2ec0adeaed5550e6c7e98417dac77d98a-refs/branch-heads/4577@{#1135}
OS Ubuntu 18.04 LTS
  • Verified the STR from the description. No crash.
  • Verified in both clean and upgraded profile and confirmed that the issue is fixed and working fine in 1.29.80

Verification PASSED on macOS 11.5.2 x64 using the following build:

Brave | 1.29.80 Chromium: 93.0.4577.63 (Official Build) (x86_64)
--- | ---
Revision | ff5c0da2ec0adeaed5550e6c7e98417dac77d98a-refs/branch-heads/4577@{#1135}
OS | macOS Version 11.5.2 (Build 20G95)

Autoplay Test Cases

Crash

  • opened brave://settings/content/autoplay and ensured that Brave didn't crash (waiting ~30s as well)

Site details

Screen Shot 2021-09-13 at 12 17 59 PM

Ethereum request

Crash

  • enabled native ethereum wallet via brave://flags/#native-brave-wallet and restarted brave
  • opened brave://settings/content/ethereum and ensured that Brave didn't crash (waiting ~30s as well)

Site details

Example Disabled Example Enabled
Screen Shot 2021-09-13 at 12 17 59 PM Screen Shot 2021-09-13 at 12 21 35 PM

@Tonev
Copy link
Contributor

Tonev commented Sep 15, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment