Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chunk of whitespace in middle of article #18280

Closed
stephendonner opened this issue Sep 22, 2021 · 2 comments · Fixed by brave/brave-core#10238
Closed

Chunk of whitespace in middle of article #18280

stephendonner opened this issue Sep 22, 2021 · 2 comments · Fixed by brave/brave-core#10238

Comments

@stephendonner
Copy link

Description

Chunk of whitespace in middle of article

Steps to Reproduce

  1. new profile
  2. launch Brave
  3. load https://www.cbsnews.com/news/gabby-petito-body-found-wyoming-confirmed-ruled-homicide/
  4. click to enable Speedreader, in the URL bar
  5. scroll down the page a bit after it reloads

Actual result:

Chunk of whitespace

Screen Shot 2021-09-22 at 9 41 50 AM

Expected result:

No chunk of whitespace

Reproduces how often:

100%

Brave version (brave://version info)

Brave 1.32.9 Chromium: 94.0.4606.54 (Official Build) nightly (x86_64)
Revision c8191a1d5cccbf64e8fe7269043f8ace8d74dd05-refs/branch-heads/4606@{#1130}
OS macOS Version 11.6 (Build 20G165)

/cc @keur

@kkuehlz
Copy link
Contributor

kkuehlz commented Sep 23, 2021

Issue is due to srcset=srcset="data:image/svg+xml,%3Csvg%20xmlns%3D'http%3A%2F%2Fwww.w3.org%2F2000%2Fsvg'%20viewBox%3D'0%200%20620%20366'%2F%3E" and Speedreader is not throwing out bad srcsets.

@stephendonner
Copy link
Author

Verified PASSED using

Brave 1.32.20 Chromium: 94.0.4606.54 (Official Build) nightly (x86_64)
Revision c8191a1d5cccbf64e8fe7269043f8ace8d74dd05-refs/branch-heads/4606@{#1130}
OS macOS Version 11.6 (Build 20G165)

Steps:

  1. new profile
  2. launch Brave
  3. load https://www.cbsnews.com/news/gabby-petito-body-found-wyoming-confirmed-ruled-homicide/
  4. click to enable Speedreader, in the URL bar
  5. scroll down the page a bit after it reloads

Confirm there's now an image where the blank space used to be.

Screen Shot 2021-09-24 at 11 26 57 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment