Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MacOS] Do not override notifications to alerts for the browser app. #18345

Closed
mkarolin opened this issue Sep 24, 2021 · 3 comments · Fixed by brave/brave-core#10237
Closed

[MacOS] Do not override notifications to alerts for the browser app. #18345

mkarolin opened this issue Sep 24, 2021 · 3 comments · Fixed by brave/brave-core#10237
Assignees
@mkarolin
Labels
OS/Desktop OS/macOS QA Pass-macOS QA/Test-Plan-Specified QA/Yes release-notes/exclude
Milestone
1.30.x - Release

Comments

@mkarolin
Copy link
Contributor

mkarolin commented Sep 24, 2021 •
edited
Loading

As part of the fix for brave/brave-core#3850, we ended up tweaking .plist for the browser app to use alert notifications (rather than banner).

This doesn't appear to be needed any more, so we can remove tweaking of .plists and get in sync with Chromium: main app shows banners and Alerts Helper (previously XPC service) shows alerts.

Testing:

  1. MacOS notifications prompts on fresh install and upgrade
  • Fresh install should show 2 prompts
  • Upgrade may show either one or zero prompts (depending on if the older version had 1 or 2 prompts when installed)
  1. Ad notifications on fresh install and upgrade (@tmancey, please update this part as necessary)
@mkarolin mkarolin self-assigned this Sep 24, 2021
@mkarolin mkarolin mentioned this issue Sep 24, 2021
Merged
24 tasks
@tmancey tmancey mentioned this issue Sep 27, 2021
Closed
@mkarolin mkarolin added this to the 1.32.x - Nightly milestone Sep 27, 2021
This was referenced Sep 27, 2021
Merged
Merged
@kjozwiak kjozwiak mentioned this issue Sep 27, 2021
Closed
@kjozwiak
Copy link
Member

@brave/legacy_qa we'll use this issue to add our verification notes but if you would like more information/context regarding the the problem, please take a look at #18276 where @LaurenWags added some cases/screenshots. We'll be running through the cases that @tmancey provided via brave/brave-core#10237 (comment).

@kjozwiak
Copy link
Member

kjozwiak commented Sep 28, 2021 •
edited by LaurenWags
Loading

Verification PASSED on macOS 11.6 x64 using the following build:

Brave | 1.30.86 Chromium: 94.0.4606.61 (Official Build) (x86_64)
--- | ---
Revision | 418b78f5838ed0b1c69bb4e51ea0252171854915-refs/branch-heads/4606@{#1204}
OS | macOS Version 11.6 (Build 20G165)

Went through and verified the STR/Cases outlined via brave/brave-core#10237 (comment) as per the following:

Test Case #1 (Upgrade 0.70.123 --> 1.30.86 - pre #6466)

Brave | 0.70.123 Chromium: 78.0.3904.97 (Official Build) (64-bit)
--- | ---
Revision | 021b9028c246d820be17a10e5b393ee90f41375e-refs/branch-heads/3904@{#859}
OS | macOS Version 10.16 (Build 20G165)
  • ensured that two notification prompts are being shown when launching 0.70.123 Chromium: 78.0.3904.97
  • checked Notifications under System Preferences and ensured one is for Alerts and the other is for Banners permissions
  • visited https://www.bennish.net/web-notifications.html and ensured that the web notifications dismiss after 5s

NOTE:: You won't be able to check ad notifications while on 0.70.123 Chromium: 78.0.3904.97 as that's been disabled/not working via server side.

Before Upgrading

Example Example Example
Screen Shot 2021-09-28 at 12 30 43 AM Screen Shot 2021-09-28 at 12 31 08 AM Screen Shot 2021-09-28 at 12 34 10 AM
  • replace 0.70.123 Chromium: 78.0.3904.97 with 1.30.86 Chromium: 94.0.4606.61
  • re-launch Brave and you shouldn't see any notification permission prompts (Alerts & Banners already in Notifications)
  • visited https://www.bennish.net/web-notifications.html and ensured that the web notifications dismiss after 5s
  • triggered an ad notification and ensured that it's dismissed after 2mins (120s timeout)
[3465:259:0928/005604.532435:VERBOSE1:ads_impl.cc(204)] Browser state changed to idle
[3465:259:0928/005656.575606:VERBOSE1:ads_impl.cc(221)] Browser state changed to unidle after 56 s
[3465:259:0928/005656.581381:VERBOSE1:eligible_ad_notifications.cc(90)] Get eligible ads for parent-child segments:
[3465:259:0928/005656.581465:VERBOSE1:eligible_ad_notifications.cc(92)]   technology & computing-software
[3465:259:0928/005656.581508:VERBOSE1:eligible_ad_notifications.cc(92)]   technology & computing-technology & computing
[3465:259:0928/005656.581548:VERBOSE1:eligible_ad_notifications.cc(92)]   personal finance-personal finance
[3465:259:0928/005656.594164:VERBOSE2:ad_pacing_util.h(23)] Pacing delivery for creative instance id e026e947-ec19-47e6-8c5b-4e4408d91198 [Roll(0.764781):0.931497]
[3465:259:0928/005656.594229:VERBOSE2:ad_pacing_util.h(23)] Pacing delivery for creative instance id 0fc9ea04-5b12-4f79-b9b2-830c784799f3 [Roll(0.764781):0.842398]
[3465:259:0928/005656.594265:VERBOSE2:ad_priority.h(32)] 11 ads with a priority of 1 in bucket 1
[3465:259:0928/005656.594669:VERBOSE1:ad_notification_serving.cc(126)] Found 11 eligible ads
[3465:259:0928/005656.594717:VERBOSE1:ad_notification_serving.cc(222)] Serving ad notification:
  uuid: 12523ed2-40d3-49b5-abfc-a7351d3d6c8c
  creativeInstanceId: f1126b98-761f-4092-a067-28928809ab25
  creativeSetId: 755e6092-854b-4722-9c34-fa5bdd62565d
  campaignId: 091c9617-cbfd-4087-8219-10d791e42a2d
  advertiserId: fc06e101-e5bc-44dd-8c89-77958f7ea53d
  segment: technology & computing-software
  title: Coinsmart.com/bravecrypto
  body: Buying BTC with CAD? Try CoinSmart & get free $30 in BTC
  targetUrl: https://www.coinsmart.com/bravecrypto/
[3465:259:0928/005656.595118:VERBOSE1:ads_service_impl.cc(1971)] Timeout ad notification with uuid 12523ed2-40d3-49b5-abfc-a7351d3d6c8c in 120 seconds

After Upgrading

Example Example Example
Screen Shot 2021-09-28 at 12 40 21 AM Screen Shot 2021-09-28 at 12 40 14 AM Screen Shot 2021-09-28 at 12 42 51 AM

Test Case #2 (Upgrade from C93 --> C94)

Brave | 1.29.81 Chromium: 93.0.4577.82 (Official Build) (x86_64)
--- | ---
Revision | e3a25d9b9e2d0b728e045ec87c0aa4942aa46e4e-refs/branch-heads/4577@{#1237}
OS | macOS Version 11.6 (Build 20G165)
  • ensured that a single notification prompts is being shown when launching 1.29.81 Chromium: 93.0.4577.82
  • checked Notifications under System Preferences ensured that the Alerts permission is being listed
  • visited https://www.bennish.net/web-notifications.html and ensured that the web notifications dismiss after 5s
  • triggered an ad notification and ensured that it's dismissed after 2mins (120s timeout)
[2956:259:0928/000423.059584:VERBOSE1:ads_service_impl.cc(1971)] Timeout ad notification with uuid 27a8195b-ce5f-4cf9-b138-a77d368d8f61 in 120 seconds

Before Upgrading

Example Example Example Example
Screen Shot 2021-09-27 at 11 30 32 PM Screen Shot 2021-09-27 at 11 30 52 PM Screen Shot 2021-09-27 at 11 48 24 PM Screen Shot 2021-09-27 at 11 50 18 PM
  • re-launched Brave using --update-feed-url=https://updates.bravesoftware.com/sparkle/Brave-Browser/test/appcast.xml
  • upgraded to 1.30.86 Chromium: 94.0.4606.61 and ensured that a single permission notification request appeared
  • checked Notifications under System Preferences ensured that the Banners permission is being listed alongside Alerts
  • visited https://www.bennish.net/web-notifications.html and ensured that the web notifications dismiss after 5s
  • triggered an ad notification and ensured that it's dismissed after 2mins (120s timeout)
[2956:259:0928/001644.813654:VERBOSE1:ads_service_impl.cc(1971)] Timeout ad notification with uuid 66e05d08-ae64-490f-b044-2121d3aeb4c1 in 120 seconds
  • ensured that clicking on ad notifications works as expected
[2956:259:0928/001643.794027:VERBOSE1:ads_impl.cc(204)] Browser state changed to idle
[2956:259:0928/001644.795699:VERBOSE1:ads_impl.cc(221)] Browser state changed to unidle after 5 s
[2956:259:0928/001644.800567:VERBOSE1:eligible_ad_notifications.cc(90)] Get eligible ads for parent-child segments:
[2956:259:0928/001644.800634:VERBOSE1:eligible_ad_notifications.cc(92)]   technology & computing-software
[2956:259:0928/001644.800683:VERBOSE1:eligible_ad_notifications.cc(92)]   business-marketing
[2956:259:0928/001644.800726:VERBOSE1:eligible_ad_notifications.cc(92)]   personal finance-personal finance
[2956:259:0928/001644.812676:VERBOSE2:ad_pacing_util.h(23)] Pacing delivery for creative instance id e026e947-ec19-47e6-8c5b-4e4408d91198 [Roll(0.764674):0.940787]
[2956:259:0928/001644.812733:VERBOSE2:ad_priority.h(32)] 14 ads with a priority of 1 in bucket 1
[2956:259:0928/001644.813235:VERBOSE1:ad_notification_serving.cc(126)] Found 14 eligible ads
[2956:259:0928/001644.813304:VERBOSE1:ad_notification_serving.cc(222)] Serving ad notification:
  uuid: 66e05d08-ae64-490f-b044-2121d3aeb4c1
  creativeInstanceId: 42f4d6c8-6056-4c5c-a821-6c471a2809ba
  creativeSetId: 5492cf86-e74e-41e3-9e63-2d8b2a31884b
  campaignId: aadf3903-cc96-4673-96d6-a0ef9fc95c0f
  advertiserId: 8ca6dfad-899b-4693-a3dd-0c4a0a2b4dc7
  segment: technology & computing-software
  title: Heatbit
  body: Electric heater that makes you money by mining bitcoin
  targetUrl: https://heatbit.com/brave
[2956:259:0928/001644.813654:VERBOSE1:ads_service_impl.cc(1971)] Timeout ad notification with uuid 66e05d08-ae64-490f-b044-2121d3aeb4c1 in 120 seconds

After Upgrading

Example Example Example Example
Screen Shot 2021-09-27 at 11 57 35 PM Screen Shot 2021-09-27 at 11 57 49 PM Screen Shot 2021-09-27 at 11 58 34 PM Screen Shot 2021-09-28 at 12 04 34 AM

Test Case #3 (Clean Install)

Brave | 1.30.86 Chromium: 94.0.4606.61 (Official Build) (x86_64)
--- | ---
Revision | 418b78f5838ed0b1c69bb4e51ea0252171854915-refs/branch-heads/4606@{#1204}
OS | macOS Version 11.6 (Build 20G165)
  • ensured that two notification prompts are being shown when launching 1.30.86 Chromium: 94.0.4606.61
  • checked Notifications under System Preferences and ensured one is for Alerts and the other is for Banners permissions
  • visited https://www.bennish.net/web-notifications.html and ensured that the web notifications dismiss after 5s
  • triggered an ad notification and ensured that it's dismissed after 2mins (120s timeout)
[2179:259:0927/232031.899662:VERBOSE1:ads_service_impl.cc(1971)] Timeout ad notification with uuid 444b6d47-0742-4174-bde3-3dd5037fb94a in 120 seconds
  • ensured that clicking on ad notifications works as expected
[2179:259:0927/232031.889084:VERBOSE1:eligible_ad_notifications.cc(90)] Get eligible ads for parent-child segments:
[2179:259:0927/232031.889156:VERBOSE1:eligible_ad_notifications.cc(92)]   technology & computing-software
[2179:259:0927/232031.889200:VERBOSE1:eligible_ad_notifications.cc(92)]   technology & computing-technology & computing
[2179:259:0927/232031.889263:VERBOSE1:eligible_ad_notifications.cc(92)]   personal finance-personal finance
[2179:259:0927/232031.898874:VERBOSE2:ad_priority.h(32)] 15 ads with a priority of 1 in bucket 1
[2179:259:0927/232031.899231:VERBOSE1:ad_notification_serving.cc(126)] Found 15 eligible ads
[2179:259:0927/232031.899271:VERBOSE1:ad_notification_serving.cc(222)] Serving ad notification:
  uuid: 444b6d47-0742-4174-bde3-3dd5037fb94a
  creativeInstanceId: 9fed67e0-5fe2-4682-b147-e5b1ff26c58d
  creativeSetId: e3fa4776-d529-4ae9-9c6e-7741232ee1df
  campaignId: 399a5816-33b9-4167-b7c6-d8783ed9ddd8
  advertiserId: b6d581f3-cf2c-4422-a43c-75d4a675fe58
  segment: technology & computing-software
  title: Bitbuy - Canada's #1 Platform
  body: Wow! Get $20 free when you make your first deposit
  targetUrl: https://bitbuy.ca/en/sign-up/?c=Brave
[2179:259:0927/232031.899662:VERBOSE1:ads_service_impl.cc(1971)] Timeout ad notification with uuid 444b6d47-0742-4174-bde3-3dd5037fb94a in 120 seconds
Example Example Example Example
Screen Shot 2021-09-27 at 10 56 10 PM Screen Shot 2021-09-27 at 10 56 48 PM Screen Shot 2021-09-27 at 11 04 30 PM Screen Shot 2021-09-27 at 11 06 13 PM

@LaurenWags
Copy link
Member

LaurenWags commented Sep 28, 2021 •
edited
Loading

Verification PASSED on macOS 10.15.7 x64 using the following build:

Brave	1.30.86 Chromium: 94.0.4606.61 (Official Build) (x86_64)
Revision	418b78f5838ed0b1c69bb4e51ea0252171854915-refs/branch-heads/4606@{#1204}
OS	macOS Version 10.15.7 (Build 19H1417)

Went through and verified the STR/Cases outlined via brave/brave-core#10237 (comment) as per the following:

Test Case #1 (Upgrade 0.70.123 --> 1.30.86 - pre #6466)

Brave	0.70.123 Chromium: 78.0.3904.97 (Official Build) (64-bit)
Revision	021b9028c246d820be17a10e5b393ee90f41375e-refs/branch-heads/3904@{#859}
OS	macOS Version 10.15.7 (Build 19H1417)
  • ensured that two notification prompts are being shown when launching 0.70.123 Chromium: 78.0.3904.97
  • checked Notifications under System Preferences and ensured one is for Alerts and the other is for Banners permissions
  • visited https://www.bennish.net/web-notifications.html and ensured that the web notifications dismiss after 5s

NOTE:: You won't be able to check ad notifications while on 0.70.123 Chromium: 78.0.3904.97 as that's been disabled/not working via server side.

Before Upgrading

Example Example Example
Screen Shot 2021-09-28 at 7 50 11 AM Screen Shot 2021-09-28 at 7 50 50 AM Screen Shot 2021-09-28 at 7 52 31 AM
  • replace 0.70.123 Chromium: 78.0.3904.97 with 1.30.86 Chromium: 94.0.4606.61 (note, if I remove 0.70.123 prior to adding 1.30.86, I do get a prompt, but in the case where I replace without removing 0.70.123 first, there is no prompt)
  • re-launch Brave and you shouldn't see any notification permission prompts (Alerts & Banners already in Notifications)
  • visited https://www.bennish.net/web-notifications.html and ensured that the web notifications dismiss after 5s
  • triggered an ad notification and ensured that it's dismissed after 2mins (120s timeout)
[3557:775:0928/082135.372010:VERBOSE1:ad_notification_serving.cc(222)] Serving ad notification:
  uuid: 09abf462-04e6-4f9f-9c9a-772a95178f62
  creativeInstanceId: 73641e75-0997-4beb-9e2f-322885bea546
  creativeSetId: 190438f1-9efd-48b2-b6d1-5bbf5ccdefd9
  campaignId: 40063661-363b-4d07-8c8e-170635d07061
  advertiserId: 1adefe16-813c-49e5-8c6f-788dfc269b83
  segment: untargeted
  title: LendingTree - 1.93% APR
  body: Still considering refinancing? 15-yr fixed $400,000
  targetUrl: https://splitter.lendingtree.com/api/split?id=mortgage&rcode=10000&loan-type=refinance&cname=PushNotification&cmethod=Brave_LT_15yr_Considering_PushNoti&esourceid=6472256&csource=brave&cchannel=display&cproduct=mortgage&mtaid=D4F64
[3557:775:0928/082135.372044:VERBOSE9:client.cc(573)] Saving client state
[3557:775:0928/082135.372189:VERBOSE9:ad_notifications.cc(381)] Saving ad notifications state
[3557:775:0928/082135.372453:VERBOSE1:ads_service_impl.cc(1971)] Timeout ad notification with uuid 09abf462-04e6-4f9f-9c9a-772a95178f62 in 120 seconds

After Upgrading

Example Example Example
Screen Shot 2021-09-28 at 8 19 09 AM Screen Shot 2021-09-28 at 8 19 35 AM Screen Shot 2021-09-28 at 8 21 42 AM

Test Case #2 (Upgrade from C93 --> C94)

Brave | 1.29.81 Chromium: 93.0.4577.82 (Official Build) (x86_64)
-- | --
Revision | e3a25d9b9e2d0b728e045ec87c0aa4942aa46e4e-refs/branch-heads/4577@{#1237}
OS | macOS Version 10.15.7 (Build 19H1417)
  • ensured that a single notification prompts is being shown when launching 1.29.81 Chromium: 93.0.4577.82
  • checked Notifications under System Preferences ensured that the Alerts permission is being listed
  • visited https://www.bennish.net/web-notifications.html and ensured that the web notifications dismiss after 5s
  • triggered an ad notification and ensured that it's dismissed after 2mins (120s timeout)
[3772:775:0928/084335.469984:VERBOSE1:ads_service_impl.cc(1898)] Timeout ad notification with uuid 52568058-561f-46dd-9302-12c331926058 in 120 seconds

Before Upgrading

Example Example Example Example
Screen Shot 2021-09-28 at 8 41 53 AM Screen Shot 2021-09-28 at 8 42 31 AM Screen Shot 2021-09-28 at 8 42 57 AM Screen Shot 2021-09-28 at 8 43 47 AM
  • re-launched Brave using --update-feed-url=https://updates.bravesoftware.com/sparkle/Brave-Browser/test/appcast.xml
  • upgraded to 1.30.86 Chromium: 94.0.4606.61 and ensured that a single permission notification request appeared
  • checked Notifications under System Preferences ensured that the Banners permission is being listed alongside Alerts
  • visited https://www.bennish.net/web-notifications.html and ensured that the web notifications dismiss after 5s
  • triggered an ad notification and ensured that it's dismissed after 2mins (120s timeout)
[3969:775:0928/085000.076645:VERBOSE1:ads_service_impl.cc(1971)] Timeout ad notification with uuid 05a11644-211d-4df8-9766-b1acf3452fb3 in 120 seconds
  • ensured that clicking on ad notifications works as expected
[3969:775:0928/085615.948201:VERBOSE1:ads_service_impl.cc(1092)] Cancelled timeout for ad notification with uuid 6232d2f4-deb0-4852-91df-181c46e4d861
[3969:775:0928/085616.046586:VERBOSE3:ad_notification_event_clicked.cc(26)] Clicked ad notification with uuid 6232d2f4-deb0-4852-91df-181c46e4d861 and creative instance id 3fc73f4f-3a37-4c9b-b81f-25b0d032bf09
[3969:775:0928/085616.046697:VERBOSE9:ad_notifications.cc(381)] Saving ad notifications state
[3969:775:0928/085616.047011:VERBOSE9:client.cc(573)] Saving client state
[3969:775:0928/085616.047126:VERBOSE1:confirmations.cc(91)] Confirming click ad for creative instance id 3fc73f4f-3a37-4c9b-b81f-25b0d032bf09
[3969:775:0928/085616.050249:VERBOSE9:confirmations_state.cc(103)] Saving confirmations state
[3969:775:0928/085616.052019:VERBOSE1:redeem_unblinded_token.cc(51)] Redeem unblinded token
[3969:775:0928/085616.052108:VERBOSE1:redeem_unblinded_token.cc(65)] CreateConfirmation
[3969:775:0928/085616.052162:VERBOSE2:redeem_unblinded_token.cc(66)] POST /v1/confirmation/{confirmation_id}/{credential}
[3969:775:0928/085616.052218:VERBOSE5:redeem_unblinded_token.cc(70)] URL Request:
  URL: https://ads-serve.brave.com/v1/confirmation/653f..........
  Content: {"blindedPaymentToken":"OO/PvfmifWze+5LbFp2RK71f2buM3uVNSYK2xBIkNls=","buildChannel":"release","countryCode":"US","creativeInstanceId":"3fc73f4f-3a37-4c9b-b81f-25b0d032bf09","payload":{},"platform":"macos","studies":[{"group":"ExcludeAdIfWithinTimeWindow=0h","name":"BraveAds.FrequencyCappingStudy"},{"group":"Triggers=EMPTY/Threshold=0.0/IdleTimeThreshold=5","name":"BraveAds.UserActivityStudy"}],"type":"click"}
  Content Type: application/json
  Method: kPost
[3969:775:0928/085616.062933:VERBOSE1:epsilon_greedy_bandit_processor.cc(157)] Epsilon greedy bandit arm was updated for business segment
[3969:775:0928/085616.063020:VERBOSE1:epsilon_greedy_bandit_processor.cc(107)] Epsilon greedy bandit processed kClicked
[3969:775:0928/085616.066038:VERBOSE9:ad_notifications.cc(395)] Successfully saved ad notifications state
[3969:775:0928/085616.070301:VERBOSE1:ad_notification_event_clicked.cc(38)] Successfully logged ad notification clicked event
[3969:775:0928/085616.073670:VERBOSE9:client.cc(587)] Successfully saved client state
[3969:775:0928/085616.090866:VERBOSE9:confirmations_state.cc(113)] Successfully saved confirmations state
[3969:775:0928/085616.210251:VERBOSE1:redeem_unblinded_token.cc(83)] OnCreateConfirmation
[3969:775:0928/085616.210439:VERBOSE6:redeem_unblinded_token.cc(85)] URL Response:
  URL: https://ads-serve.brave.com/v1/confirmation/653f..........
  Response Status Code: 201
  Response: {"id":"653f8993-ad30-4a37-b0c0-2fe1c82b9636","payload":{},"createdAt":"2021-09-28T12:56:16.242Z","type":"click","modifiedAt":"2021-09-28T12:56:16.242Z","creativeInstanceId":"3fc73f4f-3a37-4c9b-b81f-25b0d032bf09"}
[3969:775:0928/085616.210613:VERBOSE1:redeem_unblinded_token.cc(113)] FetchPaymentToken
[3969:775:0928/085616.210652:VERBOSE2:redeem_unblinded_token.cc(114)] GET /v1/confirmation/{confirmation_id}/paymentToken
[3969:775:0928/085616.210690:VERBOSE5:redeem_unblinded_token.cc(118)] URL Request:
  URL: https://ads-serve.brave.com/v1/confirmation/653f8993-ad30-4a37-b0c0-2fe1c82b9636/paymentToken
  Method: kGet
[3969:775:0928/085616.324770:VERBOSE1:redeem_unblinded_token.cc(129)] OnFetchPaymentToken
[3969:775:0928/085616.324846:VERBOSE6:redeem_unblinded_token.cc(131)] URL Response:
  URL: https://ads-serve.brave.com/v1/confirmation/653f8993-ad30-4a37-b0c0-2fe1c82b9636/paymentToken
  Response Status Code: 200
  Response: {"id":"653f8.........
[3969:775:0928/085616.325520:VERBOSE1:confirmations.cc(251)] Successfully redeemed unblinded token with confirmation id 653f8993-ad30-4a37-b0c0-2fe1c82b9636, creative instance id 3fc73f4f-3a37-4c9b-b81f-25b0d032bf09 and click

After Upgrading

Example Example Example Example
Screen Shot 2021-09-28 at 8 48 18 AM Screen Shot 2021-09-28 at 8 48 37 AM Screen Shot 2021-09-28 at 8 49 00 AM Screen Shot 2021-09-28 at 8 56 14 AM

Test Case #3 (Clean Install)

Brave	1.30.86 Chromium: 94.0.4606.61 (Official Build) (x86_64)
Revision	418b78f5838ed0b1c69bb4e51ea0252171854915-refs/branch-heads/4606@{#1204}
OS	macOS Version 10.15.7 (Build 19H1417)
  • ensured that two notification prompts are being shown when launching 1.30.86 Chromium: 94.0.4606.61
  • checked Notifications under System Preferences and ensured one is for Alerts and the other is for Banners permissions
  • visited https://www.bennish.net/web-notifications.html and ensured that the web notifications dismiss after 5s
  • triggered an ad notification and ensured that it's dismissed after 2mins (120s timeout)
[4183:775:0928/090759.966311:VERBOSE1:ads_service_impl.cc(1971)] Timeout ad notification with uuid 1c502dab-9f48-43b2-a08e-fa120ce34818 in 120 seconds
  • ensured that clicking on ad notifications works as expected
[4183:775:0928/091419.428535:VERBOSE1:ads_service_impl.cc(1092)] Cancelled timeout for ad notification with uuid 759f20ec-cf0d-413e-8ee3-8c763cdba2d3
[4183:775:0928/091419.518291:VERBOSE3:ad_notification_event_clicked.cc(26)] Clicked ad notification with uuid 759f20ec-cf0d-413e-8ee3-8c763cdba2d3 and creative instance id 30c04fd0-0dad-46fb-899a-f0696b0813c7
[4183:775:0928/091419.518423:VERBOSE9:ad_notifications.cc(381)] Saving ad notifications state
[4183:775:0928/091419.521763:VERBOSE9:client.cc(573)] Saving client state
[4183:775:0928/091419.521858:VERBOSE1:confirmations.cc(91)] Confirming click ad for creative instance id 30c04fd0-0dad-46fb-899a-f0696b0813c7
[4183:775:0928/091419.525748:VERBOSE9:confirmations_state.cc(103)] Saving confirmations state
[4183:775:0928/091419.528835:VERBOSE1:redeem_unblinded_token.cc(51)] Redeem unblinded token
[4183:775:0928/091419.528932:VERBOSE1:redeem_unblinded_token.cc(65)] CreateConfirmation
[4183:775:0928/091419.528997:VERBOSE2:redeem_unblinded_token.cc(66)] POST /v1/confirmation/{confirmation_id}/{credential}
[4183:775:0928/091419.529053:VERBOSE5:redeem_unblinded_token.cc(70)] URL Request:
  URL: https://ads-serve.brave.com/v1/confirmation/7e8a8........
  Content: {"blindedPaymentToken":"Og3l2SmaHjb746lBZ6TOR7jxWo9vf2RmHdTZlQWb9DE=","buildChannel":"release","countryCode":"US","creativeInstanceId":"30c04fd0-0dad-46fb-899a-f0696b0813c7","payload":{},"platform":"macos","studies":[],"type":"click"}
  Content Type: application/json
  Method: kPost
[4183:775:0928/091419.529259:VERBOSE7:redeem_unblinded_token.cc(71)]   Headers:
accept: application/json
[4183:775:0928/091419.529757:ERROR:CONSOLE(1)] "[Shields]: Can't request shields panel data for tabId: 7.  Error: No tab url specified", source: chrome-extension://mnojpmjdmbbfmejpflffifhffcmidifd/out/brave_extension_background.bundle.js (1)
[4183:775:0928/091419.541568:VERBOSE1:epsilon_greedy_bandit_processor.cc(143)] Epsilon greedy bandit arm was not found for untargeted segment
[4183:775:0928/091419.542410:VERBOSE1:epsilon_greedy_bandit_processor.cc(107)] Epsilon greedy bandit processed kClicked
[4183:775:0928/091419.929334:VERBOSE1:redeem_unblinded_token.cc(83)] OnCreateConfirmation
[4183:775:0928/091419.929930:VERBOSE6:redeem_unblinded_token.cc(85)] URL Response:
  URL: https://ads-serve.brave.com/v1/confirmation/7e8a8.........
[4183:775:0928/091419.930109:VERBOSE1:redeem_unblinded_token.cc(113)] FetchPaymentToken
[4183:775:0928/091419.930145:VERBOSE2:redeem_unblinded_token.cc(114)] GET /v1/confirmation/{confirmation_id}/paymentToken
[4183:775:0928/091419.930179:VERBOSE5:redeem_unblinded_token.cc(118)] URL Request:
  URL: https://ads-serve.brave.com/v1/confirmation/7e8a8bec-3d14-4555-b386-ccc7bcd679d3/paymentToken
  Method: kGet
[4183:775:0928/091419.930213:VERBOSE7:redeem_unblinded_token.cc(119)]   Headers:
[4183:775:0928/091420.259506:VERBOSE1:redeem_unblinded_token.cc(129)] OnFetchPaymentToken
[4183:775:0928/091420.259621:VERBOSE6:redeem_unblinded_token.cc(131)] URL Response:
  URL: https://ads-serve.brave.com/v1/confirmation/7e8a8bec-3d14-4555-b386-ccc7bcd679d3/paymentToken
  Response Status Code: 200
  Response: {"id":"7e8a8bec-3d14-4555-b386-ccc7bcd679d3","createdAt":"2021-09-28T13:14:19.914Z","type":"click","modifiedAt":"2021-09-28T13:14:19.925Z","creativeInstanceId":"30c04fd0-0dad-46fb-899a-f0696b0813c7","paymentToken":{"publicKey":"uor3AzFj4OmdCxwetsYD1TxPXZSw40t3j/VOCUyC7Rs=","batchProof":"8sP83EyXODFD/kGuDU9D8E3jRKvD5SN8rPDehmcjLg4/ycWy8vF6h/fc0y44y3nFbPjfKhUXKJFKZlo7wNm5Cg==","signedTokens":["fhUZyPzqm2DCKJ6UtOUOtGKUEBC2p0v6/VSrwwqknwU="]}}
[4183:775:0928/091420.260271:VERBOSE1:confirmations.cc(251)] Successfully redeemed unblinded token with confirmation id 7e8a8bec-3d14-4555-b386-ccc7bcd679d3, creative instance id 30c04fd0-0dad-46fb-899a-f0696b0813c7 and click
Example Example Example Example
Screen Shot 2021-09-28 at 9 06 32 AM Screen Shot 2021-09-28 at 9 06 53 AM Screen Shot 2021-09-28 at 9 07 18 AM Screen Shot 2021-09-28 at 9 14 17 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mkarolin mkarolin

Labels
OS/Desktop OS/macOS QA Pass-macOS QA/Test-Plan-Specified QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.30.x - Release
Development

Successfully merging a pull request may close this issue.

Don't tweak NSUserNotificationAlertStyle key. brave/brave-core
3 participants
@kjozwiak @LaurenWags @mkarolin