Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't tweak NSUserNotificationAlertStyle key. (uplift to 1.31.x) #10267

Merged
merged 1 commit into from
Sep 27, 2021
Merged

Don't tweak NSUserNotificationAlertStyle key. (uplift to 1.31.x) #10267

merged 1 commit into from
Sep 27, 2021

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Sep 27, 2021 •
edited by kjozwiak
Loading

Fixes brave/brave-browser#18345
Uplift of #10237

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from a team September 27, 2021 14:11
@brave-builds brave-builds self-assigned this Sep 27, 2021
@brave-builds brave-builds added this to the 1.31.x - Beta milestone Sep 27, 2021
@mkarolin mkarolin added CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-linux labels Sep 27, 2021
@mkarolin mkarolin force-pushed the pr10237_maxk-fix-tweak-info-plist_1.31.x branch from 6a03297 to dce985a Compare September 27, 2021 15:22
kjozwiak
kjozwiak approved these changes Sep 27, 2021
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.31.x approved after deliberating with @brave/uplift-approvers. @tmancey verified the PR on Nightly as per #10237 (comment). @LaurenWags and myself also ran through the cases with @tmancey via a Zoom call 👍 There's no point in QA running through this again on Nightly. We'll get it verified in the 1.30.x RC.

@kjozwiak kjozwiak merged commit e0186b5 into 1.31.x Sep 27, 2021
@kjozwiak kjozwiak deleted the pr10237_maxk-fix-tweak-info-plist_1.31.x branch September 27, 2021 19:48
@kjozwiak kjozwiak mentioned this pull request Sep 27, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@brave-builds brave-builds

Labels
CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS
Projects
None yet
Milestone
1.31.x - Release
Development

Successfully merging this pull request may close these issues.
4 participants
@brave-builds @kjozwiak @mkarolin @brave-browser-releases