Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable Google-assisted address normalization #1868

Closed
pilgrim-brave opened this issue Oct 26, 2018 · 1 comment · Fixed by brave/brave-core#769
Closed

Disable Google-assisted address normalization #1868

pilgrim-brave opened this issue Oct 26, 2018 · 1 comment · Fixed by brave/brave-core#769
Assignees
@pilgrim-brave
Labels
privacy/connect This requires making a network connection to a third-party service. QA/No release-notes/exclude
Milestone
0.58.x - Release ...

Comments

@pilgrim-brave
Copy link

pilgrim-brave commented Oct 26, 2018 •
edited
Loading

Autofill may attempt to contact a Google-owned server to download rules for normalizing address components such as phone numbers.

Some internal documentation: https://cs.chromium.org/chromium/src/components/autofill/core/browser/address_normalizer.h

Network access occurs in https://cs.chromium.org/chromium/src/third_party/libaddressinput/chromium/chrome_metadata_source.cc and should be disabled. There are no ill effects to disabling it; autofill will continue to function.

Verification of network request disabling is covered by automated browser tests. No manual QA required.
@pilgrim-brave pilgrim-brave added the privacy/connect This requires making a network connection to a third-party service. label Oct 26, 2018
@pilgrim-brave pilgrim-brave added this to the 1.x Backlog milestone Oct 26, 2018
@pilgrim-brave pilgrim-brave self-assigned this Oct 26, 2018
@rebron rebron modified the milestones: 1.x Backlog, 1.0 Oct 26, 2018
@bbondy bbondy modified the milestones: 1.0, 1.x Backlog Oct 30, 2018
pilgrim-brave added a commit to brave/brave-core that referenced this issue Oct 30, 2018
@pilgrim-brave
Block ChromeMetadataSource network access
da07c4d 
Fixes brave/brave-browser#1868
@pilgrim-brave pilgrim-brave mentioned this issue Oct 30, 2018
Merged
18 tasks
@bbondy bbondy modified the milestones: 1.x Backlog, 0.58.x - Nightly Oct 30, 2018
@srirambv
Copy link
Contributor

@pilgrim-brave can you add QA/Yes/QA/No label and any test steps in the issue/PR accordingly?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pilgrim-brave pilgrim-brave

Labels
privacy/connect This requires making a network connection to a third-party service. QA/No release-notes/exclude
Projects
None yet
Milestone
0.58.x - Release (Release Channel)
Development

Successfully merging a pull request may close this issue.

Block ChromeMetadataSource network access brave/brave-core
5 participants
@bbondy @kjozwiak @rebron @srirambv @pilgrim-brave