Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Widevine prompt needs to be more obvious to the user #1940

Closed
karenkliu opened this issue Oct 31, 2018 · 20 comments · Fixed by brave/brave-core#1772
Closed

Widevine prompt needs to be more obvious to the user #1940

karenkliu opened this issue Oct 31, 2018 · 20 comments · Fixed by brave/brave-core#1772
Assignees
Labels
design A design change, especially one which needs input from the design team feature/video plugin/Widevine priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include webcompat/not-shields-related Sites are breaking because of something other than Shields.

Comments

@karenkliu
Copy link

karenkliu commented Oct 31, 2018

Description

When I try to view a video on Hulu e.g. Rick and Morty S2E1, the page won't load. Hulu shows me an error page with this text "Error playing this video. Sorry, we encountered an error playing this video. Please ensure your browser is supported. Error code: 3001"
Same problem on Netflix - gives me a "Missing Component" error"
Seems to affect all sites that need Widevine - Amazon Video, BBC, Hulu, Netflix and Spotify

Steps to Reproduce

  1. Log into Hulu.com or Netflix
  2. Select any video to watch
  3. Try to play the video

Actual result:

screen shot 2018-10-31 at 1 39 46 pm

screen shot 2018-11-05 at 2 19 45 pm

Expected result:

Video should play

Reproduces how often:

Easily reproduced (always)

Brave version (brave://version info)

Version 0.55.22 Chromium: 70.0.3538.77 (Official Build) (64-bit)

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds?
    Yes.

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
    No.
  • Is the issue reproducible on the latest version of Chrome?
    No. It plays correctly in Chrome.

Additional Information

@srirambv srirambv added webcompat/not-shields-related Sites are breaking because of something other than Shields. feature/video labels Nov 1, 2018
@srirambv srirambv added this to the 1.x Backlog milestone Nov 1, 2018
@rebron rebron added the priority/P3 The next thing for us to work on. It'll ride the trains. label Nov 2, 2018
@rebron
Copy link
Collaborator

rebron commented Nov 2, 2018

widevine related issue?

@karenkliu
Copy link
Author

@rebron confirmed it's a widevine issue. I didn't notice it in the URL bar.
screen shot 2018-11-05 at 11 40 15 am

Why doesn't Widevine come pre-installed?

@bsclifton
Copy link
Member

bsclifton commented Nov 5, 2018

@karenkliu I think the disclaimer does a fair job explaining why it's not bundled by default - maybe we should make the need for this component more obvious than just a puzzle piece?

@karenkliu
Copy link
Author

@bradleyrichter @bsclifton I don't think it's obvious at all to the user why Widevine doesn't come bundled with Brave. Why does Brave "discourage" it? Is there an impact to user privacy by enabling it? Why would there be "damages or losses" by using it? Damages to what? Loss of what?

The wikipedia page https://en.wikipedia.org/wiki/Widevine describing it just makes it seem like it's a benign thing to enforce licensing and make sure creators + the platforms get paid for the content.

It's a huge product problem if Brave users can't figure out how to make Amazon Video, BBC, Hulu, Netflix and Spotify work in Brave and don't understand why we're making it harder for them to stream from these huge content platforms.

@bbondy moving this discussion to Github from Slack so that it's tracked with an issue.

@bbondy
Copy link
Member

bbondy commented Nov 5, 2018

Per Slack. We discourage it because it's a closed source CDM and because we decided as a company not to promote DRM.

Is there an impact to user privacy by enabling it?

Yes.

Why would there be "damages or losses" by using it? Damages to what? Loss of what?

Yes, we don't know what it does, or if it does more than what it says.

It's a huge product problem if Brave users can't figure out how to make Amazon Video, BBC, Hulu, Netflix and Spotify work in Brave and don't understand why we're making it harder for them to stream from these huge content platforms.

Yep, so let's figure out a better UI for it, but we can't include it by default.

@BrendanEich and @diracdeltas

@bbondy
Copy link
Member

bbondy commented Nov 5, 2018

I think we could just open the flyout by default so that people would notice it better.

@diracdeltas
Copy link
Member

I agree with @bbondy; this seems to be an issue of helping the user discover that the problem is widevine and install it smoothly as opposed to a problem of bundling widevine by default.

Once widevine is installed, they won't run into this issue in the future. (unlike Flash, widevine doesn't prompt anymore once it's installed)

@srirambv
Copy link
Contributor

srirambv commented Nov 5, 2018

@bbondy we should have this dialogue come out when Widevine needs to be installed
image

@karenkliu karenkliu changed the title video on hulu.com doesn't load with shields up/down Widevine prompt needs to be more obvious to the user Nov 5, 2018
@kjozwiak
Copy link
Member

kjozwiak commented Nov 5, 2018

Adding example of the current flow that was added into #1634 which I closed as duplicate as this one has more activity:

netflixnotification

@karenkliu
Copy link
Author

@rebron @tomlowenthal can we do something like this:
widevine permission notification
UX:
Widevine is already installed but not running. The first time the user encounters a site that needs Widevine, prompt the user for permission to run it in an obvious way by showing this notification in the page content area so that the user is sure to notice it.

  • If the user clicks block, this permission notification will show everytime a site needs it to run.

  • If the user clicks allow, this permission notification will never show again because Widevine will always run on sites that need it.

@srirambv
Copy link
Contributor

srirambv commented Nov 6, 2018

+1 on the bubble notification. If user ignores this it can still be run from the URL slide notification.

@diracdeltas
Copy link
Member

@karenkliu there is no need to prompt users to run widevine if it's already installed. the only case we would show a prompt is if widevine is needed but not installed. this matches the browser-laptop behavior.

therefore the prompt should say 'install widevine' or something to make it clear that clicking the affirmative option will install new software.

@karenkliu
Copy link
Author

@diracdeltas when @tomlowenthal looked at it with me he mentioned that the prompt makes it seem like it's not installed, but from the speed at which the page was able to play correctly after clicking install, he made the assumption that it was actually already installed in the browser and clicking install made it run instead of downloading new software and installing it.

If that's not true then yes, of course we should change the prompt to "install widevine" instead of "run" and only show it when it's not already installed.

@diracdeltas
Copy link
Member

@karenkliu the intended behavior is that widevine only prompts if it's not installed. if it's already installed and still prompting, we should remove those prompts. not sure about tom's assumption since i haven't verified it.

@eljuno
Copy link

eljuno commented Dec 18, 2018

+1 from Twitter: https://twitter.com/porteneuve/status/1075049456133906432?s=09

@angezanetti
Copy link

Is it possible to popup if not installed and then popup with block, allow once, allow? I'm not sure I want to run Widevine everytime if I didn't explicitly allow it to run

@bbondy
Copy link
Member

bbondy commented Jan 10, 2019

@angezanetti we have no ability right now for a per run permission prompt. I'm not opposed to the idea, please post another issue for that since this one is tracking just the ability for users to see an install prompt.

@rebron
Copy link
Collaborator

rebron commented Jan 29, 2019

@mkarolin:
To close on the implementation, we'll go with the following screen -> #1940 (comment)

Only change from that screen is we're going with "Install Widevine" instead of "Run Widevine"

@rebron rebron assigned simonhong and unassigned mkarolin Jan 30, 2019
@simonhong
Copy link
Member

Need to check PermissionRequest is suitable for this widevine bubble.
If not, need to implement custom facilities for managing its bubble.

@btlechowski
Copy link

btlechowski commented Mar 14, 2019

Verification passed on

Brave 0.63.4 Chromium: 73.0.3683.67 (Official Build) dev (64-bit)
Revision a83fd4f3207ae83412d329a9ca1239dd1e068345-refs/branch-heads/3683@{#760}
OS Windows 7 Service Pack 1 Build 7601.24312

Used test plan from brave/brave-core#1772
also checked netflix.com

image

Verified passed with

Brave 0.63.14 Chromium: 73.0.3683.75 (Official Build) dev(64-bit)
Revision 909ee014fcea6828f9a610e6716145bc0b3ebf4a-refs/branch-heads/3683@{#803}
OS Mac OS X

Verification passed on

Brave 0.63.14 Chromium: 73.0.3683.75 (Official Build) dev(64-bit)
Revision 909ee014fcea6828f9a610e6716145bc0b3ebf4a-refs/branch-heads/3683@{#803}
OS Ubuntu 18.04 LTS

Used test plan from brave/brave-core#1772

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design A design change, especially one which needs input from the design team feature/video plugin/Widevine priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include webcompat/not-shields-related Sites are breaking because of something other than Shields.
Projects
None yet
Development

Successfully merging a pull request may close this issue.