Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relaunch option is not shown in Tips settings section when the Tips settings are toggled via brave://settings/rewards #19560

Closed
GeetaSarvadnya opened this issue Nov 18, 2021 · 2 comments

Comments

@GeetaSarvadnya
Copy link

Description

Found while testing #18158
Relaunch option is not shown in the Tips settings section when the Tips settings are toggled via brave://settings/rewards

Steps to Reproduce

  1. Clean profile 1.33.x
  2. Enable rewards via BR panel
  3. Open brave://settings/rewards settings page
  4. Toggle Reddit switch
  5. Navigate to brave://rewards settings page
  6. Open Tips section, Reddit option is unchecked but there is no Relaunch option

Actual result:

Relaunch option is not shown in Tips settings section when the Tips settings are toggled via brave://settings/rewards
image

Expected result:

1.32.x
image

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.33.83 Chromium: 96.0.4664.45 (Official Build) beta (64-bit)
Revision 76e4c1bb2ab4671b8beba3444e61c0f17584b2fc-refs/branch-heads/4664@{#947}
OS Windows 10 Version 21H1 (Build 19043.1348)

Version/Channel Information:

  • Can you reproduce this issue with the current release? No
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @brave/legacy_qa @Miyayes @emerick

@emerick
Copy link
Contributor

emerick commented Nov 23, 2021

Right, we're not correctly reflecting the "needs a restart" state back to the brave://rewards page. This could be a little bit tricky, as that state management is all handled in-page.

@zenparsing zenparsing added the priority/P4 Planned work. We expect to get to it "soon". label Nov 24, 2021
@Miyayes Miyayes added priority/P3 The next thing for us to work on. It'll ride the trains. priority/P4 Planned work. We expect to get to it "soon". and removed priority/P4 Planned work. We expect to get to it "soon". priority/P3 The next thing for us to work on. It'll ride the trains. labels Mar 4, 2023
@mkarolin
Copy link
Contributor

No longer valid as tipping buttons have been removed (#34367).

@mkarolin mkarolin added this to the Closed / Dupe / Invalid milestone Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

5 participants