Remove Rewards inline tipping functionality

[emerick]

We updated the client to remove inline tipping functionality in #33783. While this removed the buttons and related settings from the client, the tipping scripts are still bundled with Greaselion. We should update Greaselion to remove those unused scripts.

[LaurenWags]

Verified on macOS x64 13.x with Brave Local Data Updater - Version: 1.0.1127 and

Brave | 1.60.118 Chromium: 119.0.6045.163 (Official Build) (x86_64)
-- | --
Revision | b0599b790dbdfe28428202afe2b54758a044ccfc
OS | macOS Version 13.6.1 (Build 22G313)

and

Brave | 1.62.57 Chromium: 119.0.6045.163 (Official Build) nightly (x86_64)
-- | --
Revision | ecdbb542296c7f884caf28fd148835f3be5286e5
OS | macOS Version 13.6.1 (Build 22G313)

Verified test plan from brave/brave-site-specific-scripts#105 (comment).

Nightly 1.62.x - PASSED

Rewards not enabled, using dev component version 1.0.1127 - PASSED

1. Clean profile 1.62.x launched with --args --enable-logging=stderr --vmodule="*/variations/*"=9,"*/bat-native-ledger/*"=9,"*/brave_rewards/*"=9,"*/bat-native-ads/*"=9,"*/bat-native-confirmations/*"=9,"*/brave_ads/*"=9,"*/brave_user_model/*"=9,"*/bat_ads/*"=9 --rewards=staging=true,debug=true --use-dev-goupdater-url --show-component-extension-options
2. Close and relaunch to pull griffin
3. Visit brave://extensions
4. There are 6 "Greaselion" components listed
5. Open a new tab, enable devtools
6. Visit twitter.com/brave
7. Confirm no mention of twitterInlineTipping in devtools console, confirm no in-line tip icons shown
   • items like twitterBase, etc are ok
8. Visit https://github.com/brave/brave-browser/issues/34367
9. Confirm no mention of githubInlineTipping in devtools console, confirm no in-line tip icons shown
   • items like githubBase, etc are ok
10. Visit https://old.reddit.com/r/crochet/
11. Confirm no mention of redditInlineTipping in devtools console, confirm no in-line tip icons shown

• items like redditBase, etc are ok

12. Visit brave://settings/rewards
13. Confirm no mention of in-line tip icon settings (just a spot check, this testing will be more thoroughly covered under Remove inline Tip buttons #33783)

Step 4	Step 7	Step 9	Step 11	Step 13

Rewards enabled, using dev component version 1.0.1127 - PASSED

1. Continue from above test case
2. Enable rewards and restart the browser
3. Visit brave://extensions
4. There are 13 "Greaselion" components listed (2 for each media creator type and 1 for Brave Talk)
5. Open a new tab, enable devtools
6. Visit twitter.com/brave
7. Confirm no mention of twitterInlineTipping in devtools console, confirm no in-line tip icons shown
   • items like twitterBase, etc are ok
8. Visit https://github.com/brave/brave-browser/issues/34367
9. Confirm no mention of githubInlineTipping in devtools console, confirm no in-line tip icons shown
   • items like githubBase, etc are ok
10. Visit https://old.reddit.com/r/crochet/
11. Confirm no mention of redditInlineTipping in devtools console, confirm no in-line tip icons shown

• items like redditBase, etc are ok

12. Visit brave://settings/rewards
13. Confirm no mention of in-line tip icon settings (just a spot check, this testing will be more thoroughly covered under Remove inline Tip buttons #33783)

Note - if you use a country that does not have auto contribution (ex. Japan, India), you will only have 7 "Greaselion" components in step 4. This is expected per discussions with Emerick as the additional ones are related to AC.

Step 4	Step 7	Step 9	Step 11	Step 13

For comparison:

Rewards not enabled, using (current) prod component version 1.0.527

1. Clean profile 1.62.x launched with --args --enable-logging=stderr --vmodule="*/variations/*"=9,"*/bat-native-ledger/*"=9,"*/brave_rewards/*"=9,"*/bat-native-ads/*"=9,"*/bat-native-confirmations/*"=9,"*/brave_ads/*"=9,"*/brave_user_model/*"=9,"*/bat_ads/*"=9 --rewards=staging=true,debug=true --use-dev-goupdater-url --show-component-extension-options
2. Close and relaunch to pull griffin
3. Visit brave://extensions
4. There are 6 "Greaselion" components listed
5. Open a new tab, enable devtools
6. Visit twitter.com/brave
7. Confirm no mention of twitterInlineTipping in devtools console, confirm no in-line tip icons shown
   • items like twitterBase, etc are ok
8. Visit https://github.com/brave/brave-browser/issues/34367
9. Confirm no mention of githubInlineTipping in devtools console, confirm no in-line tip icons shown
   • items like githubBase, etc are ok
10. Visit https://old.reddit.com/r/crochet/
11. Confirm no mention of redditInlineTipping in devtools console, confirm no in-line tip icons shown

• items like redditBase, etc are ok

12. Visit brave://settings/rewards
13. Confirm no mention of in-line tip icon settings (just a spot check, this testing will be more thoroughly covered under Remove inline Tip buttons #33783)

Step 4	Step 7	Step 9	Step 11	Step 13

Rewards enabled, using (current) prod component version 1.0.527

1. Continue from above test case
2. Enable rewards and restart the browser
3. Visit brave://extensions
4. There are 13 "Greaselion" components listed (2 for each media creator type and 1 for Brave Talk)
5. Open a new tab, enable devtools
6. Visit twitter.com/brave
7. Confirm no mention of twitterInlineTipping in devtools console, confirm no in-line tip icons shown
   • items like twitterBase, etc are ok
8. Visit https://github.com/brave/brave-browser/issues/34367
9. Confirm no mention of githubInlineTipping in devtools console, confirm no in-line tip icons shown
   • items like githubBase, etc are ok
10. Visit https://old.reddit.com/r/crochet/
11. Confirm no mention of redditInlineTipping in devtools console, confirm no in-line tip icons shown

• items like redditBase, etc are ok

12. Visit brave://settings/rewards
13. Confirm no mention of in-line tip icon settings (just a spot check, this testing will be more thoroughly covered under Remove inline Tip buttons #33783)

Note - if you use a country that does not have auto contribution (ex. Japan, India), you will only have 7 "Greaselion" components in step 4. This is expected per discussions with Emerick as the additional ones are related to AC.

Step 4	Step 7	Step 9	Step 11	Step 13

Release 1.60.x - PASSED

Rewards not enabled, using dev component version 1.0.1127 - PASSED

1. Clean profile 1.60.x launched with --args --enable-logging=stderr --vmodule="*/variations/*"=9,"*/bat-native-ledger/*"=9,"*/brave_rewards/*"=9,"*/bat-native-ads/*"=9,"*/bat-native-confirmations/*"=9,"*/brave_ads/*"=9,"*/brave_user_model/*"=9,"*/bat_ads/*"=9 --rewards=staging=true,debug=true --use-dev-goupdater-url --show-component-extension-options
2. Close and relaunch to pull griffin
3. Visit brave://extensions
4. There are 6 "Greaselion" components listed
5. Open a new tab, enable devtools
6. Visit twitter.com/brave
7. Confirm no mention of twitterInlineTipping in devtools console, confirm no in-line tip icons shown
   • items like twitterBase, etc are ok
8. Visit https://github.com/brave/brave-browser/issues/34367
9. Confirm no mention of githubInlineTipping in devtools console, confirm no in-line tip icons shown
   • items like githubBase, etc are ok
10. Visit https://old.reddit.com/r/crochet/
11. Confirm no mention of redditInlineTipping in devtools console, confirm no in-line tip icons shown

• items like redditBase, etc are ok

12. Visit brave://settings/rewards
13. Confirm no mention of in-line tip icon settings (just a spot check, this testing will be more thoroughly covered under Remove inline Tip buttons #33783)

Step 4	Step 7	Step 9	Step 11	Step 13

Rewards enabled, using dev component version 1.0.1127 - PASSED

1. Continue from above test case
2. Enable rewards and restart the browser
3. Visit brave://extensions
4. There are 13 "Greaselion" components listed (2 for each media creator type and 1 for Brave Talk)
5. Open a new tab, enable devtools
6. Visit twitter.com/brave
7. Confirm no mention of twitterInlineTipping in devtools console, confirm no in-line tip icons shown
   • items like twitterBase, etc are ok
8. Visit https://github.com/brave/brave-browser/issues/34367
9. Confirm no mention of githubInlineTipping in devtools console, confirm no in-line tip icons shown
   • items like githubBase, etc are ok
10. Visit https://old.reddit.com/r/crochet/
11. Confirm no mention of redditInlineTipping in devtools console, confirm no in-line tip icons shown

• items like redditBase, etc are ok

12. Visit brave://settings/rewards
13. In-line tip icon settings are still displayed (to be removed in a future milestone with Remove inline Tip buttons #33783)

Note - if you use a country that does not have auto contribution (ex. Japan, India), you will only have 7 "Greaselion" components in step 4. This is expected per discussions with Emerick as the additional ones are related to AC.

Step 4	Step 7	Step 9	Step 11	Step 13

For comparison:

Rewards not enabled, using (current) prod component version 1.0.527

1. Clean profile 1.60.x launched with --args --enable-logging=stderr --vmodule="*/variations/*"=9,"*/bat-native-ledger/*"=9,"*/brave_rewards/*"=9,"*/bat-native-ads/*"=9,"*/bat-native-confirmations/*"=9,"*/brave_ads/*"=9,"*/brave_user_model/*"=9,"*/bat_ads/*"=9 --rewards=staging=true,debug=true --use-dev-goupdater-url --show-component-extension-options
2. Close and relaunch to pull griffin
3. Visit brave://extensions
4. There are 8 "Greaselion" components listed
5. Open a new tab, enable devtools
6. Visit twitter.com/brave
7. Confirm no mention of twitterInlineTipping in devtools console, confirm no in-line tip icons shown (they had been removed previously)
   • items like twitterBase, etc are ok
8. Visit https://github.com/brave/brave-browser/issues/34367
9. There is mention of githubInlineTipping in devtools console (among others, githubBase, etc) and in-line tip buttons are shown
10. Visit https://old.reddit.com/r/crochet/
11. There is mention of redditInlineTipping in devtools console (among others, redditBase, etc) and in-line tip buttons are shown
12. Visit brave://settings/rewards
13. In-line tip icon settings are still displayed (to be removed in a future milestone with Remove inline Tip buttons #33783)

Step 4	Step 7	Step 9	Step 11	Step 13

Rewards enabled, using (current) prod component version 1.0.527

1. Continue from test case above
2. Enable rewards and relaunch browser
3. Visit brave://extensions
4. There are 15 "Greaselion" components listed
5. Open a new tab, enable devtools
6. Visit twitter.com/brave
7. Confirm no mention of twitterInlineTipping in devtools console, confirm no in-line tip icons shown (they had been removed previously)
   • items like twitterBase, etc are ok
8. Visit https://github.com/brave/brave-browser/issues/34367
9. There is mention of githubInlineTipping in devtools console (among others, githubBase, etc) and in-line tip buttons are shown
10. Visit https://old.reddit.com/r/crochet/
11. There is mention of redditInlineTipping in devtools console (among others, redditBase, etc) and in-line tip buttons are shown
12. Visit brave://settings/rewards
13. In-line tip icon settings are still displayed (to be removed in a future milestone with Remove inline Tip buttons #33783)

Step 4	Step 7	Step 9	Step 11	Step 13

[GeetaSarvadnya]

Verification PASSED on Windows 10x64 with Brave Local Data Updater - Version: 1.0.1127 and

Brave | 1.60.118 Chromium: 119.0.6045.163 (Official Build) (64-bit)
-- | --
Revision | b0599b790dbdfe28428202afe2b54758a044ccfc
OS | Windows 10 Version 22H2 (Build 19045.3693)

And

Brave | 1.62.57 Chromium: 119.0.6045.163 (Official Build) nightly (64-bit)
-- | --
Revision | ecdbb542296c7f884caf28fd148835f3be5286e5
OS | Windows 10 Version 22H2 (Build 19045.3693)

1.62.x Clean profile NEW component

Nightly 1.62.x_Rewards not enabled_PASSED

Rewards not enabled, using dev component version 1.0.1127 - PASSED

1. Clean profile 1.62.x launched with brave.exe --enable-logging=stderr --vmodule="*/variations/*"=9,"*/bat-native-ledger/*"=9,"*/brave_rewards/*"=9,"*/bat-native-ads/*"=9,"*/bat-native-confirmations/*"=9,"*/brave_ads/*"=9,"*/brave_user_model/*"=9,"*/bat_ads/*"=9 --rewards=staging=true,debug=true --use-dev-goupdater-url --show-component-extension-options
2. Close and relaunch to pull griffin
3. Visit brave://extensions
4. There are 6 "Greaselion" components listed
5. Open a new tab, enable devtools
6. Visit twitter.com/brave
7. Confirm no mention of twitterInlineTipping in devtools console, confirm no in-line tip icons shown
   • items like twitterBase, etc are ok
8. Visit https://github.com/brave/brave-browser/issues/34367
9. Confirm no mention of githubInlineTipping in devtools console, confirm no in-line tip icons shown
   • items like githubBase, etc are ok
10. Visit https://old.reddit.com/r/crochet/
11. Confirm no mention of redditInlineTipping in devtools console, confirm no in-line tip icons shown

• items like redditBase, etc are ok

12. Visit brave://settings/rewards
13. Confirm no mention of in-line tip icon settings (just a spot check, this testing will be more thoroughly covered under Remove inline Tip buttons #33783)

Step 4	Step 7	Step 9	Step 11	Step 13

Nightly 1.62.x_Rewards enabled_PASSED

Rewards enabled, using dev component version 1.0.1127 - PASSED

1. Continue from above test case
2. Enable rewards and restart the browser
3. Visit brave://extensions
4. There are 13 "Greaselion" components listed (2 for each media creator type and 1 for Brave Talk)
5. Open a new tab, enable devtools
6. Visit twitter.com/brave
7. Confirm no mention of twitterInlineTipping in devtools console, confirm no in-line tip icons shown
   • items like twitterBase, etc are ok
8. Visit https://github.com/brave/brave-browser/issues/34367
9. Confirm no mention of githubInlineTipping in devtools console, confirm no in-line tip icons shown
   • items like githubBase, etc are ok
10. Visit https://old.reddit.com/r/crochet/
11. Confirm no mention of redditInlineTipping in devtools console, confirm no in-line tip icons shown

• items like redditBase, etc are ok

12. Visit brave://settings/rewards
13. Confirm no mention of in-line tip icon settings (just a spot check, this testing will be more thoroughly covered under Remove inline Tip buttons #33783)

Note - if you use a country that does not have auto contribution (ex. Japan, India), you will only have 7 "Greaselion" components in step 4. This is expected per discussions with Emerick as the additional ones are related to AC.

Step 4	Step 7	Step 9	Step 11	Step 13

1.62.x Clean profile OLD component

Nightly 1.62.x_Rewards not enabled_PASSED

Rewards not enabled, using prod component version 1.0.527 - PASSED

1. Clean profile 1.62.x launched with brave.exe --enable-logging=stderr --vmodule="*/variations/*"=9,"*/bat-native-ledger/*"=9,"*/brave_rewards/*"=9,"*/bat-native-ads/*"=9,"*/bat-native-confirmations/*"=9,"*/brave_ads/*"=9,"*/brave_user_model/*"=9,"*/bat_ads/*"=9 --rewards=staging=true,debug=true --show-component-extension-options
2. Close and relaunch to pull griffin
3. Visit brave://extensions
4. There are 6 "Greaselion" components listed
5. Open a new tab, enable devtools
6. Visit twitter.com/brave
7. Confirm no mention of twitterInlineTipping in devtools console, confirm no in-line tip icons shown
   • items like twitterBase, etc are ok
8. Visit https://github.com/brave/brave-browser/issues/34367
9. Confirm no mention of githubInlineTipping in devtools console, confirm no in-line tip icons shown
   • items like githubBase, etc are ok
10. Visit https://old.reddit.com/r/crochet/
11. Confirm no mention of redditInlineTipping in devtools console, confirm no in-line tip icons shown

• items like redditBase, etc are ok

12. Visit brave://settings/rewards
13. Confirm no mention of in-line tip icon settings (just a spot check, this testing will be more thoroughly covered under Remove inline Tip buttons #33783)

Step 4	Step 7	Step 9	Step 11	Step 13

Nightly 1.62.x_Rewards enabled_PASSED

Rewards enabled, using prod component version 1.0.527 - PASSED

1. Continue from above test case
2. Enable rewards and restart the browser
3. Visit brave://extensions
4. There are 13 "Greaselion" components listed (2 for each media creator type and 1 for Brave Talk)
5. Open a new tab, enable devtools
6. Visit twitter.com/brave
7. Confirm no mention of twitterInlineTipping in devtools console, confirm no in-line tip icons shown
   • items like twitterBase, etc are ok
8. Visit https://github.com/brave/brave-browser/issues/34367
9. Confirm no mention of githubInlineTipping in devtools console, confirm no in-line tip icons shown
   • items like githubBase, etc are ok
10. Visit https://old.reddit.com/r/crochet/
11. Confirm no mention of redditInlineTipping in devtools console, confirm no in-line tip icons shown

• items like redditBase, etc are ok

12. Visit brave://settings/rewards
13. Confirm no mention of in-line tip icon settings (just a spot check, this testing will be more thoroughly covered under Remove inline Tip buttons #33783)

Note - if you use a country that does not have auto contribution (ex. Japan, India), you will only have 7 "Greaselion" components in step 4. This is expected per discussions with Emerick as the additional ones are related to AC.

Step 4	Step 7	Step 9	Step 11	Step 13

---

1.60.x Clean profile OLD component

Release 1.60.x_Rewards not enabled_PASSED

Rewards not enabled, using prod component version 1.0.527 - PASSED

1. Clean profile 1.60.x launched with brave.exe --enable-logging=stderr --vmodule="*/variations/*"=9,"*/bat-native-ledger/*"=9,"*/brave_rewards/*"=9,"*/bat-native-ads/*"=9,"*/bat-native-confirmations/*"=9,"*/brave_ads/*"=9,"*/brave_user_model/*"=9,"*/bat_ads/*"=9 --rewards=staging=true,debug=true --show-component-extension-options

2. Close and relaunch to pull griffin

3. Visit brave://extensions

4. There are 8 "Greaselion" components listed

5. Open a new tab, enable devtools

6. Visit twitter.com/brave

7. Confirm no mention of twitterInlineTipping in devtools console, confirm no in-line tip icons shown

   • items like twitterBase, etc are ok

8. Visit https://github.com/brave/brave-browser/issues/34367

9. Confirm mention of githubInlineTipping in devtools console, confirm in-line tip icons shown on the github page

10. Visit https://old.reddit.com/r/crochet/

11. Confirm mention of redditInlineTipping in devtools console, confirm in-line tip icons shown on the reddit page

12. Visit brave://settings/rewards

13. Confirm mention of in-line tip icon settings

Step 4	Step 7	Step 9	Step 11	Step 13

Release 1.60.x_Rewards enabled_PASSED

Rewards enabled, using prod component version 1.0.527 - PASSED

1. Continue from above test case

2. Enable rewards and restart the browser

3. Visit brave://extensions

4. There are 15 "Greaselion" components listed

5. Open a new tab, enable devtools

6. Visit twitter.com/brave

7. Confirm no mention of twitterInlineTipping in devtools console, confirm no in-line tip icons shown

   • items like twitterBase, etc are ok

8. Visit https://github.com/brave/brave-browser/issues/34367

9. Confirm mention of githubInlineTipping in devtools console, confirm in-line tip icons shown on the GH webpage

10. Visit https://old.reddit.com/r/crochet/

11. Confirm mention of redditInlineTipping in devtools console, confirm in-line tip icons shown on the reddit webpage

12. Visit brave://settings/rewards

13. Confirm mention of in-line tip icon settings

Note - if you use a country that does not have auto contribution (ex. Japan, India), you will only have 7 "Greaselion" components in step 4. This is expected per discussions with Emerick as the additional ones are related to AC.

Step 4	Step 7	Step 9	Step 11	Step 13

1.60.x Clean profile NEW component

Release 1.60.x_Rewards not enabled_PASSED

Rewards not enabled, using dev component version 1.0.1127 - PASSED

1. Clean profile 1.60.x launched with brave.exe --enable-logging=stderr --vmodule="*/variations/*"=9,"*/bat-native-ledger/*"=9,"*/brave_rewards/*"=9,"*/bat-native-ads/*"=9,"*/bat-native-confirmations/*"=9,"*/brave_ads/*"=9,"*/brave_user_model/*"=9,"*/bat_ads/*"=9 --rewards=staging=true,debug=true --use-dev-goupdater-url --show-component-extension-options
2. Close and relaunch to pull griffin
3. Visit brave://extensions
4. There are 6 "Greaselion" components listed
5. Open a new tab, enable devtools
6. Visit twitter.com/brave
7. Confirm no mention of twitterInlineTipping in devtools console, confirm no in-line tip icons shown
   • items like twitterBase, etc are ok
8. Visit https://github.com/brave/brave-browser/issues/34367
9. Confirm no mention of githubInlineTipping in devtools console, confirm no in-line tip icons shown
   • items like githubBase, etc are ok
10. Visit https://old.reddit.com/r/crochet/
11. Confirm no mention of redditInlineTipping in devtools console, confirm no in-line tip icons shown

• items like redditBase, etc are ok

12. Visit brave://settings/rewards
13. Confirm mention of in-line tip icon settings

Step 4	Step 7	Step 9	Step 11	Step 13

Release 1.60.x_Rewards enabled_PASSED

Rewards enabled, using dev component version 1.0.1127 - PASSED

1. Continue from above test case
2. Enable rewards and restart the browser
3. Visit brave://extensions
4. There are 13 "Greaselion" components listed
5. Open a new tab, enable devtools
6. Visit twitter.com/brave
7. Confirm no mention of twitterInlineTipping in devtools console, confirm no in-line tip icons shown
   • items like twitterBase, etc are ok
8. Visit https://github.com/brave/brave-browser/issues/34367
9. Confirm no mention of githubInlineTipping in devtools console, confirm no in-line tip icons shown
   • items like githubBase, etc are ok
10. Visit https://old.reddit.com/r/crochet/
11. Confirm no mention of redditInlineTipping in devtools console, confirm no in-line tip icons shown

• items like redditBase, etc are ok

12. Visit brave://settings/rewards
13. Confirm mention of in-line tip icon settings

Note - if you use a country that does not have auto contribution (ex. Japan, India), you will only have 7 "Greaselion" components in step 4. This is expected per discussions with Emerick as the additional ones are related to AC.

Step 4	Step 7	Step 9	Step 11	Step 13