Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use contract address for fetching prices when possible #19574

Closed
Douglashdaniel opened this issue Nov 18, 2021 · 4 comments · Fixed by brave/brave-core#11557
Closed

Use contract address for fetching prices when possible #19574

Douglashdaniel opened this issue Nov 18, 2021 · 4 comments · Fixed by brave/brave-core#11557
Assignees
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include

Comments

@Douglashdaniel
Copy link

Description

Consider using Contract Address for Fetching Token Prices

Currently we are using the Tokens Symbol as a param to fetch the price of a Token from CoinGecko.
In some occasions the Symbol is different than the token-id param required by CoinGecko's api which will cause an incorrect price.

@Douglashdaniel Douglashdaniel added priority/P2 A bad problem. We might uplift this to the next planned release. QA/Yes release-notes/exclude feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop labels Nov 18, 2021
@Douglashdaniel Douglashdaniel self-assigned this Nov 18, 2021
@bbondy bbondy added priority/P4 Planned work. We expect to get to it "soon". and removed priority/P2 A bad problem. We might uplift this to the next planned release. labels Nov 23, 2021
@bbondy
Copy link
Member

bbondy commented Nov 23, 2021

Dropping priority of this since we have a server side fix now for better symbol matching

@waylonflinn
Copy link

Server side fix may not have addressed all issues.
I posted some details about a problem I encountered today on the community forum:
https://community.brave.com/t/wallet-pointing-to-the-incorrect-price-for-a-coin/305383/4?u=waylonflinn

@bbondy bbondy added priority/P2 A bad problem. We might uplift this to the next planned release. and removed priority/P4 Planned work. We expect to get to it "soon". labels Dec 3, 2021
@bbondy
Copy link
Member

bbondy commented Dec 3, 2021

Note when the server supports lookup by contract address, I think we'll only be able to use it for lookups with Ethereum contract addresses. We'll still need to query by symbol for when the tokens are on a different network.

@srirambv
Copy link
Contributor

srirambv commented Jan 4, 2022

Brave 1.34.78 Chromium: 97.0.4692.56 (Official Build) (64-bit)
Revision adefa7837d02a07a604c1e6eff0b3a09422ab88d-refs/branch-heads/4692@{#1247}
OS ☑️ Linux ☑️ Windows 11 Version Dev
(Build 22523.1000)
☑️ macOS Version 12.0.1
(Build 21A559)
  • Verified steps from brave/brave-core#11557
  • Verified selecting custom token shows asset price fetched from CoinGecko API
19574-Linux.mp4
19574-Win.mov
19574-macOS.mov

@bbondy bbondy changed the title Consider using Contract Address for Fetching Prices Use contract address for fetching prices when possible Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants