Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some tokens have balance of 0 #19600

Closed
bbondy opened this issue Nov 19, 2021 · 2 comments
Closed

Some tokens have balance of 0 #19600

bbondy opened this issue Nov 19, 2021 · 2 comments
Labels
closed/fixed-by-component-update feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA/No release-notes/include
Milestone
1.32.x - Release #2

Comments

@bbondy
Copy link
Member

bbondy commented Nov 19, 2021

From https://old.reddit.com/r/brave_browser/comments/qwovh0/my_feedback_about_new_brave_wallet/

I noticed that some tokens (like uni but there are others, Uniswap is not such an exotic token) had a value of 0$ that makes the wallet balance unusable
@bbondy bbondy added priority/P2 A bad problem. We might uplift this to the next planned release. QA/Yes release-notes/include feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality OS/Desktop labels Nov 19, 2021
@Douglashdaniel
Copy link

#19574 is related.

@bbondy
Copy link
Member Author

bbondy commented Nov 23, 2021

This was fixed server side. The problem was that CG had many different symbols matching our requests. We dedupe based on the name in our list now.

@bbondy bbondy closed this as completed Nov 23, 2021
@bbondy bbondy added this to the 1.32.x - Release #2 milestone Nov 23, 2021
@kjozwiak kjozwiak mentioned this issue Nov 25, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
closed/fixed-by-component-update feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA/No release-notes/include
Projects
None yet
Milestone
1.32.x - Release #2
Development

No branches or pull requests
3 participants
@bbondy @Douglashdaniel and others