Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Full Fiat Balance not showing with ERC721 tokens #19725

Closed
Douglashdaniel opened this issue Nov 24, 2021 · 1 comment · Fixed by brave/brave-core#11280
Closed

Full Fiat Balance not showing with ERC721 tokens #19725

Douglashdaniel opened this issue Nov 24, 2021 · 1 comment · Fixed by brave/brave-core#11280
Assignees
@Douglashdaniel
Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.33.x - Release

Comments

@Douglashdaniel
Copy link

Description

The Full Portfolio Fiat Balance is not showing up when you have an ERC721 in your visible list

Screen.Recording.2021-11-24.at.11.57.26.AM.mov
@Douglashdaniel Douglashdaniel added priority/P2 A bad problem. We might uplift this to the next planned release. QA/Yes release-notes/include feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop front-end-change This task is a front end task and doesn't need any C++ changes labels Nov 24, 2021
@Douglashdaniel Douglashdaniel self-assigned this Nov 24, 2021
@Douglashdaniel Douglashdaniel mentioned this issue Nov 24, 2021
Merged
24 tasks
@Douglashdaniel Douglashdaniel added this to the 1.34.x - Nightly milestone Nov 24, 2021
@Douglashdaniel Douglashdaniel mentioned this issue Nov 29, 2021
Merged
7 tasks
@srirambv
Copy link
Contributor

srirambv commented Dec 2, 2021

Verification passed on

Brave 1.33.98 Chromium: 96.0.4664.55 (Official Build) (64-bit)
Revision 38cededc5d09b785d12203f1d3209aa6eb293e79-refs/branch-heads/4664@{#1090}
OS Linux

Verification passed on

Brave 1.33.98 Chromium: 96.0.4664.55 (Official Build) (64-bit)
Revision 38cededc5d09b785d12203f1d3209aa6eb293e79-refs/branch-heads/4664@{#1090}
OS Windows 11 Version Dev (Build 22509.1000)

Verification passed on

Brave 1.33.98 Chromium: 96.0.4664.55 (Official Build) (arm64)
Revision 38cededc5d09b785d12203f1d3209aa6eb293e79-refs/branch-heads/4664@{#1090}
OS macOS Version 12.0.1 (Build 21A559)

@LaurenWags LaurenWags mentioned this issue Dec 13, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Douglashdaniel Douglashdaniel

Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
None yet
Milestone
1.33.x - Release
Development

Successfully merging a pull request may close this issue.

Filtered out ERC721 tokens from Full Fiat Balance brave/brave-core
3 participants
@kjozwiak @srirambv @Douglashdaniel