Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filtered out ERC721 tokens from Full Fiat Balance #11280

Merged
merged 1 commit into from
Nov 24, 2021

Conversation

Douglashdaniel
Copy link
Contributor

Description

Filtered out ERC721 tokens from being calculated in the Full Fiat Balance method

Resolves brave/brave-browser#19725

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Before:

Screen.Recording.2021-11-24.at.11.57.26.AM.mov

After:

Screen.Recording.2021-11-24.at.11.54.41.AM.mov

@Douglashdaniel Douglashdaniel self-assigned this Nov 24, 2021
@Douglashdaniel Douglashdaniel force-pushed the filter-out-erc721-from-fiat-balance branch from 5dd4ba4 to f8a6847 Compare November 24, 2021 19:11
@Douglashdaniel Douglashdaniel merged commit 7473729 into master Nov 24, 2021
@Douglashdaniel Douglashdaniel deleted the filter-out-erc721-from-fiat-balance branch November 24, 2021 22:19
@Douglashdaniel Douglashdaniel added this to the 1.34.x - Nightly milestone Nov 24, 2021
Douglashdaniel added a commit that referenced this pull request Nov 29, 2021
Filtered out ERC721 tokens from Full Fiat Balance
Douglashdaniel added a commit that referenced this pull request Dec 1, 2021
Filtered out ERC721 tokens from Full Fiat Balance
@srirambv
Copy link
Contributor

srirambv commented Dec 1, 2021

Verification passed on

Brave 1.34.48 Chromium: 96.0.4664.45 (Official Build) nightly (x86_64 translated)
Revision 76e4c1bb2ab4671b8beba3444e61c0f17584b2fc-refs/branch-heads/4664@{#947}
OS macOS Version 12.0.1 (Build 21A559)
  • Verified portfolio balance updates accordingly when ERC21 tokens are enabled/disabled
11280.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Full Fiat Balance not showing with ERC721 tokens
4 participants