Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Function type text missing in transaction detail box UI #19841

Closed
yrliou opened this issue Nov 30, 2021 · 1 comment · Fixed by brave/brave-core#11344
Closed

Function type text missing in transaction detail box UI #19841

yrliou opened this issue Nov 30, 2021 · 1 comment · Fixed by brave/brave-core#11344
Assignees
@yrliou
Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude
Milestone
1.33.x - Release

Comments

@yrliou
Copy link
Member

yrliou commented Nov 30, 2021 •
edited
Loading

Example of missing type text:
Screen Shot 2021-11-26 at 9 04 04 PM

Example of type text displayed correctly:
Screen Shot 2021-11-30 at 12 24 50 PM

We were using TransactionType[txType] which doesn't work anymore after using mojom type directly, this bug starts from 1.33.x.
@yrliou yrliou self-assigned this Nov 30, 2021
@yrliou yrliou mentioned this issue Nov 30, 2021
Merged
24 tasks
This was referenced Dec 1, 2021
Merged
Merged
@yrliou yrliou added this to the 1.35.x - Nightly milestone Dec 1, 2021
@srirambv
Copy link
Contributor

srirambv commented Dec 3, 2021

Brave 1.33.98 Chromium: 96.0.4664.55 (Official Build) (64-bit)
Revision 38cededc5d09b785d12203f1d3209aa6eb293e79-refs/branch-heads/4664@{#1090}
OS ☑️ Linux ☑️ Windows 11 Version Dev
(Build 22504.1010) 		☑️ macOS Version 12.0.1
(Build 21A559)
Linux.mp4
Windows.mov
macOS.mov

@bbondy bbondy added the priority/P2 A bad problem. We might uplift this to the next planned release. label Dec 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yrliou yrliou

Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.33.x - Release
Development

Successfully merging a pull request may close this issue.

Fix transaction type text in TransactionDetailBox brave/brave-core
4 participants
@bbondy @kjozwiak @yrliou @srirambv