Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix transaction type text in TransactionDetailBox (uplift to 1.34.x) #11352

Merged
merged 1 commit into from
Dec 3, 2021

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Dec 1, 2021

Uplift of #11344
Resolves brave/brave-browser#19841

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from a team December 1, 2021 00:58
@brave-builds brave-builds self-assigned this Dec 1, 2021
@brave-builds brave-builds added this to the 1.34.x - Beta milestone Dec 1, 2021
@kjozwiak
Copy link
Member

kjozwiak commented Dec 1, 2021

macOS failed test-browser due to both RewardsContributionBrowserTest.SplitProcessOneTimeTip & RewardsContributionBrowserTest.SplitProcessorAutoContribution failing as per https://ci.brave.com/job/pr-brave-browser-pr11344_fix_func_type_UI_1.34.x-macos/1/testReport/. However, these are known intermittent issues as per brave/brave-browser#13883 & brave/brave-browser#13884 and don't block the above uplift as they're not related to this specific PR.

Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.34.x approved after deliberating with @brave/uplift-approvers. QA has verified the PR on Nightly as per #11344 (comment).

@kjozwiak kjozwiak merged commit 878c1be into 1.34.x Dec 3, 2021
@kjozwiak kjozwiak deleted the pr11344_fix_func_type_UI_1.34.x branch December 3, 2021 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants