Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In page translation for content #208

Closed
bsclifton opened this issue May 17, 2018 · 114 comments · Fixed by brave/brave-core#2006
Closed

In page translation for content #208

bsclifton opened this issue May 17, 2018 · 114 comments · Fixed by brave/brave-core#2006
Assignees
Labels
closed/invalid feature/translate l10n priority/P3 The next thing for us to work on. It'll ride the trains. privacy/connect This requires making a network connection to a third-party service. QA/Yes release-notes/include

Comments

@bsclifton
Copy link
Member

bsclifton commented May 17, 2018

Similar to what is offered in Chrome:
screen shot 2018-05-17 at 1 56 32 pm

  • foreign language detected
  • small message box shown asking if user would like translation
  • button remains in place in URL bar (in case message box is dismissed)

Per #237, you should also be able to trigger this process by right clicking on the page and pick Translate from the context menu

@bsclifton bsclifton changed the title In page translation In page translation for content May 17, 2018
@bsclifton bsclifton added the l10n label May 17, 2018
@bbondy bbondy added this to the Backlog milestone Jun 6, 2018
@Naigel56
Copy link

I want to strongly back this addition. How many of us nowadays are living/working abroad for extensive periods of time? It's really hard to read any non-english local business website (or "non-your-native-language") without any kind of translate plugin. Not to mention the possibility to read some foreign language articles, having an invaluable help while learning a foreign language, and so on.

I like Brave browser but personally this single missing feature is what refrain me from completely dropping Chrome.

@AvraamMavridis
Copy link

Exactly @Naigel56

I keep reopening Chrome because I live in Germany and I don't speak the language.
Any time I want to read an email from a german service I have to open Chrome...

@bsclifton
Copy link
Member Author

+1 from @srirambv via #237
The popup is presented, but when you click Translate it presents a The page could not be translated message

translate

@tildelowengrimm tildelowengrimm added the privacy/connect This requires making a network connection to a third-party service. label Sep 15, 2018
@iMartyn
Copy link

iMartyn commented Oct 1, 2018

+1 another vote for this, living in a country who's primary language is not my own and the frustrating web devs who believe that location == language.

@Brave-Matt
Copy link

@Miyayes
Copy link
Collaborator

Miyayes commented Oct 9, 2018

@eljuno
Copy link

eljuno commented Oct 25, 2018

+1 from community https://community.brave.com/t/right-click-translate-to-english-does-not-work/35663?u=eljuno

Version 0.55.18 Chromium: 70.0.3538.67 (Official Build) (64-bit)
English interface
Windows 10 Pro English v1803

Right click > Translate to _language_ not working > Nothing happens

+1 from Community https://community.brave.com/t/traduzione-nuove-pagine/42887?u=eljuno

+1 from Community https://community.brave.com/t/translator-option-not-working/43256?u=eljuno

@sadiqevani
Copy link

+1 this would be awesome to have!

@cbatub
Copy link

cbatub commented Nov 6, 2018

+1 please guys please please please fix it, fix it and Brave is close to perfect.

@NejcZdovc
Copy link
Contributor

cc @mandar-brave @davidtemkin @bbondy for prioritisation

@Th3-A6add0n
Copy link

+1 from @srirambv via #237
The popup is presented, but when you click Translate it presents a The page could not be translated message

translate

This is not working, I've to use Google Translator Extention

@ArisAmp
Copy link

ArisAmp commented Nov 26, 2018

+1 Right click -> Translate is a plugin to take the browser to the next level.

-For those who want to do that with a plugin, Mate Translate extension works perfectly good for my Brave Browser

@juanguren
Copy link

Hey guys, what´s the current status on this plugin/option?

@ArisAmp
Copy link

ArisAmp commented Dec 13, 2018

+1
Nothing happens when I click on translate

You need to download and crack mate translate. After install it you can use its plugin to translate pages in Brave Browser

@Hemicrusher
Copy link

Hemicrusher commented Dec 19, 2018

+1
Nothing happens when I click on translate

You need to download and crack mate translate. After install it you can use its plugin to translate pages in Brave Browser

Mate Translate does not work well. Many pages I go to Mate will only translate menus and not the body. Highlighting text and translate sucks.

Firefox also has the same issue as Brave in not having a native translator. I use this in Firefox and it works great. Maybe it could be ported over.....

https://github.com/andreicristianpetcu/google_translate_this

@hex0cter
Copy link

hex0cter commented Jan 6, 2019

+1

@2635599
Copy link

2635599 commented Jan 6, 2019

"I want to strongly back this addition. How many of us nowadays are living/working abroad for extensive periods of time? It's really hard to read any non-english local business website (or "non-your-native-language") without any kind of translate plugin. Not to mention the possibility to read some foreign language articles, having an invaluable help while learning a foreign language, and so on.

I like Brave browser but personally this single missing feature is what refrain me from completely dropping Chrome"

yes the builtin translate featire needs to be added back in. there was no real reason to remove it. brave is fast, responsive, crisp and clean looking, but make no mistake it has faults. the above being one, adding your would ad blocker without anyway to universally turn it off, adding rewards without a way to completely turn it off. the last two as far as i'm concerned are uncompleted features added.

@steferr
Copy link

steferr commented Jan 17, 2019

+1

@megalithic
Copy link

i find myself needing this more and more..

+1

@hex0cter
Copy link

hex0cter commented Jan 22, 2019

Please enable this feature!
+1

@dnet890
Copy link

dnet890 commented Jan 26, 2021

@serial02 may I know what kind of plugin do you use for translation?

@grahamperrin
Copy link

@ultrasound1372
Copy link

Will this work on file URLs? I have some local files that need translation that get updated a lot.

@dnet890
Copy link

dnet890 commented Jan 27, 2021

yes, I know some of the translations are broken and it will take some time to translate the web page. So, it will be nice if brave have built-in translation features like google chrome or Microsoft Edge.

@grahamperrin
Copy link

Will this work on file URLs? …

I don't know, but if you test I'll be interested in the result.

Bear in mind: translation by Google so I should not make the attempt with anything that's sensitive or confidential.

Thanks.

@dnet890
Copy link

dnet890 commented Jan 27, 2021

@grahamperrin for firefox I strongly recommend this (https://addons.mozilla.org/en-US/firefox/addon/traduzir-paginas-web/?utm_source=addons.mozilla.org&utm_medium=referral&utm_content=search) because I translate the webpage without jumping to other tabs

@grahamperrin
Copy link

grahamperrin commented Jan 27, 2021

translate the webpage without jumping to other tabs

S3.Translator does the same – In page translation for content – and more; you can try it at (for example) https://www.s3blog.org/s3gt.html

S3.Translator:

  • forewarns the end user before downloading the executable code
  • forewarns before attempting to translate secure (https) content

… and so on. Historically, it was a pick of the month:

image

@dnet890
Copy link

dnet890 commented Jan 28, 2021

this addon (https://addons.mozilla.org/addon/s3_translator/) looks ok. But, the main drawback is this popup sometimes occurred in certain sites and I found it is quite annoying. But, this addon ((https://addons.mozilla.org/en-US/firefox/addon/traduzir-paginas-web/?utm_source=addons.mozilla.org&utm_medium=referral&utm_content=search)) does not have this problem which is replicate the same experience as Google Chrome and Microsoft Edge
Screenshot_2021-01-28_10-32-50

@grahamperrin
Copy link

… quite annoying …

It's the forewarning that I mentioned in my previous comment.

Users might not understand the implications. Enhancement request: http://forums.mozillazine.org/viewtopic.php?f=48&t=2829503&p=14884322#p14884322

@dnet890
Copy link

dnet890 commented Jan 30, 2021

@grahamperrin if this addon (https://addons.mozilla.org/addon/s3_translator/) have an option/checkboxes to allow the user to translate the HTTPS page to prevent that popup appears. I think that will be nice.

@Ghedeon
Copy link

Ghedeon commented Feb 1, 2021

I'm confused about the status of this issue.
Google Translate extension is installed. There is no translate icon in the address bar and no context action to translate the page.

Version 1.19.88 Chromium: 88.0.4324.96 (Official Build) (x86_64)

@crogonint
Copy link

crogonint commented Feb 3, 2021

I'm pretty sure that Brave is intentionally NOT supporting Google spyware in their browser. That's why I recommended the Yahoo (Babelfish) service above. it's open source and reliable.

I have NO IDEA why some developer marked the status of this as closed. I'm pretty sure they haven't fulfilled the service yet.

Unless they did it upstream and didn't tell anybody?? Devs?

@dnet890
Copy link

dnet890 commented Feb 3, 2021

@crogonint Apertium (https://www.apertium.org/index.eng.html?dir=eng-epo#translation) is also open source and it is a good option as well

@bsclifton
Copy link
Member Author

bsclifton commented Feb 4, 2021

@crogonint issue was closed because we don't have a way to offer the functionality at the moment. We did explore using Microsoft language APIs and @yrliou got it working- but there is still a significant cost associated with those. Recommending the extension which does translate doesn't have any operating cost for us

On the API side, each call to Google/Microsoft/whoever is translating has a per-transaction cost. We can potentially open this issue again and mark it as blocked. We'd need help ID'ing a vendor which could help provide this and also not violate the user's privacy (since pages and content will be sent to vendor)

cc: @rebron

@manishmaharjan
Copy link

@bsclifton , I do understand you, but those extensions are not always working optimally. Most importantly, to my knowledge there is no any extensions that would be working in Brave mobile version. Has there been any plan on how to support translation feature in mobile?

Also, has there been any internal calculation done on how much costs would come towards brave possession on opting for inbuilt translation through some vendors? Has there been also some work done internally in negotiating those costs for the translation service, like volume license, etc. ? This issue has taken indefinitely longer time to resolve fully and still there hasn't been any viable solution towards this most prominent translation problem. if the costs is not too high, then we believe some alternative ways of mitigating the costs should be planned without compromising this vital feature.

@grahamperrin
Copy link

grahamperrin commented Feb 4, 2021

Posted to Reddit in November 2019:

– this three-year project is funded until the end of 2021.

https://old.reddit.com/r/TranslationStudies/comments/dtppt3/-/f6y1yq2/ tl;dr

… There's so much work in this area, it's difficult to know where to start. …

@crogonint
Copy link

crogonint commented Feb 6, 2021 via email

@zcraber
Copy link

zcraber commented May 5, 2021

Maybe this can be made possible by relying on open-source neural machine translation API like Argos Translate.

Argos Open Tech: https://www.argosopentech.com/
Live Demo (LibreTranslate): https://libretranslate.com/

@crogonint
Copy link

crogonint commented May 6, 2021 via email

@Samk19
Copy link

Samk19 commented May 31, 2021

+1 for open source language translation specially on ios and android app where we cannot install the extension

Please do implement an opensourced language translation feature in your mobile apps @bsclifton

Thankyou

@git10135405
Copy link

In today’s internationalization, brave-browser should support in-page translation, but GitHub and some websites cannot be translated only with the Google Translate plugin.

@Samk19
Copy link

Samk19 commented Jul 19, 2021

Any update regarding translation feature coming to brave mobile app?

@ghost
Copy link

ghost commented Feb 17, 2022

S3.Translator

https://chrome.google.com/webstore/detail/s3translator/debnnjfbneojbmioajinefnflopdohjk

I use it with Firefox – https://addons.mozilla.org/addon/s3_translator/

Best solution by far. S3. Can set homepages to be directly translated. It was afew clicks but on each route it translate automatically. Lifesafer!

@Samk19
Copy link

Samk19 commented Feb 18, 2022

But not a soln for mobile version of brave as extensions support is not available in ios nor Android

@dnet890
Copy link

dnet890 commented Feb 18, 2022

@stephyswe this is much more efficient than S3 https://github.com/FilipePS/Traduzir-paginas-web

@tachibana-shin
Copy link

Why doesn't Brave use the same API as Vivaldi did?

@blutch112
Copy link

Maybe something similar to the firefox translations extension that works locally.
https://addons.mozilla.org/fr/firefox/addon/firefox-translations/

@brave brave locked as resolved and limited conversation to collaborators Oct 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
closed/invalid feature/translate l10n priority/P3 The next thing for us to work on. It'll ride the trains. privacy/connect This requires making a network connection to a third-party service. QA/Yes release-notes/include
Projects
None yet
Development

Successfully merging a pull request may close this issue.