Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Replace "Wallet" text in Rewards contexts to say "Brave Rewards" #20998

Closed
1 of 3 tasks
Miyayes opened this issue Feb 9, 2022 · 1 comment · Fixed by brave/brave-core#13518
Closed
1 of 3 tasks
Assignees
Labels
feature/rewards OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/exclude

Comments

@Miyayes
Copy link
Collaborator

Miyayes commented Feb 9, 2022

Description

  • Update strings inside Rewards dropdown panel
  • Tipping banner text
  • Will inherit all the strings from Brave Rewards settings page for free

Android version of: #19768

@Uni-verse
Copy link
Contributor

Uni-verse commented Jul 12, 2022

Verification completed on Samsung GS 21 & Tab S7 using

Brave	1.41.95 Chromium: 103.0.5060.114 (Official Build) (64-bit) 
Revision	a1c2360c5b02a6d4d6ab33796ad8a268a6128226-refs/branch-heads/5060@{#1124}
OS	Android 12; Build/SP1A.210812.016

Rewards Welcome Tour

  • Confirmed Brave Rewards text is used instead of Wallet
1 2 3
0 0 0

Brave://rewards

Gemini Uphold
0 !0

Rewards Panel

Unverified Uphold Gemini
0 0 0

Reset Rewards

0

Rewards internals

screenshot-1657596291709

Verified dropdown/Verifying Wallets

  • Confirmed 'wallet' text doesn't appear instead of Brave Rewards in the verified dropdown or when user connects to custodian.
Uphold Gemini Verify
08 07 0

Tip Banners

  • Confirmed theres no mention of wallet text in Tip banners
One Time Monthly
14 12

System Notification (first ad)

  • Introduction notification contains Brave Rewards in description
10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/rewards OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/exclude
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants